8000 fix(minimal,minimald): finalize-install installs the QUIC block helper and reports its status apart by minimal-foundry[bot] · Pull Request #3620 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal,minimald): finalize-install installs the QUIC block helper and reports its status apart - #3620

Merged
norrietaylor merged 7 commits into
mainfrom
agent/3581-finalize-install-installs-the-quic-block-helper
Nov 20, 2026
Merged

norrietaylor merged 7 commits into
mainfrom
agent/3581-finalize-install-installs-the-quic-block-helper

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3581

Task marker
### D3573 — finalize-install installs the QUIC block helper and reports its status apart from a classifier ct-mark refusal
  kind: task
  size: M
  est: 180 code, 160 tests
  executor: agent
  origin: bug
  epic: 1437
  layers:
    - script:
      - scripts/install-host-classifier.sh: adds a helper-only mode that installs QUIC443_HELPER and its sudoers rule without scan_ct_mark_conflicts. The refusal names the program that owns the rule and a
8000
 free --ct-mark-mask when one exists.
      - crates/minimald/src/net/classifier.rs: adds installer tests: a refusal names the owning program and a free mask, and the helper-only mode installs the helper over a conflicting host ruleset
      test: cargo test -p minimald install_refusal_names_rule_owner_and_free_mask
      test: cargo test -p minimald quic443_helper_only_installs_over_ct_mark_conflict
    - cli:
      - crates/minimal/src/cmd/finalize_install.rs: gives quic443_helper_item_over its own script block for the helper-only mode, so the plan does not dedupe it into the classifier step. The run summary reports each item result separately.
      test: cargo test -p minimal quic443_helper_installs_when_classifier_step_refuses
      test: cargo test -p minimal summary_reports_each_item_after_classifier_refusal
  proof: On a host with a rule that uses the install's ct-mark bits, min finalize-install installs /usr/local/lib/minimal/quic443-leaf and its sudoers rule. It shows the QUIC block helper as done and the classifier as refused, and names the rule owner and a free --ct-mark-mask.

Proof

On a host with a rule that uses the install's ct-mark bits, min finalize-install runs the QUIC block helper's own block first (install-host-classifier.sh --quic443-helper-only). That block installs /usr/local/lib/minimal/quic443-leaf and its sudoers rule without the ct-mark scan. The classifier step then refuses. Its error lists the rule, says which program the rule belongs to by its table or chain name, and names a free mask: 'To use them, run: min finalize-install --ct-mark-mask 0x...'. After that, the run prints one line per item: '✓ QUIC block helper: installed' and '✗ deny-all egress enforcement ...: not installed'.

Notes from the agent: Wording: the run report marks the classifier item as 'not installed', not 'refused'. The report reads the host again after the script stops, and that read proves only whether each item is installed. The refusal itself is the step's error printed above the report. The first line of the report says the script stopped with that error.

The program that owns a rule is matched by its table or chain name (Tailscale ts-, kube-, DOCKER*, firewalld, netavark, libvirt*, wg-quick, cilium*, cali-, ufw, f2b-*, mullvad). If no name matches, the line says the step cannot name the program. A Tailscale CONNMARK in the plain mangle OUTPUT chain does not match by name.

The free mask is the highest pair of contiguous bits that no scanned rule uses and that no well-known range touches. It prints on its own line before the old closing sentence. The closing sentence 'Choose two contiguous bits ... --ct-mark-mask ' stays the same, because scripts/install_test.sh (outside the layers) pins it at the end of a line. No free-mask line prints for a whole-mark writer or an unlisted CONNMARK, because no mask avoids either one.

The helper block stages a second copy of the classifier script, at install-host-classifier.sh.quic443, and removes it after the run. So --show --script prints the step's bytes twice when both items are missing. …[truncated]

Tests

line exit tail
cargo test -p minimald install_refusal_names_rule_owner_and_free_mask 0 running 1 test test net::classifier::tests::install_refusal_names_rule_owner_and_free_mask ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1515 filtered out; finished in 0.50s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; finishe
cargo test -p minimald quic443_helper_only_installs_over_ct_mark_conflict 0 running 1 test test net::classifier::tests::quic443_helper_only_installs_over_ct_mark_conflict ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1515 filtered out; finished in 0.18s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; fin
cargo test -p minimal quic443_helper_installs_when_classifier_step_refuses 0 led; 0 ignored; 0 measured; 1027 filtered out; finished in 0.03s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 41 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s runni
cargo test -p minimal summary_reports_each_item_after_classifier_refusal 0 running 1 test test cmd::finalize_install::tests::summary_reports_each_item_after_classifier_refusal ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1027 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 41 filtered ou

Verify

min task run agent-verify timed out after 1800s, so this PR is a draft.

h/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 36s
 Downloading crates ...
  Downloaded chacha20 v0.9.1
  Downloaded arbitrary v1.5.0
  Downloaded aead v0.5.2
  Downloaded axum-core v0.5.6
  Downloaded cipher v0.4.4
  Downloaded blake2 v0.10.6
  Downloaded downcast v0.11.0
  Downloaded boringtun v0.7.1
  Downloaded chacha20poly1305 v0.10.1
  Downloaded fragile v2.1.0
  Downloaded axum v0.8.9
  Downloaded curve25519-dalek v4.1.3
  Downloaded hmac v0.12.1
  Downloaded ip_network_table v0.2.0
  Downloaded inout v0.1.4
  Downloaded ip_network_table-deps-treebitmap v0.5.0
  Downloaded ip_network v0.4.1
  Downloaded mockall v0.15.0
  Downloaded matchit v0.8.4
  Downloaded termtree v0.5.1
  Downloaded multimap v0.10.1
  Downloaded predicates-core v1.0.10
  Downloaded universal-hash v0.5.1
  Downloaded predicates-tree v1.0.13
  Downloaded tonic-prost-build v0.14.6
  Downloaded predicates v3.1.4
  Downloaded prost-build v0.14.4
  Downloaded opaque-debug v0.3.1
  Downloaded tonic-build v0.14.6
  Downloaded poly1305 v0.8.0
  Downloaded pulldown-cmark-to-cmark v22.0.0
  Downloaded x25519-dalek v2.0.1
  Downloaded mockall_derive v0.15.0
  Downloaded prettyplease v0.2.37
  Downloaded pulldown-cmark v0.13.6
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

…k mask

The classifier step gains --quic443-helper-only, which installs the
helper and its sudoers rule without the ct-mark scan. A ct-mark refusal
now names the program each rule belongs to and a free --ct-mark-mask.
The helper item carries its own block, the classifier step's helper-only
mode, so a classifier refusal leaves the helper installed. A run whose
script stops reports each item it carried as installed or not.
@coderabbitai
coderabbitai Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ba54845d-4ae5-434b-bf25-2cb3a6e647f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor
Copy link
Copy Markdown
Member

Un-drafted: the agent-verify result is the same minimald trace-span failure (or a 1800 s verify timeout) seen across this batch, not a failure in this diff. Every lane is green.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-foundry
minimal-foundry Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 17d8c5a60622.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Section 7.4 of the networking design keeps the classifier behind one privileged install step, with no prompt at session start. The helper-only mode stays in that step and in the same script. The daemon still fails a launch when the helper refuses an add, so a helper without the classifier table cannot open QUIC. No condition is necessary.

Ruled at b3ea623 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helper-only mode, the rule-owner and free-mask lines in the refusal, and the per-item report after a failed run all hold up when traced through the script and the CLI. I found nothing wrong in free_ct_mark_mask (the subshell, restoring the chosen bits, avoiding the well-known ranges), in the --help range change, or in the new tests. There is one Medium finding. The QUIC helper block now runs ahead of every missing item, and it exits the script when it fails. So a helper failure, such as a missing nft, also skips the userns-profile and names items, which used to install before the classifier step. This goes further than the open thread about the classifier being skipped.


Generated by Claude Code

@norrietaylor
Copy link
Copy Markdown
Member

/revise Fix the two open MEDIUM threads in crates/minimal/src/cmd/finalize_install.rs. script_first puts the QUIC helper block ahead of every missing item, and the block ends with exit "$quic443_status" (around line 1708). So a failure of the helper-only mode, such as a missing nft or an unverified mount, stops the script before the classifier, userns-profile and names blocks run. Order the helper block only where it must sit, ahead of the classifier step. Do not exit the whole script on a helper failure: record its status, let the later blocks run, and make the script's final exit status non-zero if any block failed. Add a test where the helper block fails and the classifier, userns and names blocks still run, with a non-zero final status. Update any printed text that changes, and its pinning test.

1 similar comment
@norrietaylor
Copy link
Copy Markdown
Member

/revise Fix the two open MEDIUM threads in crates/minimal/src/cmd/finalize_install.rs. script_first puts the QUIC helper block ahead of every missing item, and the block ends with exit "$quic443_status" (around line 1708). So a failure of the helper-only mode, such as a missing nft or an unverified mount, stops the script before the classifier, userns-profile and names blocks run. Order the helper block only where it must sit, ahead of the classifier step. Do not exit the whole script on a helper failure: record its status, let the later blocks run, and make the script's final exit status non-zero if any block failed. Add a test where the helper block fails and the classifier, userns and names blocks still run, with a non-zero final status. Update any printed text that changes, and its pinning test.

The helper block moved to the head of the finalize-install script and
exited on failure, so a helper refusal skipped the userns-profile,
names and classifier blocks. It now sits just before the classifier
block, records its status, and the script ends with that status after
every later block ran.
@minimal-foundry
8BD0 Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as c32577108520.

line exit tail
cargo test -p minimald install_refusal_names_rule_owner_and_free_mask 0 running 1 test test net::classifier::tests::install_refusal_names_rule_owner_and_free_mask ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1523 filtered out; finished in 0.46s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; finishe
cargo test -p minimald quic443_helper_only_installs_over_ct_mark_conflict 0 running 1 test test net::classifier::tests::quic443_helper_only_installs_over_ct_mark_conflict ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1523 filtered out; finished in 0.16s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; fin
cargo test -p minimal quic443_helper_installs_when_classifier_step_refuses 0 led; 0 ignored; 0 measured; 1042 filtered out; finished in 0.04s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s runni
cargo test -p minimal summary_reports_each_item_after_classifier_refusal 0 running 1 test test cmd::finalize_install::tests::summary_reports_each_item_after_classifier_refusal ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1042 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered ou

Verify min task run agent-verify timed out after 1800s.

h/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 30s
 Downloading crates ...
  Downloaded fragile v2.1.0
  Downloaded downcast v0.11.0
  Downloaded aead v0.5.2
  Downloaded blake2 v0.10.6
  Downloaded chacha20 v0.9.1
  Downloaded axum-core v0.5.6
  Downloaded cipher v0.4.4
  Downloaded boringtun v0.7.1
  Downloaded arbitrary v1.5.0
  Downloaded chacha20poly1305 v0.10.1
  Downloaded axum v0.8.9
  Downloaded curve25519-dalek v4.1.3
  Downloaded hmac v0.12.1
  Downloaded inout v0.1.4
  Downloaded ip_network v0.4.1
  Downloaded ip_network_table-deps-treebitmap v0.5.0
  Downloaded ip_network_table v0.2.0
  Downloaded matchit v0.8.4
  Downloaded mockall v0.15.0
  Downloaded mockall_derive v0.15.0
  Downloaded multimap v0.10.1
  Downloaded opaque-debug v0.3.1
  Downloaded poly1305 v0.8.0
  Downloaded predicates-tree v1.0.13
  Downloaded predicates v3.1.4
  Downloaded predicates-core v1.0.10
  Downloaded pulldown-cmark-to-cmark v22.0.0
  Downloaded prettyplease v0.2.37
  Downloaded pulldown-cmark v0.13.6
  Downloaded prost-build v0.14.4
  Downloaded termtree v0.5.1
  Downloaded tonic-prost-build v0.14.6
  Downloaded tonic-build v0.14.6
  Downloaded universal-hash v0.5.1
  Downloaded x25519-dalek v2.0.1
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/finalize_install.rs: The helper block no longer exits. It records quic443_status, the classifier block still runs, and the script ends with the helper's status after every block. The new test is quic443_helper_failure_lets_later_blocks_run.
  • 👍 valid — crates/minimal/src/cmd/finalize_install.rs: script_first is now script_before(classifier): the helper block keeps plan order and moves only to just ahead of the classifier block. quic443_helper_failure_lets_later_blocks_run makes userns-profile, names, classifier and helper all missing. It asserts that the helper block comes after the userns

On a host with a rule that uses the install's ct-mark bits, min finalize-install installs /usr/local/lib/minimal/quic443-leaf and its sudoers rule before the classifier step refuses. The run shows the QUIC block helper as installed and the classifier as not installed, and the refusal names the rule owner and a free --ct-mark-mask. A helper step that fails no longer skips the userns-profile, names or classifier steps. The script ends with a non-zero status.

Notes from the agent: Revise round 2. Item.script_first is replaced by script_before (the id of the item whose block this one runs just ahead of) and script_end (a line the script runs after every block). The helper block now keeps plan order except that it moves to just before the classifier block when the classifier is also missing. It records quic443_status and no longer exits. The script ends with [ "$quic443_status" -eq 0 ] || exit "$quic443_status", so a helper failure makes the final status non-zero after later blocks ran. A classifier refusal still ends the script at once under set -eu. No printed text changed. Only the script comments changed. The new test quic443_helper_failure_lets_later_blocks_run uses stub blocks with the real userns-profile and names ids, because their real blocks need host tools that the confined runner does not have. I did not run just ci or clippy-strict. cargo clippy -p minimal --all-targets printed no warnings.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 19:35
auto-merge was automatically disabled November 19, 2026 19:35

Pull request was converted to draft

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this com 10000 ment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The fix commit keeps the QUIC block helper inside the privileged install step that §7.4 line 282 describes. Its block now runs just ahead of the classifier block. A failed helper step no longer stops the later blocks, and the script still ends non-zero with the helper step's status. The rest of the change keeps the earlier PASS at b3ea6234. No conditions.

Ruled at c325771 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/install-host-classifier.sh Resolved
The note named every well-known program, but the scan reads the host's
rule listings and two known mark ranges. Say that no rule this step read
and no program this step knows uses the bits.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as 17d8c5a60622.

line exit tail
cargo test -p minimald install_refusal_names_rule_owner_and_free_mask 0 running 1 test test net::classifier::tests::install_refusal_names_rule_owner_and_free_mask ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1523 filtered out; finished in 0.52s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; finishe
cargo test -p minimald quic443_helper_only_installs_over_ct_mark_conflict 0 running 1 test test net::classifier::tests::quic443_helper_only_installs_over_ct_mark_conflict ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1523 filtered out; finished in 0.17s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 13 filtered out; fin
cargo test -p minimal quic443_helper_installs_when_classifier_step_refuses 0 led; 0 ignored; 0 measured; 1042 filtered out; finished in 0.04s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s runni
cargo test -p minimal summary_reports_each_item_after_classifier_refusal 0 running 1 test test cmd::finalize_install::tests::summary_reports_each_item_after_classifier_refusal ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1042 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered ou

Verify min task run agent-verify timed out after 1800s.

serial_test v4.0.1
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 09s
 Downloading crates ...
  Downloaded arbitrary v1.5.0
  Downloaded aead v0.5.2
  Downloaded axum-core v0.5.6
  Downloaded cipher v0.4.4
  Downloaded chacha20 v0.9.1
  Downloaded axum v0.8.9
  Downloaded blake2 v0.10.6
  Downloaded chacha20poly1305 v0.10.1
  Downloaded boringtun v0.7.1
  Downloaded downcast v0.11.0
  Downloaded curve25519-dalek v4.1.3
  Downloaded fragile v2.1.0
  Downloaded hmac v0.12.1
  Downloaded ip_network_table-deps-treebitmap v0.5.0
  Downloaded inout v0.1.4
  Downloaded ip_network v0.4.1
  Downloaded ip_network_table v0.2.0
  Downloaded matchit v0.8.4
  Downloaded mockall v0.15.0
  Downloaded multimap v0.10.1
  Downloaded mockall_derive v0.15.0
  Downloaded opaque-debug v0.3.1
  Downloaded poly1305 v0.8.0
  Downloaded predicates-tree v1.0.13
  Downloaded predicates v3.1.4
  Downloaded predicates-core v1.0.10
  Downloaded prettyplease v0.2.37
  Downloaded prost-build v0.14.4
  Downloaded pulldown-cmark-to-cmark v22.0.0
  Downloaded pulldown-cmark v0.13.6
  Downloaded termtree v0.5.1
  Downloaded tonic-build v0.14.6
  Downloaded tonic-prost-build v0.14.6
  Downloaded universal-hash v0.5.1
  Downloaded x25519-dalek v2.0.1
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Converted to a draft: verify timed out after 1800s.

Review threads the coder judged:

  • 👍 valid — scripts/install-host-classifier.sh: Reworded the free-mask line to claim only the scanned rules and the known mark ranges, and updated the test that pins it.

On a host with a rule that uses the install's ct-mark bits, min finalize-install installs /usr/local/lib/minimal/quic443-leaf and its sudoers rule. The summary shows the QUIC block helper as done and the classifier as refused. The refusal names the program that owns the rule and a free --ct-mark-mask, and the free-mask line now claims only what the scan checked.

Notes from the agent: Revise round 3. One change: the free-mask line now reads 'No rule this step read uses the bits , and no program this step knows marks connections with them.' The test install_refusal_names_rule_owner_and_free_mask pins the new text.

@norrietaylor
norrietaylor marked this pull request as ready for review November 20, 2026 03:20
@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This push changes only the wording of the free-mask line in the ct-mark refusal and the test that pins it. The new text says only what the scan read, and the step still refuses. The classifier stays in the privileged install step (architecture.md lines 1105-1107). The earlier PASS stands for the rest of the change.

Ruled at 17d8c5a against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 20, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate passed at 17d8c5a: minimal-review and arch approved, lanes green, no open threads.

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 38e5f83 Nov 20, 2026
40 checks passed
@norrietaylor
norrietaylor deleted the agent/3581-finalize-install-installs-the-quic-block-helper branch November 20, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3573 — finalize-install installs the QUIC block helper and reports its status apart from a classifier ct-mark refusal

1 participant

0