8000 fix(scripts): say only what the free ct-mark mask scan checked · gominimal/minimal@17d8c5a · GitHub
[go: up one dir, main page]

Skip to content

fix(scripts): say only what the free ct-mark mask scan checked

Minimal Arch / arch-review succeeded Nov 20, 2026 in 0s

PASS

Inputs. Re-review of #3620 at 17d8c5a6, on arch 8b824707. This is the same arch as the earlier PASS rulings at b3ea6234 and c3257710. since-conditions.json is empty, and the latest ruling on this PR is the PASS at c3257710. So no condition is open, and the compare is enough. I checked that git diff c3257710..17d8c5a6 is the same as since.diff. No findings.json or arch-map.md is staged.

Compare. One commit, fix(scripts): say only what the free ct-mark mask scan checked. It changes one sentence in scripts/install-host-classifier.sh scan_ct_mark_conflicts(): "No rule on this host uses ..." becomes "No rule this step read uses ...", and "no well-known program" becomes "no program this step knows". crates/minimald/src/net/classifier.rs test install_refusal_names_rule_owner_and_free_mask pins the new text. The Rust string, with its \ line joins, is the same as the new printf format. The refusal still ends in die, so the step still fails closed.

Governs. architecture.md Box Spec (lines 1105-1107) puts the classifier in the privileged install step. Networking design §4.1 owns the cgroup classifier. The design says nothing about the wording of the ct-mark refusal. The new sentence claims less than the old one, and it says only what the scan checked. That matches the repo rule on user-facing text (AGENTS.md, "Say only what the code can prove"). That rule is not part of the design of record, so I do not cite it as a design line.

Ruling. The compare does not move the classifier, the helper-only block or the refusal, so the ruling at c3257710 stands for them. I depart from no precedent.

Not checked. I did not run the tests. The rules for this review do not allow a build.

Ruled at 17d8c5a against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1538, job 1533377c-8da8-4526-9cd9-7b265ef4e649.

0