8000 Merge remote-tracking branch 'origin/main' into agent/3602-bare-min-box-spec-prints-the-proxy-rows-of-the-e · gominimal/minimal@81973d7 · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into agent/3602-bare-min-b…

Minimal Arch / arch-review succeeded Nov 19, 2026 in 0s

PASS

Inputs. Re-review of #3612 at 81973d7c, on arch 8b824707, the same arch as every earlier ruling on this PR. The baseline is the CONDITIONS at 87f9257f. since-conditions.json carries its C1, and since.diff starts at 87f9257f. The compare holds two PR commits, 61814589 (fix) and 78258a85 (format), and the merge 81973d7c of main (through #3605). No findings.json or arch-map.md is staged.

Governs: gatehouse §6.10 Validation (normative) (specs/authn-authz/gatehouse-spec.md line 853): a broker grant whose module host set the box's egress does not fully admit is a validation error. Egress §5.4 (specs/networking/deployment-and-egress-gateway.md line 158): the credentialed set stays a subset of the egress allow-list, and min box spec renders it read-only.

Conditions. C1: met. project_network() in crates/minimal/src/cmd/box_spec.rs now calls the new session_defaults_egress() in the SessionEntryUndecided arm, in place of Default::default(). That helper builds the same implicit BoxEntry (DEFAULT_ENTRY_NAME, EntryTable::Sessions, SESSION_BOX_TYPE, empty body, implicit: true) that session_defaults_rows() expands, and reads its egress through entry_egress, now pub(crate) in cmd/boxes/create.rs and reached through the box_verbs glob re-export. The comment and the tracing::debug! text say this. The test box_spec_bare_reads_defaults_network_bep_undecided_entry_own_ip_egress sets two session entries, a [defaults.network.egress] that admits the four hosts of the v1 GitHub set (§6.10 line 852; crates/boxes/src/lib.rs line 114 lists the same hosts), and a [defaults.session.secrets.GH_TOKEN] broker grant. It runs bare --network own_ip and expects rows, not a refusal. Before the fix the egress was empty, so this test proves the admission rule and does not relax it.

Ruling. The grants and the egress that checks them now come from one entry, as §6.10 and §5.4 require. The merge of main does not touch the PR's hunks: git diff 2265c355 HEAD holds only the three PR files. Everything else keeps the status of the earlier rulings.

Not checked. I did not run the tests (no build). The PR body reports one failure in min task run agent-verify: minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace. That test is about trace propagation in exec/task run and does not exercise box_spec.rs, so this ruling does not depend on it. The PR stays a draft until it is green. A small cosmetic slip: commit 61814589 drops the space in the test comment // BCLI-021: before `min. This is not a design matter.

Ruled at 81973d7 against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1500, job 690087bc-5feb-4f9d-a3c4-7c47c34016df.

0