Repository navigation
fix(minimal): bare min box spec prints the proxy rows of the expanded session entry, so - #3612
Conversation
The proxy rows of bare min box spec read the raw [defaults.session] table, so [defaults.network.bep] never reached its steering row. They now read project_bep_and_grants, the expansion min box start uses.
…ox-spec-prints-the-proxy-rows-of-the-e
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
|
Un-drafted: the |
|
/review |
|
/arch-review |
|
Approved: no findings at Nothing to do. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
Bare min box spec now reads the same expanded session entry that min box start grants from. It reads it through project_bep_and_grants, so [defaults.network.bep] reaches the steering row. This follows the single expansion order in architecture.md, minimal.toml layout, lines 1247-1253. A file that does not expand now refuses the render, as start refuses it. The new test proves the bare row and the default entry row. The agent-verify failure is in an otel trace test that this diff does not touch. Look at it before the merge.
Ruled at 2a8f154 against gominimal/arch@8b824707cde6 by claude-opus-5-5.
…ox-spec-prints-the-proxy-rows-of-the-e
A project with no single session entry made the bare form end with the start's refusal. The rows now fall back to the [defaults.session] table.
…ox-spec-prints-the-proxy-rows-of-the-e
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Converted to a draft: something above needs a person before review. Review threads the coder judged:
With steering = proxy_env under [defaults.network.bep], bare min box spec prints the row 'steering proxy_env', the same value that min box spec default prints. A project with two session entries and no default still gets its bare preview from the [defaults.session] table, and does not get the start's refusal. Notes from the agent: Revise round 1. When the start cannot pick one session entry (SessionEntryUndecided), bare min box spec now reads the [defaults.session] table rows, as it did before this PR, and does not refuse. A new test pins this and the test line's filter matches it. cargo clippy -p minimal --all-targets is clean. I did not run just clippy-strict. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
The main path still reads the expanded session entry, and it conforms. The new fallback for an undecided session entry reads only [defaults.session]. It drops [defaults], and architecture.md line 1223 merges [defaults] into every entry. So with [defaults.network.bep] and two session entries, the bare form prints a steering value that no session gets. Make the change in C1, and add the test it names.
Ruled at 66d7948 against gominimal/arch@8b824707cde6 by claude-opus-5-5.
|
/revise Arch C1 and one review finding on 66d7948:
|
When the start cannot pick one session entry, the bare rows now expand an entry with an empty body over [defaults] and [defaults.session], so [defaults.network.bep] reaches the steering row and the command still succeeds.
|
Round 2 of 10 on a /revise note, pushed as
Verify Converted to a draft: something above needs a person before review. Review threads the coder judged:
With steering = proxy_env under [defaults.network.bep], bare min box spec prints steering proxy_env, the same value as min box spec dev. This is also true when the project has several session entries and no default: the bare command exits 0 and prints the merged [defaults] and [defaults.session] rows. Notes from the agent: Revise round 2. The fallback for SessionEntryUndecided (NoDefault, DefaultNotSession, TypeUnresolved) now expands an empty-body session entry over [defaults] and [defaults.session] through mfile::expand, in a new helper session_defaults_rows in box_spec.rs. It does not go through pick_session_entry, so the bare form does not refuse for the pick. A project with only task entries gets the implicit default entry and takes the main path. New test box_spec_bare_reads_defaults_network_bep_top_level_undecided_entry covers [defaults.network.bep] with two session entries and no default, and asserts success. cargo clippy -p minimal --all-targets is clean. just clippy-strict was not run. |
|
The runtime will not revise this pull request again on its own: the diff is +156/-14 (170 lines), past 3x the plan's estimate of 55 lines (est: 25 code, 30 tests, as #3602 reads now), at round 2 (the last trigger was a /revise note). A person decides now. Remove |
|
Marked ready: the lanes are green at this head. |
|
/review |
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
C1 is met. With no single session entry, bare min box spec now expands an empty-body session entry over [defaults] and [defaults.session], as architecture.md lines 1223 and 1224 require. The new test sets [defaults.network.bep] with two session entries and asserts the steering proxy_env row. No condition is open.
Ruled at d676657 against gominimal/arch@8b824707cde6 by claude-opus-5-5.
|
Marked ready: the round pushed and every lane aggregator is green at 81973d7; the draft came from the round's verify step, not from a failing lane. |
|
/review |
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
C1 is met. With no single session entry, bare min box spec now reads the egress of the same empty-body session entry that it reads the grants from. The §6.10 admission check therefore sees [defaults.network] and [defaults.session.network] egress. The new test proves that an own_ip preview renders an admitted broker grant and does not refuse. The agent-verify failure is in an unrelated otel trace test, and this ruling does not depend on it.
Ruled at 81973d7 against gominimal/arch@8b824707cde6 by claude-opus-5-5.
|
/revise
Run |
|
That What the platform saidcould not start the coder: Error: there is no container instance that can be provided to this durable object Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet. |
…ox-spec-prints-the-proxy-rows-of-the-e
Several session entries with no default still preview the merged [defaults] rows. A project Box Type entry or a non-session default keeps the start's refusal. Restore the BCLI-021 comment spacing.
|
Round 7 of 10 on a /revise note, pushed as
Verify Outside the task's
Converted to a draft: verify exited 100; outside the task's Review threads the coder judged:
With steering = proxy_env under [defaults.network.bep], bare min box spec prints steering proxy_env, the same value as min box spec default. A project whose default entry has a project Box Type gets the start's refusal from bare min box spec, not proxy rows. Notes from the agent: The directive says to keep the fallback for a project that declares no session entry at all. In that case pick_session_entry picks the implicit default entry and does not fail. The only remaining SessionEntryUndecided case is NoDefault (several session entries, none named default). So both fallbacks (project_rows and the egress fallback in project_network) now match NoDefault only. Arch condition C1 holds: the egress fallback narrows the same way, so rows and egress come from the same empty-body entry. |
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 3 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:491, minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:450, minimal-foundry[bot] crates/minimal/src/tests.rs. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The new commit limits the bare-form fallback to several session entries with no default. A non-session default entry and a project Box Type entry now get the start's refusal. Line 1229 of architecture.md says a non-session default blocks the implicit session entry. So the bare form now has no implicit entry to preview, and the refusal is correct. The change conforms, and no condition is open.
Ruled at 87590bd against gominimal/arch@8b824707cde6 by claude-opus-5-5.
|
Marked ready: round 7 pushed 87590bd and every lane is green; the draft came from the round's verify step. |
|
/review |
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
Bare min box spec now reads the same expanded session entry that min box start grants from. A [defaults.network.bep] steering mode now reaches its row, as the expansion order in architecture.md line 1250 requires. With several session entries and no default, the preview expands an entry with an empty body through the same box_entry and entry_egress helpers, and the other undecided cases still refuse. The code stays in the minimal CLI crate and reuses the start's expansion. No condition is open.
Ruled at 87590bd against gominimal/arch@8b824707cde6 by claude-opus-5-5.
|
/review |
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 87590bd41082 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
There was a problem hiding this comment.
Gate passed at 87590bd: minimal-review approved, arch PASS, lanes green, no open threads.
Follow-up
Fixes #3602
crates/minimal/src/cmd/box_spec.rscrates/minimal/src/tests.rsTask marker
Proof
A project that sets steering = proxy_env under [defaults.network.bep] now gets the row 'steering proxy_env' from bare min box spec. min box spec default shows the same value.
Notes from the agent: project_rows still returns the 'No minimal.toml found' error when the project file is missing. After that check, it reads bep, secrets and quic443 from crate::project_bep_and_grants(project, None). A project path that is not UTF-8 now fails with a plain error. The refusal tables stay BepTables::SESSION, because the task did not ask to change them. The other 20 box_spec tests also pass, and so does box_spec_path_form_renders_bep_rows, which uses the legacy [session] table. cargo clippy -p minimal --all-targets is clean. I did not run just clippy-strict.
Tests
cargo test -p minimal box_spec_bare_reads_defaults_network_bepVerify
min task run agent-verifyexited 100, so this PR is a draft.Base
The base branch moved while the coder worked; it was merged in before the tests ran.