8000 fix(minimal): bare min box spec prints the proxy rows of the expanded session entry, so by minimal-foundry[bot] · Pull Request #3612 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): bare min box spec prints the proxy rows of the expanded session entry, so - #3612

Merged
mitodrummer merged 19 commits into
mainfrom
agent/3602-bare-min-box-spec-prints-the-proxy-rows-of-the-e
Nov 19, 2026
Merged

mitodrummer merged 19 commits into
mainfrom
agent/3602-bare-min-box-spec-prints-the-proxy-rows-of-the-e

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3602

Task marker
### D3598 — Bare min box spec prints the proxy rows of the expanded session entry, so [defaults.network.bep] sets its steering row
  kind: task
  size: S
  est: 25 code, 30 tests
  executor: agent
  origin: bug
  epic: 1501
  layers:
    - cli:
      - crates/minimal/src/cmd/box_spec.rs: project_rows reads bep, quic443 and secrets from create::project_bep_and_grants(project, None) in place of the raw [defaults.session] table, and the SpecInputs.bep doc names the expansion
      - crates/minimal/src/tests.rs: adds a test: a project sets steering = proxy_env under [defaults.network.bep], and bare box_spec_text shows a steering proxy_env row
      test: cargo test -p minimal box_spec_bare_reads_defaults_network_bep
  proof: With steering = proxy_env under [defaults.network.bep], bare min box spec prints steering proxy_env, the same value as min box spec dev.

Proof

A project that sets steering = proxy_env under [defaults.network.bep] now gets the row 'steering proxy_env' from bare min box spec. min box spec default shows the same value.

Notes from the agent: project_rows still returns the 'No minimal.toml found' error when the project file is missing. After that check, it reads bep, secrets and quic443 from crate::project_bep_and_grants(project, None). A project path that is not UTF-8 now fails with a plain error. The refusal tables stay BepTables::SESSION, because the task did not ask to change them. The other 20 box_spec tests also pass, and so does box_spec_path_form_renders_bep_rows, which uses the legacy [session] table. cargo clippy -p minimal --all-targets is clean. I did not run just clippy-strict.

Tests

line exit tail
cargo test -p minimal box_spec_bare_reads_defaults_network_bep 0 running 1 test test tests::box_spec_bare_reads_defaults_network_bep ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1026 filtered out; finished in 0.01s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 41 filtered out; finished in 0.00s running 0

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "e81d91ec994e3867",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "4fbdc92f3f2d4bd2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "4fbdc92f3f2d4bd2",
                "queued_behind": "0",
                "span_id": "d4fae60f923e4520",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "e81d91ec994e3867",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "9aedaad324ad084f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "9aedaad324ad084f",
                "queued_behind": "0",
                "span_id": "0d2455b89d7573e3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "9aedaad324ad084f",
                "queued_behind": "0",
                "span_id": "eeb854fc23182979",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "eeb854fc23182979",
                "span_id": "d78113338228e2e8",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "eeb854fc23182979",
                "queued_behind": "0",
                "span_id": "e9d734dfe3d408cc",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  80.464s] 1197 tests run: 1196 passed, 1 failed, 2 skipped
        FAIL [  12.793s] (1197/1197) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

The proxy rows of bare min box spec read the raw [defaults.session]
table, so [defaults.network.bep] never reached its steering row. They
now read project_bep_and_grants, the expansion min box start uses.
@coderabbitai
coderabbitai Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd748a28-89b4-489b-a074-d276cb132ae3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor
Copy link
Copy Markdown
Member

Un-drafted: the agent-verify result is the same minimald trace-span failure (or a 1800 s verify timeout) seen across this batch, not a failure in this diff. Every lane is green.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-foundry
minimal-foundry Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 87590bd41082.

Nothing to do.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

Bare min box spec now reads the same expanded session entry that min box start grants from. It reads it through project_bep_and_grants, so [defaults.network.bep] reaches the steering row. This follows the single expansion order in architecture.md, minimal.toml layout, lines 1247-1253. A file that does not expand now refuses the render, as start refuses it. The new test proves the bare row and the default entry row. The agent-verify failure is in an otel trace test that this diff does not touch. Look at it before the merge.

Ruled at 2a8f154 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

A project with no single session entry made the bare form end with the
start's refusal. The rows now fall back to the [defaults.session] table.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 66d794865470.

line exit tail
cargo test -p minimal box_spec_bare_reads_defaults_network_bep 0 running 2 tests test tests::box_spec_bare_reads_defaults_network_bep_undecided_entry ... ok test tests::box_spec_bare_reads_defaults_network_bep ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 1030 filtered out; finished in 0.01s running 0 tests test result: ok. 0 passed; 0 f

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "0086a27a8c125ecb",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "7015f00c4fd8511b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "7015f00c4fd8511b",
                "queued_behind": "0",
                "span_id": "faccdf07326c32f1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "0086a27a8c125ecb",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "a0a1431869dd7584",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "a0a1431869dd7584",
                "queued_behind": "0",
                "span_id": "5adfc2f64a63f896",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "a0a1431869dd7584",
                "queued_behind": "0",
                "span_id": "ab3ba6352c1e9b25",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "ab3ba6352c1e9b25",
                "span_id": "434b3959a6249456",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "ab3ba6352c1e9b25",
                "queued_behind": "0",
                "span_id": "8af422c3247024cf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  82.886s] 1202 tests run: 1201 passed, 1 failed, 2 skipped
        FAIL [  12.905s] (1202/1202) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/box_spec.rs: project_rows now catches SessionEntryUndecided from project_bep_and_grants and renders the [defaults.session] table rows, as before. The test box_spec_bare_reads_defaults_network_bep_undecided_entry pins the preview with two session entries and no default.

With steering = proxy_env under [defaults.network.bep], bare min box spec prints the row 'steering proxy_env', the same value that min box spec default prints. A project with two session entries and no default still gets its bare preview from the [defaults.session] table, and does not get the start's refusal.

Notes from the agent: Revise round 1. When the start cannot pick one session entry (SessionEntryUndecided), bare min box spec now reads the [defaults.session] table rows, as it did before this PR, and does not refuse. A new test pins this and the test line's filter matches it. cargo clippy -p minimal --all-targets is clean. I did not run just clippy-strict.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 06:37
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 1 condition · the full ruling

The main path still reads the expanded session entry, and it conforms. The new fallback for an undecided session entry reads only [defaults.session]. It drops [defaults], and architecture.md line 1223 merges [defaults] into every entry. So with [defaults.network.bep] and two session entries, the bare form prints a steering value that no session gets. Make the change in C1, and add the test it names.

Ruled at 66d7948 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/tests.rs Resolved
@norrietaylor
Copy link
Copy Markdown
Member

/revise Arch C1 and one review finding on 66d7948:

  1. Arch C1 (crates/minimal/src/cmd/box_spec.rs:422): the bare arm reads only [defaults.session], so top-level [defaults] (including [defaults.network.bep]) stays in file.defaults.extra and the rows leave it out. architecture.md line 1223 merges [defaults] into every entry. Read the merge of [defaults] and [defaults.session] here, the way an entry with an empty body expands (line 1229).
  2. Arch C1 test (crates/minimal/src/tests.rs:18285): add a case with [defaults.network.bep] steering = "proxy_env", two session entries and no default; assert the bare output contains steering proxy_env.
  3. MEDIUM (minimal-review): bare min box spec must not newly refuse. Do not route it through pick_session_entry: a project with several session entries and no default, only task entries, or an unresolved Box Type must still print the proxy rows (from the [defaults] + [defaults.session] merge in item 1) and exit 0, not fail with SessionEntryUndecided. Add a test for the several-entries-no-default case (item 2 covers it if it asserts exit 0).

When the start cannot pick one session entry, the bare rows now expand
an entry with an empty body over [defaults] and [defaults.session], so
[defaults.network.bep] reaches the steering row and the command still
succeeds.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as d67665714733.

line exit tail
cargo test -p minimal box_spec_bare_reads_defaults_network_bep 0 cided_entry ... ok test tests::box_spec_bare_reads_defaults_network_bep_top_level_undecided_entry ... ok test tests::box_spec_bare_reads_defaults_network_bep ... ok test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 1030 filtered out; finished in 0.01s running 0 tests test result: ok. 0

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "59c428dea5a4fc10",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "4b4b03a597564c96",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "4b4b03a597564c96",
                "queued_behind": "0",
                "span_id": "4b77076e5fb26956",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "59c428dea5a4fc10",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "b8addb3fc22ac55c",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "b8addb3fc22ac55c",
                "queued_behind": "0",
                "span_id": "a930239911878fb5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "b8addb3fc22ac55c",
                "queued_behind": "0",
                "span_id": "e312829644c7799a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "e312829644c7799a",
                "span_id": "0a03be297e70adcf",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "e312829644c7799a",
                "queued_behind": "0",
                "span_id": "39dbe66bf67bc6f4",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  82.107s] 1203 tests run: 1202 passed, 1 failed, 2 skipped
        FAIL [  12.889s] (1203/1203) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/box_spec.rs: The no-single-entry fallback now expands an empty-body session entry over the merged [defaults] and [defaults.session] (session_defaults_rows), so [defaults.network.bep] reaches the rows.
  • 👍 valid — crates/minimal/src/tests.rs:18286: Added box_spec_bare_reads_defaults_network_bep_top_level_undecided_entry: [defaults.network.bep] steering = proxy_env, two session entries, no default. It asserts success and the steering proxy_env row.

With steering = proxy_env under [defaults.network.bep], bare min box spec prints steering proxy_env, the same value as min box spec dev. This is also true when the project has several session entries and no default: the bare command exits 0 and prints the merged [defaults] and [defaults.session] rows.

Notes from the agent: Revise round 2. The fallback for SessionEntryUndecided (NoDefault, DefaultNotSession, TypeUnresolved) now expands an empty-body session entry over [defaults] and [defaults.session] through mfile::expand, in a new helper session_defaults_rows in box_spec.rs. It does not go through pick_session_entry, so the bare form does not refuse for the pick. A project with only task entries gets the implicit default entry and takes the main path. New test box_spec_bare_reads_defaults_network_bep_top_level_undecided_entry covers [defaults.network.bep] with two session entries and no default, and asserts success. cargo clippy -p minimal --all-targets is clean. just clippy-strict was not run.

@minimal-foundry minimal-foundry Bot added the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Nov 19, 2026
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

The runtime will not revise this pull request again on its own: the diff is +156/-14 (170 lines), past 3x the plan's estimate of 55 lines (est: 25 code, 30 tests, as #3602 reads now), at round 2 (the last trigger was a /revise note). A person decides now. Remove needs-human from this pull request to let /revise <note> or the automatic rounds resume, or finish #3602 by hand.

@norrietaylor
norrietaylor marked this pull request as ready for review November 19, 2026 09:30
@norrietaylor
Copy link
Copy Markdown
Member

Marked ready: the lanes are green at this head. agent-verify exited 100 with the recurring minimald LoggedSpan tail, outside this diff.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

C1 is met. With no single session entry, bare min box spec now expands an empty-body session entry over [defaults] and [defaults.session], as architecture.md lines 1223 and 1224 require. The new test sets [defaults.network.bep] with two session entries and asserts the steering proxy_env row. No condition is open.

Ruled at d676657 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@norrietaylor
norrietaylor marked this pull request as ready for review November 19, 2026 19:38
@norrietaylor
Copy link
Copy Markdown
Member

Marked ready: the round pushed and every lane aggregator is green at 81973d7; the draft came from the round's verify step, not from a failing lane.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

C1 is met. With no single session entry, bare min box spec now reads the egress of the same empty-body session entry that it reads the grants from. The §6.10 admission check therefore sees [defaults.network] and [defaults.session.network] egress. The new test proves that an own_ip preview renders an admitted broker grant and does not refuse. The agent-verify failure is in an unrelated otel trace test, and this ruling does not depend on it.

Ruled at 81973d7 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 3 findings, 3 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/cmd/box_spec.rs Resolved
Comment thread crates/minimal/src/tests.rs Resolved
@norrietaylor
Copy link
Copy Markdown
Member

/revise
Three review findings at 81973d7, all in scope:

  1. LOW, crates/minimal/src/cmd/box_spec.rs project_rows (around line 485): the fallback catches every SessionEntryUndecided, including TypeUnresolved (an entry of a project Box Type) and DefaultNotSession, and builds rows from an invented empty-body session entry. No box starts from that entry in those cases. Narrow the fallback to the case where the project declares no session entry at all; for TypeUnresolved and DefaultNotSession, return the existing error as before. Keep arch condition C1 (the egress comes from the same implicit entry through create::entry_egress). Add a test that a bare min box spec on a project whose default entry is a project Box Type prints the existing refusal, not proxy rows.
  2. NIT, box_spec.rs project_rows (around line 448): from_dir_recursive now parses the project file only for the NotFound message and the invalid-file error. Add a one-line comment saying so.
  3. NIT, crates/minimal/src/tests.rs line 18827: the diff removed the space in the existing comment BCLI-021: `min box spec ` . Restore the original line.

Run cargo test -p minimal box_spec and this PR's test lines.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. The container platform had no instance to give the coder: its pool of prepared containers was full, which happens most just after a deploy. Your note is kept and asked again every 10 minutes for up to 30; a wait that outlives that is refused here with the reason.

What the platform said

could not start the coder: Error: there is no container instance that can be provided to this durable object

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

Several session entries with no default still preview the merged
[defaults] rows. A project Box Type entry or a non-session default
keeps the start's refusal. Restore the BCLI-021 comment spacing.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 7 of 10 on a /revise note, pushed as 87590bd41082.

line exit tail
cargo test -p minimal box_spec_bare_reads_defaults_network_bep 0 est tests::box_spec_bare_reads_defaults_network_bep_undecided_entry_own_ip_egress ... ok test tests::box_spec_bare_reads_defaults_network_bep_undecided_entry ... ok test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 1040 filtered out; finished in 0.02s running 0 tests test result: ok. 0

Verify min task run agent-verify exited 100.

0.010s] (1191/1217) minimal::bin/min tests::invalid_project_file_prints_toml_error_once
        PASS [   0.007s] (1192/1217) minimal::bin/min tests::invalid_project_file_prints_toml_error_once_for_io
        PASS [   0.009s] (1193/1217) minimal::bin/min tests::loadout_not_found_exits_4
        PASS [   0.008s] (1194/1217) minimal::bin/min tests::local_host_not_found_exits_4
        PASS [   0.008s] (1195/1217) minimal::bin/min tests::machine_mode_answers_write_failures
        PASS [   0.008s] (1196/1217) minimal::bin/min tests::machine_mode_error_line_keeps_an_empty_hint
        PASS [   2.061s] (1197/1217) minimal::named_vm egress_opt_out_reaches_autospawned_minvmd
        PASS [   0.006s] (1198/1217) minimal::bin/min tests::machine_mode_error_object_on_stderr
        PASS [   0.007s] (1199/1217) minimal::bin/min tests::machine_mode_error_object_is_one_stamped_line
        PASS [   0.006s] (1200/1217) minimal::bin/min tests::machine_mode_names_the_grant_refusal_code
        PASS [   0.006s] (1201/1217) minimal::bin/min tests::machine_output_mode_keys_on_the_output_flag
        PASS [   0.006s] (1202/1217) minimal::bin/min tests::misplaced_run_flag_exits_2
        PASS [   0.006s] (1203/1217) minimal::bin/min tests::network_flag_refusal_exits_2
        PASS [   0.007s] (1204/1217) minimal::bin/min tests::prune_off_tty_needs_yes_exits_2
        PASS [   0.007s] (1205/1217) minimal::bin/min tests::project_file_not_found_exits_4
        PASS [   0.008s] (1206/1217) minimal::bin/min tests::resume_and_session_attach_refusals_map_to_exit_codes
        PASS [   0.012s] (1207/1217) minimal::bin/min tests::rm_running_box_refuses_naming_force_with_exit_2
        PASS [   0.008s] (1208/1217) minimal::bin/min tests::run_verbs_and_wait_timeout_return_124_with_code_timeout
        PASS [   0.007s] (1209/1217) minimal::bin/min tests::session_policy_json_is_a_stdout_contract
        PASS [   0.007s] (1210/1217) minimal::bin/min tests::session_run_is_a_stdout_contract
        PASS [   0.007s] (1211/1217) minimal::bin/min tests::start_entry_refusals_exit_with_their_codes
        PASS [   0.007s] (1212/1217) minimal::bin/min tests::task_file_invalid_exits_3
        PASS [   0.007s] (1213/1217) minimal::bin/min tests::task_not_found_exits_4
        PASS [   0.007s] (1214/1217) minimal::bin/min tests::task_run_is_a_stdout_contract
        PASS [   0.007s] (1215/1217) minimal::bin/min tests::type_refusals_exit_3_and_4
        PASS [   2.065s] (1216/1217) minimal::named_vm named_vm_reaches_autospawn
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 13.07s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
error: test run failed

Outside the task's layers::

  • crates/minimal/src/cmd/boxes/create.rs

Converted to a draft: verify exited 100; outside the task's layers:: crates/minimal/src/cmd/boxes/create.rs.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/box_spec.rs:491: The fallback in project_rows and in the egress preview now matches only SessionEntryUndecided::NoDefault. TypeUnresolved and DefaultNotSession return the start's refusal. New test box_spec_bare_reads_defaults_network_bep_project_type_refuses covers it.
  • 👍 valid — crates/minimal/src/cmd/box_spec.rs:450: Added a comment above from_dir_recursive: the parse only maps a missing or invalid project file to its message, and the expansion loads the file again.
  • 👍 valid — crates/minimal/src/tests.rs: Restored the space in the BCLI-021 comment, so the line matches main again.

With steering = proxy_env under [defaults.network.bep], bare min box spec prints steering proxy_env, the same value as min box spec default. A project whose default entry has a project Box Type gets the start's refusal from bare min box spec, not proxy rows.

Notes from the agent: The directive says to keep the fallback for a project that declares no session entry at all. In that case pick_session_entry picks the implicit default entry and does not fail. The only remaining SessionEntryUndecided case is NoDefault (several session entries, none named default). So both fallbacks (project_rows and the egress fallback in project_network) now match NoDefault only. Arch condition C1 holds: the egress fallback narrows the same way, so rows and egress come from the same empty-body entry.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 20:29
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 3 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:491, minimal-foundry[bot] crates/minimal/src/cmd/box_spec.rs:450, minimal-foundry[bot] crates/minimal/src/tests.rs. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The new commit limits the bare-form fallback to several session entries with no default. A non-session default entry and a project Box Type entry now get the start's refusal. Line 1229 of architecture.md says a non-session default blocks the implicit session entry. So the bare form now has no implicit entry to preview, and the refusal is correct. The change conforms, and no condition is open.

Ruled at 87590bd against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@norrietaylor
norrietaylor marked this pull request as ready for review November 19, 2026 21:56
@norrietaylor
Copy link
Copy Markdown
Member

Marked ready: round 7 pushed 87590bd and every lane is green; the draft came from the round's verify step.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

Bare min box spec now reads the same expanded session entry that min box start grants from. A [defaults.network.bep] steering mode now reaches its row, as the expansion order in architecture.md line 1250 requires. With several session entries and no default, the preview expands an entry with an empty body through the same box_entry and entry_egress helpers, and the other undecided cases still refuse. The code stays in the minimal CLI crate and reuses the start's expansion. No condition is open.

Ruled at 87590bd against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@norrietaylor
Copy link
Copy Markdown
Member

/review

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 87590bd41082 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 19, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 19, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate passed at 87590bd: minimal-review approved, arch PASS, lanes green, no open threads.

Merged via the queue into main with commit 17c34e8 Nov 19, 2026
40 checks passed
@mitodrummer
mitodrummer deleted the agent/3602-bare-min-box-spec-prints-the-proxy-rows-of-the-e branch November 19, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3598 — Bare min box spec prints the proxy rows of the expanded session entry, so [defaults.network.bep] sets its steering row

2 participants

0