8000 crates/common: fix error checking in Gcs fetcher impl, check request error in CachingDownloader by twitchyliquid64 · Pull Request #86 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

crates/common: fix error checking in Gcs fetcher impl, check request error in CachingDownloader - #86

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/fix
Apr 1, 2026
Merged

crates/common: fix error checking in Gcs fetcher impl, check request error in CachingDownloader#86
twitchyliquid64 merged 1 commit into
mainfrom
tom/fix

Conversation

@twitchyliquid64
@twitchyliquid64 twitchyliquid64 commented Apr 1, 2026
Copy link
Copy Markdown
Contributor

Fixes a panic when trying to populate an entry in CachingDownloader (i.e. source fetch) where the FetchBackend returns a non-200 code, e.g.

called `Result::unwrap()` on an `Err` value: Error { kind: Transport(TransportDetails { status_code: Some(404), headers: Some({"content-type": "text/html; charset=UTF-8", "x-guploader-uploadid": "<redacted>", "date": "Wed, 01 Apr 2026 <redacted>", "vary": "Origin", "vary": "X-Origin", "cache-control": "private, max-age=0", "content-length": "76", "server": "UploadServer", payload: Some(b"No such object: minimal-staging-archives/clang-tools-extra-21.1.8.src.tar.xz") }), source: None }

@twitchyliquid64
twitchyliquid64 requested a review from msample April 1, 2026 04:33
msample
msample approved these changes Apr 1, 2026
View reviewed changes
@msample msample left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 merged commit 46d17e5 into main Apr 1, 2026
6 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/fix branch April 1, 2026 04:38
@bryan-minimal bryan-minimal mentioned this pull request Jul 30, 2026
Closed
This was referenced Sep 23, 2026
Closed
Merged
@bryan-minimal bryan-minimal mentioned this pull request Oct 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msample msample msample approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @msample
0