8000 test: T56 — Move scripts/session-e2e.sh off the old session verbs by minimal-foundry[bot] · Pull Request #3630 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

test: T56 — Move scripts/session-e2e.sh off the old session verbs - #3630

Merged
agent-137 merged 17 commits into
mainfrom
agent/3525-move-scripts-session-e2e-sh-off-the-old-session
Nov 19, 2026
Merged

agent-137 merged 17 commits into
mainfrom
agent/3525-move-scripts-session-e2e-sh-off-the-old-session

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

T56 — Move scripts/session-e2e.sh off the old session verbs

slice: S8
kind: task
covers: BCLI-042
size: L
est: 1000 code, 40 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none new
observability: none new
layers:
- migration:
- scripts/session-e2e.sh: moves off min session activate|destroy|exec|rename|hooks|run, min task run --path and bare min stop, onto the box verbs and the type nouns; drops each in-session session run step with a comment linking #3216; adds the stop-while-attached step for T57 (#3526), as the case attach_ends_on_stop
- crates/minimal/src/tests.rs: adds scripts_and_cli_reference_use_no_removed_session_verb, which reads the four scripts and docs/reference/cli*.md and fails on any removed spelling (min session activate|destroy|exec|rename|policy|hooks|run, min task run --path, bare min stop)
test: cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb
produces 8000 : none
consumes: none
proof: No script or CLI reference page uses a removed spelling, and just e2e passes on the box verbs.
depends on:
- blocked by #3217
- blocked by #3524
- blocked by #3526
- blocked by #3547

Proof

A person can run the new test. It passes on this branch, so the four scripts and every docs/reference/cli*.md page use none of the removed spellings. The one exception is the NET-058 policy steps, which carry an explicit marker. scripts/session-e2e.sh now drives min session start --detach, min box exec, min box rm --force, min box rename, min box spec and min host stop. It has a new attach_ends_on_stop_and_restart case for #3526 and #3547. just e2e was NOT run: this box has no /dev/kvm. So the second half of the proof (just e2e passes on the box verbs) is still owed by the KVM or macOS lane.

just e2e at head 563231d2, passed on all three lanes:

Notes from the agent (from the first round, before CI ran just e2e): 1. just e2e was not run, because this box has no /dev/kvm. I ran single cases of the native lane (env -u E2E_VM ./scripts/session-e2e.sh <case>). lifecycle and session_rename passed. session_exec, box_exec, attach_ends_on_stop_and_restart, task_run and hooks failed on this box because no box can start a process here: 'Minimal cannot read the box's process namespace'. The unchanged script fails session_exec the same way here. restart failed only at its on_destroy hook-output check, and the unchanged script fails that same check here. In the new script, min host stop, the min box spec listing of on_destroy and min box rm --force all passed before that check. Treat the e2e evidence as owed by the KVM and macOS lanes.
2. Conflict in the task: the test must fail on min session policy, but the spec keeps NET-058's two policy steps on that verb until #3589 (T60). Those five lines carry the comment # removed-verb-ok: gominimal/minimal#3589. The test allows session policy only on a line with that marker. T31 or T60 must remove the marker when it moves the steps.
3. Mapping choices: session activate . became session start --detach (the start runs from the project dir). --no-prompt became the global --no-input, which the activation path reads the same way. A one-word session exec <box> '<cmd>' became `box exec <box…[truncated]

Tests

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "219938879ad1bedc",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "04a2a3db4c3c8e79",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "04a2a3db4c3c8e79",
                "queued_behind": "0",
                "span_id": "129c5900e8aa98fb",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "219938879ad1bedc",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "94df96097dd0bfa7",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "94df96097dd0bfa7",
                "queued_behind": "0",
                "span_id": "455bf3c5def867d3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "94df96097dd0bfa7",
                "queued_behind": "0",
                "span_id": "4fc3d9c70a67f449",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "4fc3d9c70a67f449",
                "span_id": "6644b26d38e3a3d0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "4fc3d9c70a67f449",
                "queued_behind": "0",
                "span_id": "b6d65fc254c5f999",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  85.616s] 1202 tests run: 1201 passed, 1 failed, 2 skipped
        FAIL [  12.953s] (1202/1202) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Residuals

  • The restart-while-attached step is not in this PR. On a VM host the attach reads the box between the restart's stop and its start, so the line says "was stopped". T62 (#3635) fixes that and adds the step. Until then, just e2e does not cover restart-while-attached.
  • attach_end_start has no python3 guard, and its failure paths leave the box running: gominimal/inbox#1290.

Closes #3525

The session e2e now starts boxes with min session start --detach, runs
commands with min box exec, removes boxes with min box rm --force,
renames with min box rename, lists stored hooks with min box spec and
stops the daemon with min host stop <host>. A one-word exec command
runs under bash -c, as the old session exec ran it.

The steps that ran a task inside a running session are gone, with a
comment that links #3216. The own-IP box stays as the
egress control of the task runs. The two NET-058 steps stay on
min session policy until #3589, with a marker.

A new case, attach_ends_on_stop_and_restart, proves that min box stop
and min box restart end an attach with exit 254 and a line that names
the cause, and never the shell-exit prompt (#3526, #3547).
scripts_and_cli_reference_use_no_removed_session_verb reads the session
e2e, the three smaller scripts and docs/reference/cli*.md. It fails on
min session activate, destroy, exec, rename, policy, hooks and run, on
min task run --path and on a bare min stop (BCLI-042).

A line with the removed-verb-ok marker for #3589 can
keep min session policy, for NET-058's two steps. The e2e's last three
prose spellings move to the new verbs.
@coderabbitai
coderabbitai Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8532355a-1c7d-41dd-b30d-c297416ec958

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 9 threads unresolved at ec94905ede98.

APPROVE withheld: 9 unresolved threads — minimal-foundry[bot] scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh:7147, minimal-foundry[bot] scripts/session-e2e.sh:2313, …. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh Resolved
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The script moves onto the verbs that the design's command tree lists, and the new test guards the removed spellings. The NET-058 marker and the dropped session run step follow spec 28, and each links its issue. The new attach case checks exit 254 and one notice line, as architecture.md line 492 says. The e2e did not run at this head, so that leg is open. C1 asks for a green scripts/session-e2e.sh run on the KVM and macOS lanes, with the links in the PR body.

Outside the diff

  • scripts/session-e2e.sh:2283: C1 · This case proves architecture.md line 492: exit 254 after one notice line. Nobody ran it at this head. Run it on the KVM and macOS lanes, and put the run links in the PR body. If it fails, fix the step and keep the exit-254 and no-prompt checks.

Ruled at 82512c2 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

The attach can read the box between the restart's stop and its start, and
then its line says stopped. The step now retries up to three times and fails
when no try prints the restart line, so a restart that always says stopped
no longer passes.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as adcff1471199.

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot)

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "9be0b86564412851",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "297f3bf90f2bb7b5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "297f3bf90f2bb7b5",
                "queued_behind": "0",
                "span_id": "3482372e2bd87a91",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "9be0b86564412851",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "3217d68b920a64e2",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "3217d68b920a64e2",
                "queued_behind": "0",
                "span_id": "822f77adbaca2647",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "3217d68b920a64e2",
                "queued_behind": "0",
                "span_id": "184f26525b4c8e1a",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "184f26525b4c8e1a",
                "span_id": "de54c45292b7d0c7",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "184f26525b4c8e1a",
                "queued_behind": "0",
                "span_id": "f6e5dc309c83a8e9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  83.216s] 1202 tests run: 1201 passed, 1 failed, 2 skipped
        FAIL [  12.839s] (1202/1202) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — scripts/session-e2e.sh< 8000 /code>: The restart step now retries up to three times when the line says stopped. It fails when no try prints the restart line, so a restart that always says stopped no longer passes.

No script or CLI reference page uses a removed session spelling, and the test scripts_and_cli_reference_use_no_removed_session_verb fails on any of them. scripts/session-e2e.sh drives the box verbs, and its restart-while-attached step now fails unless the attach prints the line that names the restart.

Notes from the agent: This round changes only the restart step in scripts/session-e2e.sh. The step retries up to three times, because the code prints 'was stopped' when its read lands between the restart's stop and start (attach_ending in crates/minimal/src/cmd/boxes/attach.rs). Before each try, the step removes the /home/ae-restart-live marker, so a kept /home does not make the next attach look ready too early. I did not run just e2e. This box has no KVM, so the e2e proof is still owed by the ci-linux-kvm and ci-macos lanes. I checked the script with bash -n only. shellcheck is not installed here.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 05:30
@agent-137
agent-137 marked this pull request as ready for review November 19, 2026 05:31
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The new restart loop is stricter than before. Each try still checks exit 254 and no prompt (architecture.md line 492), so the gate holds. C1 is still open. The PR body says that just e2e was not run, and it gives no lane run. Run the e2e on the KVM lane and the macOS lane at this head, and put the two run links under ## Proof.

Outside the diff

  • scripts/session-e2e.sh:2301: C1 · This loop keeps the exit-254 check of architecture.md line 492, and it fails when no try shows the restart line. No VM run proves it yet. Run attach_ends_on_stop_and_restart and the other cases on the KVM lane and the macOS lane at this head. Put the run links in the PR body.

Ruled at adcff14 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] scripts/session-e2e.sh. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@agent-137
Copy link
Copy Markdown
Member

/revise

Head adcff147. One fix, in the attach-end proof. Change nothing else.

The restart step restarts a box that cannot be restarted. native-daemon-e2e fails at:

'min box restart e2e-attach-end' failed while a terminal was attached
error: The spec of e2e-attach-end does not set lifetime = "until_stopped", so min box restart cannot restart it. Run it again with min box run <entry>.

The step starts the project's default session entry (mnl session start --detach --name "$ae_name", scripts/session-e2e.sh about line 2287). The shipped session type gives lifetime = "until_complete" (spec 29), so the refusal is correct (BOX-176's sub-requirement). Give the proof a restartable box:

  • Declare an entry for it in the e2e project's minimal.toml, for example [sessions.attach-end] with lifetime = "until_stopped", and start that entry: mnl session start attach-end --detach --name "$ae_name".
  • Use the same box for the stop half and the restart half, as now.
  • Keep the asserted lines exactly: Detached: $ae_name was stopped. for the stop, and Detached: $ae_name was restarted. Run min box attach $ae_name to attach again. for the restart.
  • Keep the retry on a "was stopped" line for the restart window (gominimal/inbox#1277).

The tests failure on this head is minvmd cmd::run::tests::concurrent_boots_never_draw_the_same_proxy_port, a flake outside this diff. Don't touch it.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #3525. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

min box restart refuses a box whose spec does not set
lifetime = "until_stopped". The attach-end proof started its box from
the shared seed's implicit default entry, which sets none, so the
native e2e failed at the restart. The proof now seeds its own project
with a default session entry that sets the lifetime.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a failed check suite, pushed as ebb8290f5e9b.

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot)

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "37c3f2a95c5ceead",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "ed6d7dd8f0b29aa5",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "ed6d7dd8f0b29aa5",
                "queued_behind": "0",
                "span_id": "454f1cf95068db82",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "37c3f2a95c5ceead",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "8c047cda2f211dbd",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "8c047cda2f211dbd",
                "queued_behind": "0",
                "span_id": "2f9dc0ec5d46a564",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "8c047cda2f211dbd",
                "queued_behind": "0",
                "span_id": "5b6c7a730713f440",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "5b6c7a730713f440",
                "span_id": "0835e7974ea716b6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "5b6c7a730713f440",
                "queued_behind": "0",
                "span_id": "b9191cc54a98cfb0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  83.938s] 1202 tests run: 1201 passed, 1 failed, 2 skipped
        FAIL [  12.925s] (1202/1202) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

No script or CLI reference page uses a removed session spelling, and the test scripts_and_cli_reference_use_no_removed_session_verb enforces this. The attach-end step of scripts/session-e2e.sh now starts its box from an entry that sets lifetime = "until_stopped", so min box restart can restart it and the step can run on the box verbs.

Notes from the agent: Revise round 2. The native-daemon-e2e failure was real: the attach-end proof started e2e-attach-end from the shared seed's implicit default entry, which sets no lifetime, so min box restart refused it with exit 2. The proof now seeds its own project (AE_SEED_DIR, removed at the end of the proof and on teardown) with [sessions.default.box] lifetime = "until_stopped". The implicit default entry has an empty body, so the only difference from before is the lifetime. I did not run just e2e on this box, so the e2e lane must confirm the fix. The 'tests' job excerpt in the directive shows only PASS lines and no failed test, so I found no cause to fix there. It can be a follow-on failure or an unrelated one. The ci-linux-native-success aggregator fails because its jobs fail. bash -n and shellcheck show no new findings in the changed region.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 06:00
@agent-137
agent-137 marked this pull request as ready for review November 19, 2026 06:01
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The new commit fixes the restart step's setup. It seeds a default session entry with lifetime = "until_stopped", and the design says restart follows that attribute (architecture.md line 338). The assertions did not change. The e2e leg is still not run on this head, because the PR body says just e2e was NOT run. C1 stays open. Run the e2e on the KVM and macOS lanes at this head, and link both runs under ## Proof.

Outside the diff

  • scripts/session-e2e.sh:2295: C1 · This seed is correct. min box restart needs lifetime = "until_stopped" (architecture.md line 338). C1 is still open: no KVM or macOS lane run at this head shows that the attach_ends_on_stop_and_restart case passes. Run both lanes and link the runs under ## Proof.

Ruled at ebb8290 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/tests.rs Resolved
The e2e seed now declares [sessions.attach-end] with
lifetime = "until_stopped", and the attach-end proof starts that entry
in the shared project, so min box restart can restart its box. This
replaces the separate seed from the previous round.

The seed also declares an empty [sessions.default]. Without it, a start
that names no entry picks the only declared session entry, and every
other box in the script would get the until_stopped lifetime.
@agent-137
Copy link
Copy Markdown
Member

/revise

Head ebb8290f. One change in the attach-end proof. Change nothing else.

Drop the restart half of the attach-end proof. test-kvm fails it in 3 tries out of 3. On a VM host the client reads the box between the restart's stop and its start, so the line says "was stopped". That is a product bug, now T62 (#3635), and it is not this task's to fix.

  • In scripts/session-e2e.sh, keep the stop half of the attach-end proof as it is: Detached: $ae_name was stopped. and exit 254.
  • Remove the restart half and its retry loop. Leave a one-line comment that T62 (T62 — A restart ends an attach with the restart line on every host #3635) adds the restart step.
  • Keep the attach-end seed with lifetime = "until_stopped" only if the stop half needs it. Otherwise remove it, because T62 adds it back.

PR body. Under Residuals, add: the restart-while-attached step is in T62 (#3635), which fixes the restart line on VM hosts.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #3525. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note, pushed as cb1c5150d25d.

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot)

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "b45679aae2537ee8",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "2c3b4fa86b302504",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "2c3b4fa86b302504",
                "queued_behind": "0",
                "span_id": "3d14fa06d2afa381",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "b45679aae2537ee8",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "41e51eba7b5d3e33",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "41e51eba7b5d3e33",
                "queued_behind": "0",
                "span_id": "7175c13d3dd6a4c6",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "41e51eba7b5d3e33",
                "queued_behind": "0",
                "span_id": "e646c2ebd88d819d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "e646c2ebd88d819d",
                "span_id": "7678ee87eff13ba7",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "e646c2ebd88d819d",
                "queued_behind": "0",
                "span_id": "fd5a3e277f4150b7",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  84.130s] 1202 tests run: 1201 passed, 1 failed, 2 skipped
        FAIL [  12.875s] (1202/1202) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Converted to a draft: something above needs a person before review.

No script or CLI reference page uses a removed spelling (the test passes). The attach-end proof in scripts/session-e2e.sh now starts a box from the seed's [sessions.attach-end] entry, which sets lifetime = "until_stopped", so min box restart can restart it. The proof uses the same box for the stop half and the restart half. It asserts the same two Detached lines and keeps the retry on a 'was stopped' line.

Notes from the agent: Revise round 3. The branch head (ebb8290) already had a round-2 fix: a separate seed with [sessions.default.box] lifetime = "until_stopped". This round replaces it with the note's design. The shared seed now declares [sessions.attach-end] with lifetime = "until_stopped", and the proof runs mnl session start attach-end --detach --name "$ae_name" in $PROJECT_DIR. The separate seed (AE_SEED_DIR and its teardown) is gone. Deviation from the note: the seed also declares an empty [sessions.default]. A declared session entry blocks the implicit default (mfile::entry::implicit_default_entry), and pick_session_entry picks the only declared session entry when the start names no entry. Without the empty default, every other nameless mnl session start in the script would get until_stopped. An explicit empty default has the same empty body as the implicit one. Only provenance labels and a log field read the implicit flag, and the script asserts none of them. Limit: a caller-provided E2E_PROJECT_DIR that already has its own minimal.toml is not seeded, so it will not have the attach-end entry. No lane in the justfile does this. I did not run just e2e on this box (no KVM or VM lane here), so the native-daemon-e2e lane must confirm the restart half. bash -n and shellcheck -S warning pass on the script.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 06:20
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 2 findings, 2 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh
Comment on lines +2284 to 2330
proof_attach_ends_on_stop() {
# The proof starts a box from the project that this script seeds. A
# project that E2E_PROJECT_DIR names and that brings its own minimal.toml
# can declare entries that the start cannot pick, so skip it there.
if [ -z "$SEED_DIR" ] && [ -z "$SEEDED_MFILE" ]; then
echo "::notice::attach-end proof skipped: $PROJECT_DIR has its own minimal.toml, and this proof runs only in a project that the script seeds"
return 0
fi
echo "::group::attach-end proof (min box stop ends an attach)"
ae_name="e2e-attach-end"
# shellcheck disable=SC2086
out="$(cd "$PROJECT_DIR" && mnl session start --detach --name "$ae_name" ${E2E_ACTIVATE_ARGS:-} 2>"$WORK/ae-start.err")" || {
echo "::error::'min session start --detach --name $ae_name' failed for the attach-end proof"
echo "--- stderr ---"; cat "$WORK/ae-start.err" 2>/dev/null || true
fail
}
ae_sid="$(printf '%s\n' "$out" | tail -n1 | tr -d '\r')"

# T62 (gominimal/minimal#3635) adds the restart-while-attached step.

# T57: a stop ends the attach with exit 254 and one line that names the stop.
attach_end_start stop "$ae_name"
mnl box stop "$ae_name" </dev/null >"$WORK/ae-stop-cmd.out" 2>&1 || {
echo "::error::'min box stop $ae_name' failed while a terminal was attached"
cat "$WORK/ae-stop-cmd.out" 2>/dev/null || true
kill "$AE_PID" 2>/dev/null || true
fail
}
attach_end_wait stop "$ae_name"
ae_lines="$(grep -cF "Detached: $ae_name was stopped." "$WORK/ae-stop.out" || true)"
if [ "$ae_lines" != 1 ]; then
echo "::error::the attach that the stop ended printed 'Detached: $ae_name was stopped.' $ae_lines times (expected once)"
echo "--- transcript ---"; cat "$WORK/ae-stop.out" 2>/dev/null || true
fail
fi
echo "stop while attached: exit 254, one line that names the stop"

mnl box rm --force "$ae_sid" </dev/null >/dev/null 2>&1 || true
echo "attach-end proof OK"
echo "::endgroup::"
}

# ---------------------------------------------------------------------------
# Session rename proof: `min box rename` against the live shared session.
# The new name shows up in `ls --json`, the old name stops resolving, and
# rename-to-self is an error rather than a silent no-op. The original name is
# restored afterwards: the sandbox proof asserts the orientation banner
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.60 · in proof_attach_ends_on_stop

The PR body says the script adds both the stop-while-attached and the restart-while-attached steps (T58, #3547). The diff has only the stop step. A comment defers the restart step to T62 (#3635). The case name attach_ends_on_stop also differs from the attach_ends_on_stop_and_restart that the PR body names. The restart coverage that the task promises is missing, so fix the PR description or add the step.

What the reviewer checked

T62 (#3635) adds the restart-while-attached step.

Hand this to an agent
Act on a code-review finding.

File:       scripts/session-e2e.sh
Lines:      2284-2330
Category:   correctness
Severity:   low (reviewer confidence 0.60)

Finding:
The PR body says the script adds both the stop-while-attached and the restart-while-attached steps (T58, #3547). The diff has only the stop step. A comment defers the restart step to T62 (#3635). The case name `attach_ends_on_stop` also differs from the `attach_ends_on_stop_and_restart` that the PR body names. The restart coverage that the task promises is missing, so fix the PR description or add the step.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the PR body. It now says the script adds only the stop-while-attached step, as attach_ends_on_stop. Its Residuals section says restart-while-attached is not covered until T62 (#3635), which fixes the restart line on VM hosts and adds the step.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ec94905ede98: The restart step is still not in the script. The PR body now names only attach_ends_on_stop and lists restart-while-attached as a residual that T62 (#3635) closes. No code change this round.

Comment thread scripts/session-e2e.sh
Comment on lines +2244 to +2262
attach_end_start() {
local ae_live=""
# shellcheck disable=SC2086 # E2E_MINIMAL_ARGS must word-split.
E2E_PTY_COMMANDS="touch /home/ae-$1-live; sleep 600" E2E_PTY_EXPECT_EXIT=254 \
python3 "$ROOT/scripts/e2e-attach-pty.py" - min ${E2E_MINIMAL_ARGS:-} box attach "$2" \
>"$WORK/ae-$1.out" 2>"$WORK/ae-$1.err" &
AE_PID=$!
for _ in $(seq 1 120); do
if mnl box exec "$2" -- test -e "/home/ae-$1-live" </dev/null >/dev/null 2>&1; then
ae_live=1
break
fi
sleep 0.25
done
if [ -z "$ae_live" ]; then
kill "$AE_PID" 2>/dev/null || true
wait "$AE_PID" 2>/dev/null || true
echo "::error::the pty attach to $2 never reached its shell ($1 step)"
cat "$WORK/ae-$1.out" "$WORK/ae-$1.err" 2>/dev/null || true
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.50 · in attach_end_start

attach_end_start runs python3 with no command -v python3 guard. The sibling box_exec step guards it and calls not_run. Without python3 this proof waits 30 s and fails with 'never reached its shell', which hides the real cause. Also, the failure paths after session start (stop failure, wait failure, wrong line count) call fail without min box rm --force "$ae_sid". The e2e-attach-end box stays behind and a later run can hit the name.

What the reviewer checked

attach_end_start: python3 "$ROOT/scripts/e2e-attach-pty.py" - min ... box attach "$2" (no guard); box rm --force only on the success path

Hand this to an agent
Act on a code-review finding.

File:       scripts/session-e2e.sh
Lines:      2244-2262
Category:   correctness
Severity:   low (reviewer confidence 0.50)

Finding:
`attach_end_start` runs python3 with no `command -v python3` guard. The sibling `box_exec` step guards it and calls `not_run`. Without python3 this proof waits 30 s and fails with 'never reached its shell', which hides the real cause. Also, the failure paths after `session start` (stop failure, wait failure, wrong line count) call `fail` without `min box rm --force "$ae_sid"`. The `e2e-attach-end` box stays behind and a later run can hit the name.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred as a low residual: gominimal/inbox#1290, listed under Residuals. T62 (#3635) edits this proof next and picks it up there.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ec94905ede98: The proof now reports NOT RUN when python3 is missing, and each failure after the start calls ae_fail, which removes e2e-attach-end before it fails.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 7 of 10 on a /revise note, pushed as 563231d23cf2.

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling args v0.0.1 (/workbench/crates/args

Verify min task run agent-verify exited 100.

 {
                "parent_span_id": "99eb4330b3135b15",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "180930fd0dc68c20",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "180930fd0dc68c20",
                "queued_behind": "0",
                "span_id": "5c6c9a26e76b4b81",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "99eb4330b3135b15",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "c673b204dde8a652",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "c673b204dde8a652",
                "queued_behind": "0",
                "span_id": "77172ff06bade9d1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "c673b204dde8a652",
                "queued_behind": "0",
                "span_id": "d3989422db89c301",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "d3989422db89c301",
                "span_id": "417c69a30ab9eed9",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "d3989422db89c301",
                "queued_behind": "0",
                "span_id": "dcb1347dea7d769d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  80.067s] 1206 tests run: 1205 passed, 1 failed, 2 skipped
        FAIL [  12.739s] (1206/1206) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Outside the task's layers::

  • justfile

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — PRRT_kwDOPdfcxM65XtIa: min_wrappers_in_script clears the open function at its closing } and matches ${MIN}, with unit cases for each (aad244d). (not posted on the thread: not an open thread on the pull request)
  • 👍 valid — PRRT_kwDOPdfcxM65XtId: --path is checked only inside the command that holds min task run (aad244d). In 563231d the guard reads the justfile and skips its # comments, and justfile:893 now prints min session start --detach --name net1 --network own_ip. (not posted on the thread: not an open thread on the pull request)

1 thread was already answered in earlier rounds, with nothing new on it since.

No script, CLI reference page or justfile line that a person runs uses a removed spelling. The guard now reads the justfile too. The justfile's own-IP demo prints min session start in place of min session activate. This round did not run just e2e.

Notes from the agent: Items 1 and 2 of the note, and the --path separator part of item 3, were already on the branch in aad244d (rename to attach_ends_on_stop, wrapper scope closes at }, ${MIN} matched, unit cases for each, --path read per command). This round adds item 3's rest in 563231d. justfile is outside the task's layers. The /revise note asked for that change, so it is in scope for this round. justfile:893 now prints min --minimal-dir {{native-dir}} session start --detach --name net1 --network own_ip && ... session attach net1. Two differences from the note's text: (1) I dropped the trailing .. SessionStartArgs.entry in crates/minimal/src/cli.rs is an entry name from minimal.toml, not a project path, so . would ask for an entry named .. (2) I used own_ip, because docs/reference/cli-min.md says own-ip is the old spelling and prints a hint. The guard skips # comment lines only in the justfile. Scripts keep their comments checked, so the existing unit case for a commented min session run still holds. I did not run just e2e on this box.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 07:56
@agent-137
agent-137 marked this pull request as ready for review November 19, 2026 07:58
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 2 conditions · the full ruling

The new commit adds the justfile to the removed-verb guard, and moves the just up echo to min session start. That conforms to architecture.md line 173. C1 is still open: the PR body says that just e2e was not run, and no lane run links exist for this head. C2 is still open: the body still claims the restart-while-attached step for #3547, but the script proves only the stop. Edit the PR body as C2 says, and add the KVM and macOS run links for this head as C1 says.

Outside the diff

  • scripts/session-e2e.sh:2284: C1 · This case proves the stop for #3526. Run it on the KVM lane and on the macOS lane at this head. It must pass without the attach-end proof skipped notice. Then put the two run links under ## Proof in the PR body.

Ruled at 563231d against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh
}
ae_sid="$(printf '%s\n' "$out" | tail -n1 | tr -d '\r')"

# T62 (gominimal/minimal#3635) adds the restart-while-attached step.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.60 · in proof_attach_ends_on_stop

The PR says the script adds a restart-while-attached step for T58 (#3547). The new attach_ends_on_stop case only tests stop. The restart step is deferred to T62 (#3635) in a comment. The case name and the PR body claim more than the case checks, so a regression in restart-while-attached passes just e2e. State the gap in the PR, or add the step.

What the reviewer checked

session-e2e.sh:2302 # T62 (#3635) adds the restart-while-attached step.

Hand this to an agent
Act on a code-review finding.

File:       scripts/session-e2e.sh
Lines:      2302-2302
Category:   correctness
Severity:   low (reviewer confidence 0.60)

Finding:
The PR says the script adds a restart-while-attached step for T58 (#3547). The new `attach_ends_on_stop` case only tests stop. The restart step is deferred to T62 (#3635) in a comment. The case name and the PR body claim more than the case checks, so a regression in restart-while-attached passes `just e2e`. State the gap in the PR, or add the step.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the PR body. It now says the script adds only the stop-while-attached step, as attach_ends_on_stop. Its Residuals section says restart-while-attached is not covered until T62 (#3635), which fixes the restart line on VM hosts and adds the step.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ec94905ede98: Same gap as the other restart thread: the PR body states it, and T62 (#3635) adds the restart step. No code change this round.

@agent-137
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change moves the session e2e and the justfile onto the verbs that the design's command tree lists (architecture.md line 410). It replaces bare min stop with min host stop (line 555). The new guard test refuses each removed spelling. Five NET-058 lines keep min session policy behind a marker until #3589 lands. C1 removes those lines and the marker, and can stay open at merge. The dropped session run and changed-files steps are residuals that #3216 and #3638 own.

Outside the diff

  • scripts/session-e2e.sh:32178: C1 · This line and the four other marked lines still call min session policy. Move them to the box verb that #3589 adds, and remove the removed-verb-ok marker.

Ruled at 563231d against gominimal/arch@8b824707cde6 by claude-opus-5-5.

Comment thread crates/minimal/src/tests.rs Outdated
/// The marker that lets one line of `scripts/session-e2e.sh` keep
/// `min session policy`. NET-058's two steps keep the verb until a box verb
/// gives NET-058's refusal for a box on a stopped VM (gominimal/minimal#3589).
const REMOVED_VERB_MARKER: &str = "removed-verb-ok: gominimal/minimal#3589";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · This marker lets five lines keep min session policy, which the command tree (architecture.md line 410) does not list. When #3589 lands, delete this constant and its continue branch. Then the test refuses the verb on every line.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred as a low residual, as the ruling allows: gominimal/inbox#1291. When #3628 (T60, #3589) merges, the five lines move to the box verb, and the removed-verb-ok constant and its continue branch go.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in ec94905ede98: #3589 landed on main and the merge moved both NET-058 steps to min box show --network. REMOVED_VERB_MARKER, its continue branch and its test case are deleted, so the guard refuses min session policy on every line.

@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 19, 2026
…ts-session-e2e-sh-off-the-old-session

# Conflicts:
#	scripts/session-e2e.sh
Main moved the NET-058 steps to min box show --network (#3589), so no
script line needs the removed-verb-ok marker any more. The guard now
refuses min session policy on every line.
The attach-end proof now reports NOT RUN when python3 is missing, in
place of a 30 s wait and a misleading failure. Each failure after the
box starts removes e2e-attach-end, so a later run can reuse the name.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

A merge of main before round 8, not counted against the cap (1 of 3), pushed as ec94905ede98.

Resolved conflicts in: scripts/session-e2e.sh

line exit tail
cargo nextest run -p minimal scripts_and_cli_reference_use_no_removed_session_verb 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot)

Verify min task run agent-verify exited 100.

n tests::init_refusals_exit_with_their_codes
        PASS [   0.009s] (1184/1209) minimal::bin/min tests::invalid_project_file_prints_toml_error_once
        PASS [   0.011s] (1185/1209) minimal::bin/min tests::invalid_project_file_for_box_spec_says_spec_cannot_show
        PASS [   0.013s] (1186/1209) minimal::bin/min tests::invalid_project_file_prints_toml_error_once_for_io
        PASS [   0.009s] (1187/1209) minimal::bin/min tests::local_host_not_found_exits_4
        PASS [   0.009s] (1188/1209) minimal::bin/min tests::loadout_not_found_exits_4
        PASS [   0.012s] (1189/1209) minimal::bin/min tests::machine_mode_answers_write_failures
        PASS [   0.010s] (1190/1209) minimal::bin/min tests::machine_mode_error_object_is_one_stamped_line
        PASS [   0.015s] (1191/1209) minimal::bin/min tests::machine_mode_error_line_keeps_an_empty_hint
        PASS [   0.014s] (1192/1209) minimal::bin/min tests::machine_mode_error_object_on_stderr
        PASS [   0.013s] (1193/1209) minimal::bin/min tests::machine_mode_names_the_grant_refusal_code
        PASS [   0.016s] (1194/1209) minimal::bin/min tests::machine_output_mode_keys_on_the_output_flag
        PASS [   0.014s] (1195/1209) minimal::bin/min tests::misplaced_run_flag_exits_2
        PASS [   0.015s] (1196/1209) minimal::bin/min tests::network_flag_refusal_exits_2
        PASS [   0.012s] (1197/1209) minimal::bin/min tests::project_file_not_found_exits_4
        PASS [   0.010s] (1198/1209) minimal::bin/min tests::prune_off_tty_needs_yes_exits_2
        PASS [   0.014s] (1199/1209) minimal::bin/min tests::resume_and_session_attach_refusals_map_to_exit_codes
        PASS [   0.011s] (1200/1209) minimal::bin/min tests::run_verbs_and_wait_timeout_return_124_with_code_timeout
        PASS [   0.014s] (1201/1209) minimal::bin/min tests::rm_running_box_refuses_naming_force_with_exit_2
        PASS [   0.009s] (1202/1209) minimal::bin/min tests::session_policy_json_is_a_stdout_contract
        PASS [   0.010s] (1203/1209) minimal::bin/min tests::session_run_is_a_stdout_contract
        PASS [   0.012s] (1204/1209) minimal::bin/min tests::start_entry_refusals_exit_with_their_codes
        PASS [   0.009s] (1205/1209) minimal::bin/min tests::task_file_invalid_exits_3
        PASS [   0.010s] (1206/1209) minimal::bin/min tests::task_not_found_exits_4
        PASS [   0.011s] (1207/1209) minimal::bin/min tests::task_run_is_a_stdout_contract
        PASS [   0.012s] (1208/1209) minimal::bin/min tests::type_refusals_exit_3_and_4
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 14.16s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
error: test run failed

Outside the task's layers::

  • justfile

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

No script or CLI reference page uses a removed spelling. The guard test now refuses min session policy on every line, with no marker exemption. The two NET-058 steps in scripts/session-e2e.sh use min box show <box> --network, as main does.

Notes from the agent: Conflict round: both hunks in scripts/session-e2e.sh took main's side. Main moved the NET-058 unknown-box and stopped-VM steps to min box show --network (#3589), so the removed-verb-ok lines went away. The merge commit is 361582a. just e2e was not run on this box (no KVM here), so the e2e half of the proof is not proved by this round. The restart-while-attached step is still not in the script. T62 (#3635) adds it, as the PR body says. bash -n passes on the script. shellcheck reports no warnings on the changed lines.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 19, 2026 16:40
@agent-137
agent-137 marked this pull request as ready for review November 19, 2026 16:41
@agent-137
Copy link
Copy Markdown
Member

Undrafted: round 8's agent-verify failure is exec_run_attach_and_task_run_share_the_commands_trace, the known flake #3483 in the otel_cli test, outside this diff. The merge of main also removed every removed-verb-ok marker, which settles arch C1 (gominimal/inbox#1291).

@agent-137
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

C1 is met. The NET-058 steps in scripts/session-e2e.sh now use min box show --network. The guard test refuses min session policy on every line, and the marker is gone. The command tree in architecture.md (lines 410 and 414) keeps only the box verbs and the session aliases that the script now uses. The restart-while-attached step stays a filed residual on #3635.

Ruled at ec94905 against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 9 unresolved threads — minimal-foundry[bot] scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh, norrietaylor scripts/session-e2e.sh:7147, minimal-foundry[bot] scripts/session-e2e.sh:2313, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 19, 2026
@agent-137
Copy link
Copy Markdown
Member

Re-queued at the same approved head ec94905e. The queue ejected it on one native-daemon-e2e step (run 44597562986): the session activated through --network no-net is not listed (mnl ls --raw did not list the new box). This PR leaves that step unchanged, the step passed on this head's own CI, and #3651's merge group on the same base passed it. If it fails again I'll treat it as real.

Merged via the queue into main with commit 987f89f Nov 19, 2026
39 checks passed
@agent-137
agent-137 deleted the agent/3525-move-scripts-session-e2e-sh-off-the-old-session branch November 19, 2026 20:44
agent-137 pushed a commit that referenced this pull request Nov 19, 2026
Conflict in scripts/session-e2e.sh: main (#3630) replaced the session-run
step that followed this branch's task box-stop proof. Kept the box-stop
proof and took main's replacement step after it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CYvTvep9ZaSf5pJMB2hQA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T56 — Move scripts/session-e2e.sh off the old session verbs

3 participants

0