8000 docs(spec): spec 28 follows spec 29's single env_vars table by agent-137 · Pull Request #3651 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

docs(spec): spec 28 follows spec 29's single env_vars table - #3651

Merged
mitodrummer merged 1 commit into
mainfrom
docs/spec28-env-vars
Nov 19, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
docs/spec28-env-vars

Conversation

@agent-137
@agent-137 agent-137 commented Nov 19, 2026 •
Copy link
Copy Markdown
Member

Closes #3631. Refs #2879, #3632, #3469.

Spec 29's env_vars amendment (#3632, merged) replaced vars and vars_lenient with one env_vars table (BOX-205), retired BOX-184, and added BOX-206 and BOX-207. Spec 28 still named the old keys.

  • BCLI-077 renders an entry's env_vars (BOX-205), in place of vars and vars_lenient and "in the table".
  • BCLI-078 drops BOX-184 from its list and its comment, and adds BOX-206 (a retired key fails with exit 3) and BOX-207 (a variable name that is not POSIX-shaped fails with exit 3), with what each error tells the person, as spec 29 states it.

The verify test names are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_016CYvTyVpjTE7DxZiZ29NeY

Summary by CodeRabbit

  • Documentation
    • Updated CLI specifications to describe displaying merged environment variables, including each variable’s value and the layer that set it.
    • Revised listed expansion failure conditions and their explanations.

BCLI-077 renders an entry's env_vars (BOX-205). BCLI-078 drops the
retired BOX-184 and names BOX-206 and BOX-207 with what each error says.

Closes #3631

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CYvTyVpjTE7DxZiZ29NeY
@agent-137
agent-137 requested a review from a team as a code owner November 19, 2026 18:53
@coderabbitai
coderabbitai Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Spec 28 updates BCLI-077 to specify rendering merged env_vars. BCLI-078 adds BOX-206 and BOX-207 to the listed expansion failures and removes BOX-184.

Changes: Spec 28 environment variable requirements

Layer / File(s) Summary
Update rendering and expansion requirements
docs/specs/28-spec-box-cli/28-spec-box-cli.md
BCLI-077 now specifies rendering each env_vars name once with its merged value and setting layer. BCLI-078 adds BOX-206 and BOX-207 to the listed failures and removes BOX-184. Its comment describes the BOX-206 and BOX-207 errors.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related issues

  • gominimal/minimal#3469 — This PR applies the env_vars and BOX-184 retirement changes to Spec 28, but does not update the other documents in the issue’s scope.
  • gominimal/minimal#2879 — This PR edits the Spec 28 CLI grammar, which the epic identifies as its binding specification.

Possibly related PRs

Suggested reviewers: norrietaylor, bryan-minimal

Merge Risk: Minimal · up to 48f55

This documentation update aligns the box CLI spec with the environment variable amendment. It has no runtime effect, and no merge-readiness risk remains.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #3631 asks for three coding-free text edits in the spec, which are checked as requirements: (1) BCLI-077 (line 208) renders env_vars in place of vars, vars_lenient and "in the table"; (2) … Provide the reviewed content of docs/specs/28-spec-box-cli/28-spec-box-cli.md at lines 200 to 230 (or the full whole-PR diff for that file, with the changed blobs available). Confirm that: BCLI-077 names env_vars and no longer names `vars…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title uses Conventional Commit form (docs(spec): ...) and names the main change: Spec 28 now follows Spec 29's single env_vars table. It matches the changeset, which edits only the Spec 28 documen…
Description check Passed The description follows the template's intent. It has a summary that explains what changes and why, and it links related issues (Closes #3631, Refs #2879, #3632, #3469). It explains the BCLI-077 and B…
Out of Scope Changes check Passed The PR description and the raw summary both show a single changed file, docs/specs/28-spec-box-cli/28-spec-box-cli.md, with +4/-3 lines. The summary describes changes only to BCLI-077 and BCLI-078 and…
Full details: Title check

Explanation

The title uses Conventional Commit form (docs(spec): ...) and names the main change: Spec 28 now follows Spec 29's single env_vars table. It matches the changeset, which edits only the Spec 28 document (BCLI-077 and BCLI-078). The title is specific and in lower case with no trailing period, as the template requires.

Full details: Description check

Explanation

The description follows the template's intent. It has a summary that explains what changes and why, and it links related issues (Closes #3631, Refs #2879, #3632, #3469). It explains the BCLI-077 and BCLI-078 edits in detail. The Testing section is missing. The author only says verify test names are unchanged, and gives no commands run or output. The Checklist is also absent. The Docs-updated item is effectively satisfied by the change itself, and the BREAKING CHANGE footer does not apply to a docs-only change. The description is mostly complete, so the check passes.

Full details: Out of Scope Changes check

Explanation

The PR description and the raw summary both show a single changed file, docs/specs/28-spec-box-cli/28-spec-box-cli.md, with +4/-3 lines. The summary describes changes only to BCLI-077 and BCLI-078 and its comment, which match the linked issue's scope for Spec 28. The summary reports no declaration changes. The PR does not touch Spec 29, the code, or other specs. No unrelated change is shown. Limitation: the file content was only partly readable (see the linkedIssuesAssessment explanation), so the absence of other changed files rests on the summary and PR metadata, not on a full whole-PR diff.

Full details: Linked Issues check

Explanation

Issue #3631 asks for three coding-free text edits in the spec, which are checked as requirements: (1) BCLI-077 (line 208) renders env_vars in place of vars, vars_lenient and "in the table"; (2) BCLI-078 (line 217) drops BOX-184 from its list; (3) BCLI-078 comment (line 224) drops the BOX-184 error line and, if named, adds BOX-206 and BOX-207 with their error contents. The PR description and the AI-generated raw summary both state that these edits were made. The summary reports +4/-3 lines in docs/specs/28-spec-box-cli/28-spec-box-cli.md and describes the BCLI-077 and BCLI-078 changes. However, reading the head blob of that file returned only the first 16000 bytes. The read stopped before line 208, so the exact text of BCLI-077, BCLI-078 and its comment was not read. The whole-PR diff tool failed because the changed blobs are missing from the checkout. The requirement text therefore rests on the PR description and the summary, not on the file content. Individual requirement checks cannot be confirmed from source. No coding requirements exist; the test-name claim (verify lines unchanged) also cannot be confirmed from the truncated read.

Resolution

Provide the reviewed content of docs/specs/28-spec-box-cli/28-spec-box-cli.md at lines 200 to 230 (or the full whole-PR diff for that file, with the changed blobs available). Confirm that: BCLI-077 names env_vars and no longer names vars, vars_lenient or "in the table"; BCLI-078's list and its comment no longer contain BOX-184; BCLI-078 names BOX-206 and BOX-207 with error contents matching spec 29's BOX-206 and BOX-207 text; and the verify lines are unchanged.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Vale (3.24.0)

{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}

A rabbit reads the variables in a row,
Merged values now shape the show.
BOX-206 and BOX-207 join the page,
BOX-184 steps off the stage.
The spec is set; the carrots wait.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 5c631b42-8a0b-4149-8101-b0988d4d1400
Commits

Reviewing files that changed from the base of the PR and between d5bb001 and 48f55ec.

Files selected for processing: 1

  • docs/specs/28-spec-box-cli/28-spec-box-cli.md

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

@github-actions
Copy link
Copy Markdown
Contributor

Spec lint

docs/specs/28-spec-box-cli/28-spec-box-cli.md — 11 finding(s)

docs/specs/28-spec-box-cli/28-spec-box-cli.md:211: P004 BCLI-077 names test 'box_spec_renders_merged_vars_once_with_layer', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:227: P004 BCLI-078 names test 'expansion_refusals_exit3_on_spec_and_create_verbs', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:300: P004 BCLI-075 names test 'create_verbs_no_loadouts_empties_loadouts_layer', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:313: P004 BCLI-076 names test 'create_verbs_no_hooks_stores_no_hooks', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:329: P004 BCLI-026 names test 'box_verbs_exist_with_arch_flags', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:337: P004 BCLI-028 names test 'help_and_completions_from_one_model', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:424: P004 BCLI-034 names test 'exit_code_table', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:540: P004 BCLI-042 names test 'removed_session_verbs_fail_as_unknown_commands', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:544: P004 BCLI-043 names test 'setup_zed_unchanged', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:549: P004 BCLI-044 names test 'cli_reference_documents_box_grammar', which was not found in the repository
docs/specs/28-spec-box-cli/28-spec-box-cli.md:573: P004 BCLI-049 names test 'host_stop_stops_boxes_then_daemon_and_vm', which was not found in the repository

Advisory. None of this blocks the merge; the review decides.

Advisory, and never a merge gate. Linter: gominimal/foundry@8acb0663, spec format: How Minimal Writes Specs.

@minimal-foundry
minimal-foundry Bot commented Nov 19, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 48f55ec4e9ff.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 19, 2026
@agent-137
Copy link
Copy Markdown
Member Author

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Spec 28 now names the one env_vars table that architecture.md line 1253 gives at every layer. BCLI-078 drops retired BOX-184 and adds BOX-206 and BOX-207 with exit 3. Their error content matches spec 29 at this head. No condition is open.

Ruled at 48f55ec against gominimal/arch@8b824707cde6 by claude-opus-5-5.

8000

@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 084dcf6 Nov 19, 2026
42 checks passed
@mitodrummer
mitodrummer deleted the docs/spec28-env-vars branch November 19, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spec 28: BCLI-077 and BCLI-078 follow spec 29's single env_vars table (BOX-184 retired, BOX-206, BOX-207)

2 participants

0