Repository navigation
fix(installer): the pinned install card says which releases report - #3541
Conversation
For a --version install the card said min reports the install once a day. A pinned release older than 0.7.4 has no update check and sends nothing, so the card described a request that is never made. The line now reads "min 0.7.4 and later report this install once a day". Refs #3504 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Reviewed: no findings; approval withheld, 2 threads unresolved at APPROVE withheld: 2 unresolved threads — norrietaylor scripts/install.sh, norrietaylor scripts/install.sh:1800. Resolving the last thread releases the approval on this head. Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required. Clobber: none seen. |
There was a problem hiding this comment.
This one-line wording fix is correct. v0.7.3 has no update-check code, while release/0.7.x (the line that becomes 0.7.4) has the update_check module, so "min 0.7.4 and later report this install" accurately describes pinned installs. The comment above the card matches, and the existing installer assertion at install_test.sh:1533 still holds. I left two non-blocking notes: the card could use the known $VERSION instead of a range, and no test pins the new qualifier.
Generated by Claude Code
| # check and sends nothing, so the pinned line says which releases report. | ||
| if [ "$version_set" -eq 1 ]; then | ||
| say " ${dim}min reports this install once a day (no release notices for --version), sending its channel$rst" | ||
| say " ${dim}min 0.7.4 and later report this install once a day (no release notices for --version), sending the channel$rst" |
There was a problem hiding this comment.
Low (non-blocking): the card already knows the pinned release ($VERSION, set from --version at line 1016 and printed in "Minimal $VERSION is ready."). AGENTS.md says to fill in a value when the message knows it. As written, --version 0.7.2 reads "min 0.7.4 and later report this install once a day", and the user still has to work out whether that applies to them. A cheap fix is to branch on $VERSION: print the current line for 0.7.4 and later (or a nightly sha), and for an older release state that this release sends no update check. If a version comparison in sh isn't worth it here, the current wording is accurate. I checked that v0.7.3 has no update_check module and release/0.7.x has one.
Generated by Claude Code
There was a problem hiding this comment.
Done in 3382d0b. The card now uses the version it knows: a release from 0.7.4 on reads "min reports this install once a day (no release notices for --version)…", and one before it reads "min 0.7.3 does not check for updates and sends nothing. Releases from 0.7.4 on report an install once a day." with no off switch shown, since there is no request to switch off. The comparison is plain sh on X.Y.Z. A version it cannot place (a pre-release, a nightly, a name that is not X.Y.Z) keeps the range wording, because a pre-release of 0.7.4 may or may not have the check.
| # channel pointer applies to it. | ||
| # channel pointer applies to it. A pinned release older than 0.7.4 has no | ||
| # check and sends nothing, so the pinned line says which releases report. | ||
| if [ "$version_set" -eq 1 ]; then |
There was a problem hiding this comment.
Low (non-blocking): no test pins the new wording. The only check on this line is scripts/install_test.sh:1533, which greps for no release notices for --version. That text is unchanged, so the test would still pass if the "0.7.4 and later" qualifier were dropped again. AGENTS.md ("User-facing text") asks for the exact text to be pinned in the test that checks it. Suggest adding grep -q "min 0.7.4 and later report this install" next to that assertion.
Generated by Claude Code
There was a problem hiding this comment.
Done in 3382d0b. The installer test now pins all three texts: the range (for the test's v1), the before-0.7.4 text for --version 0.7.3 (and that the off switch is not printed there), and the definite text for --version 0.7.4. It passes under sh, bash and dash.
The card knows the pinned version, so it no longer leaves the reader to work out whether "0.7.4 and later" applies to them. A release from 0.7.4 on is told that min reports the install once a day. A release before 0.7.4 is told that it does not check for updates and sends nothing, and is not shown the off switch for a request it never makes. A version the card cannot place (a pre-release, a nightly, a name that is not X.Y.Z) keeps the range. The installer test pins all three texts, the range one included, which no test checked before. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
What
For a
--versioninstall, the card's line about reporting now reads "min 0.7.4 and later report this install once a day".Refs #3504 (a review note there).
Why
The card said min reports the install once a day. A pinned release older than 0.7.4 has no update check and sends nothing. For those installs the card described a request that is never made.
Scope
One line of
scripts/install.sh. The same change goes torelease/0.7.xas its own PR, so the installer that ships with 0.7.4 says the same.Testing
The installer tests pass under sh, bash and dash. Workspace lint, tests and the native end-to-end script pass on this commit.
🤖 Generated with Claude Code
Summary by CodeRabbit