8000 fix(installer): the pinned install card says which releases report by bryan-minimal · Pull Request #3541 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(installer): the pinned install card says which releases report - #3541

Merged
bryan-minimal merged 2 commits into
mainfrom
fix/install-card-pinned-wording
Nov 19, 2026
Merged

bryan-minimal merged 2 commits into
mainfrom
fix/install-card-pinned-wording

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Nov 18, 2026 •
Copy link
Copy Markdown
Member

What

For a --version install, the card's line about reporting now reads "min 0.7.4 and later report this install once a day".

Refs #3504 (a review note there).

Why

The card said min reports the install once a day. A pinned release older than 0.7.4 has no update check and sends nothing. For those installs the card described a request that is never made.

Scope

One line of scripts/install.sh. The same change goes to release/0.7.x as its own PR, so the installer that ships with 0.7.4 says the same.

Testing

The installer tests pass under sh, bash and dash. Workspace lint, tests and the native end-to-end script pass on this commit.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Installer telemetry notices now vary by pinned version. Versions before 0.7.4 are identified as sending no checks or data; version 0.7.4 and later are shown with the applicable update-check disclosure and opt-out option.
    • When a pinned version cannot be classified, the installer retains a general notice for 0.7.4 and later. Channel-install notices remain unchanged.

For a --version install the card said min reports the install once a day.
A pinned release older than 0.7.4 has no update check and sends nothing, so
the card described a request that is never made. The line now reads
"min 0.7.4 and later report this install once a day".

Refs #3504

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 17:05
@coderabbitai
coderabbitai Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The installer now distinguishes pinned releases before version 0.7.4 from later releases when displaying its telemetry disclosure. It also retains a general disclosure for versions it cannot classify. Installer tests cover releases on both sides of the threshold and an unclassified release.

Changes: Pinned-version telemetry disclosure

Layer / File(s) Summary
Classify pins and verify disclosures
scripts/install.sh, scripts/install_test.sh
The closing card classifies three-part numeric pinned versions, with an optional v prefix, against the 0.7.4 threshold. Earlier versions receive a no-update-check/no-data disclosure. Later versions receive the pinned-install disclosure and opt-out switch. Unclassified pins retain a general disclosure naming “0.7.4 and later.” Tests check versions 0.7.3, 0.7.4, and an unclassified version. Channel-install disclosure remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • gominimal/minimal issue 1992: The issue describes the daily update check and its disclosure; this change updates the installer text for the reporting threshold.

Possibly related PRs

  • gominimal/minimal#2650: That PR adds the daily update check and telemetry settings described by this installer disclosure.

Suggested reviewers: agent-137, jtnkminimal

Merge Risk: Minimal · up to 3382d

This change makes the installer's closing telemetry text match the pinned release, and tests cover releases on both sides of 0.7.4 and an unclassified version. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title is a Conventional Commit subject (fix(installer): ...) that matches the main change: the pinned-install card's reporting line now depends on the pinned version, so only releases at or after …
Description check Passed The description follows the template's Summary and Testing sections and exp 8000 lains what changes and why, with a reference to #3504. It does not fill the Checklist, and the Testing section lists test run…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title is a Conventional Commit subject (fix(installer): ...) that matches the main change: the pinned-install card's reporting line now depends on the pinned version, so only releases at or after 0.7.4 are described as reporting. It is specific and lower-case with no trailing period, and it reads clearly in history.

Full details: Description check

Explanation

The description follows the template's Summary and Testing sections and explains what changes and why, with a reference to #3504. It does not fill the Checklist, and the Testing section lists test runs but no pasted output, which the template asks for. The description also gives no 'Closes' or 'BREAKING CHANGE' information, and the template's PR-title guidance is not addressed. These gaps are minor, so the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit reads the version line,
Before the threshold, checks decline.
At 0.7.4, the notice shows,
Which way the daily reporting goes.
Unknown pins keep the range in view,
And tests check both sides, too.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9c5eea02-fd13-4cf7-a603-9c04c3362e88
Commits

Reviewing files that changed from the base of the PR and between ff906b9 and 3382d0b.

Files selected for processing: 2

  • scripts/install.sh
  • scripts/install_test.sh

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.

@minimal-foundry
minimal-foundry Bot commented Nov 18, 2026 •
Copy link
Copy Markdown
Contributor

Reviewed: no findings; approval withheld, 2 threads unresolved at 3382d0b601f1.

APPROVE withheld: 2 unresolved threads — norrietaylor scripts/install.sh, norrietaylor scripts/install.sh:1800. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 18, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one-line wording fix is correct. v0.7.3 has no update-check code, while release/0.7.x (the line that becomes 0.7.4) has the update_check module, so "min 0.7.4 and later report this install" accurately describes pinned installs. The comment above the card matches, and the existing installer assertion at install_test.sh:1533 still holds. I left two non-blocking notes: the card could use the known $VERSION instead of a range, and no test pins the new qualifier.


Generated by Claude Code

Comment thread scripts/install.sh Outdated
# check and sends nothing, so the pinned line says which releases report.
if [ "$version_set" -eq 1 ]; then
say " ${dim}min reports this install once a day (no release notices for --version), sending its channel$rst"
say " ${dim}min 0.7.4 and later report this install once a day (no release notices for --version), sending the channel$rst"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low (non-blocking): the card already knows the pinned release ($VERSION, set from --version at line 1016 and printed in "Minimal $VERSION is ready."). AGENTS.md says to fill in a value when the message knows it. As written, --version 0.7.2 reads "min 0.7.4 and later report this install once a day", and the user still has to work out whether that applies to them. A cheap fix is to branch on $VERSION: print the current line for 0.7.4 and later (or a nightly sha), and for an older release state that this release sends no update check. If a version comparison in sh isn't worth it here, the current wording is accurate. I checked that v0.7.3 has no update_check module and release/0.7.x has one.


Generated by Claude Code

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3382d0b. The card now uses the version it knows: a release from 0.7.4 on reads "min reports this install once a day (no release notices for --version)…", and one before it reads "min 0.7.3 does not check for updates and sends nothing. Releases from 0.7.4 on report an install once a day." with no off switch shown, since there is no request to switch off. The comparison is plain sh on X.Y.Z. A version it cannot place (a pre-release, a nightly, a name that is not X.Y.Z) keeps the range wording, because a pre-release of 0.7.4 may or may not have the check.

Comment thread scripts/install.sh
# channel pointer applies to it.
# channel pointer applies to it. A pinned release older than 0.7.4 has no
# check and sends nothing, so the pinned line says which releases report.
if [ "$version_set" -eq 1 ]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low (non-blocking): no test pins the new wording. The only check on this line is scripts/install_test.sh:1533, which greps for no release notices for --version. That text is unchanged, so the test would still pass if the "0.7.4 and later" qualifier were dropped again. AGENTS.md ("User-facing text") asks for the exact text to be pinned in the test that checks it. Suggest adding grep -q "min 0.7.4 and later report this install" next to that assertion.


Generated by Claude Code

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3382d0b. The installer test now pins all three texts: the range (for the test's v1), the before-0.7.4 text for --version 0.7.3 (and that the off switch is not printed there), and the definite text for --version 0.7.4. It passes under sh, bash and dash.

The card knows the pinned version, so it no longer leaves the reader to work
out whether "0.7.4 and later" applies to them. A release from 0.7.4 on is told
that min reports the install once a day. A release before 0.7.4 is told that
it does not check for updates and sends nothing, and is not shown the off
switch for a request it never makes. A version the card cannot place (a
pre-release, a nightly, a name that is not X.Y.Z) keeps the range.

The installer test pins all three texts, the range one included, which no
test checked before.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Nov 19, 2026
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — norrietaylor scripts/install.sh, norrietaylor scripts/install.sh:1800. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 096ad25 Nov 19, 2026
45 of 47 checks passed
@bryan-minimal
bryan-minimal deleted the fix/install-card-pinned-wording branch November 19, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0