8000 fix: build-gvproxy_test.sh matches the build error text with no pipe, so a matching error always by minimal-foundry[bot] · Pull Request #3359 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix: build-gvproxy_test.sh matches the build error text with no pipe, so a matching error always - #3359

Merged
norrietaylor merged 1 commit into
mainfrom
agent/3347-build-gvproxy-test-sh-matches-the-build-error-te
Nov 13, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
agent/3347-build-gvproxy-test-sh-matches-the-build-error-te

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Defect

Fixes #3347

  • Epic: none; not charged to an epic
  • Size: S; estimated 6 code, 0 tests
  • May touch:
    • scripts/build-gvproxy_test.sh
Task marker
### D3050 — build-gvproxy_test.sh matches the build error text with no pipe, so a matching error always reads as a match
  kind: task
  size: S
  est: 6 code, 0 tests
  executor: agent
  defect: bug
  layers:
    - scripts:
      - scripts/build-gvproxy_test.sh: replaces the three printf into grep -q pipelines on $err (lines 131, 151, 166) with a case match or a here-string, so pipefail and SIGPIPE cannot fail them
      test: bash scripts/build-gvproxy_test.sh
      test: cargo test -p common --test shell_harnesses all_script_test_harnesses_pass
  proof: build-gvproxy_test.sh reports all checks passed on each of many repeated runs, and the patch digest check never fails when the build prints the expected error.

Proof

bash scripts/build-gvproxy_test.sh now reports 9 passed, 0 failed on every run (30 repeated runs, no failure). The three error-text checks use a case match on $err, so no pipe exists for pipefail or SIGPIPE to fail when the build prints the expected error.

Notes from the agent: The shell_harnesses test fails only because of scripts/metrics_test.sh. Its case missing_nextest_fails_mutants_mode fails ('mutants mode without nextest exit 127', 'not_measured: '). This task does not touch that script, and the failure looks environmental on this box. build-gvproxy_test.sh reports ok inside the same harness run. Note: the case match is a literal substring match. The old grep treated '.' in 'patch.$patch_name=' as a regex wildcard, so the new check is slightly stricter.

Tests

line exit tail
bash scripts/build-gvproxy_test.sh 0 ok - a pinned patch that applies builds the asset ok - the build runs with -mod=vendor -trimpath -buildvcs=false ok - a pinned go on PATH is used without a download ok - a patch whose digest differs from the lock stops the build and is named ok - a patch whose digest differs stops the buil
cargo test -p common --test shell_harnesses all_script_test_harnesses_pass 101 at least as strict as B and as H over two hundred random pairs == no_baseline_means_not_evaluated == ok - baseline is null ok - every ratchet is not_evaluated ok - the report says so ok - the report names the history ref it looked at == report_carries_every_section == ok - every section h

Verify

min task run agent-verify passed ([tasks.verify]).

printf piped into grep -q can fail under pipefail when grep exits early
and printf takes SIGPIPE, so a matching error read as a mismatch.
@coderabbitai
coderabbitai Bot commented Nov 12, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 911fb569-e2cd-4d53-9be8-e6db66d1edae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 1755a47ddeb7.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 12, 2026
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a failed check suite: the coder changed nothing. Revise round 1: no new commit. Commit 1755a47 already does the task. The failed checks are test-kvm and its aggregator ci-linux-kvm-success. That lane runs the VM integration harnesses from ci-linux-kvm.yml, and this script is not one of them. The log excerpt shows no failed step for this change, so I treat it as a KVM runner failure and recommend a re-run. The shell_harnesses test fails on this box in metrics_test.sh (missing_nextest_fails_mutants_mode). cargo-nextest is in /usr/bin here, so the check removes /usr/bin from PATH, and bash and python3 go with it (exit 127). This branch does not change metrics_test.sh. build-gvproxy_test.sh passes inside that same run.

@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read at 1755a47.

Right fix, and the stricter match is the correct one. A case on $err has no pipe, so neither pipefail nor a SIGPIPE to printf can turn a matching error into a failed check. The quoted pattern is a literal substring match, so the . in patch.$patch_name= now means a dot rather than any character, which is what the lock line actually says. The three checks keep their exact messages, and $patch_name stays inside the quotes, so a name with a glob character cannot change the pattern.

One note, not blocking: scripts/metrics_test.sh has the same printf '%s' "$x" | grep -q shape at two places (the quality-gate line and the clippy-strict line). The failure the agent saw there was a different case, but the shape is the same trap; worth a sibling task so the next flake of that kind does not get diagnosed twice.

@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 1755a47ddeb7 against D3050's plan block. The three error checks in scripts/build-gvproxy_test.sh now use a case glob match instead of printf | grep -q. Under pipefail, an early grep -q exit can SIGPIPE the printf and turn a match into a miss, which is the intermittent false negative in #3050. The glob also matches patch.$patch_name= literally, where grep read . as a wildcard. The change is within the task's one layer, and no other file is touched. Round 1's no-op is right: the test-kvm failure was not this change, and it is green on the re-run.

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 7770290 Nov 13, 2026
41 of 43 checks passed
@norrietaylor
norrietaylor deleted the agent/3347-build-gvproxy-test-sh-matches-the-build-error-te branch November 13, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3050 — build-gvproxy_test.sh matches the build error text with no pipe, so a matching error always reads as a match

2 participants

0