8000 build-gvproxy_test.sh fails intermittently: a matching error reads as no match · Issue #3050 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

build-gvproxy_test.sh fails intermittently: a matching error reads as no match #3050

Closed

Description

@norrietaylor

Found on #3039 (T146), which does not touch this script. all_script_test_harnesses_pass failed at head af0151a7 (job 127339253940) and passed at the next head, with no change to the script or its test.

The failing line:

FAIL - a patch whose digest differs from the lock stops the build and is named (exit 1): build-gvproxy: patch 0001-forwarder-unexpose-closes-accepted-connections.patch does not match its SHA-256 in /tmp/tmp.H3dkqbTixQ/digest/gvproxy.lock

The build exited 1 and printed the text the test looks for, and the test still called it a failure.

A likely cause, not proven: scripts/build-gvproxy_test.sh:131 runs printf '%s' "$err" | grep -q "..." under set -o pipefail. $err has three lines and the match is on the first. If bash writes printf's output line by line, grep -q can exit first, printf dies on SIGPIPE, and the pipeline reads as false. Other grep -q checks on $err in the test can race the same way.

A case match on $err, or a here-string into grep, removes the pipe.

Activity

  1. norrietaylor commented on Nov 18, 2026

    @norrietaylor
    MemberAuthor

    Closing as fixed on main by #3359.

    What a read of main at 385add8 found:

    77702905 (PR #3359) replaced all three printf "$err" | grep -q pipes with case matches: scripts/build-gvproxy_test.sh:131, :151, :164. Remaining grep -q calls (:116,:121,:136,:156) read $STUB_LOG files directly, with no pipe.
    

    Reopen this issue if any part of it is still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0