8000 T37 — Bare min init writes the entry shape by minimal-foundry[bot] · Pull Request #3202 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T37 — Bare min init writes the entry shape - #3202

Merged
agent-137 merged 11 commits into
mainfrom
agent/3193-bare-min-init-writes-the-entry-shape
Nov 11, 2026
Merged

agent-137 merged 11 commits into
mainfrom
agent/3193-bare-min-init-writes-the-entry-shape

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

T37 — Bare min init writes the entry shape

slice: S5
kind: task
covers: BCLI-017
size: S
est: 30 code, 50 tests
executor: agent
difficulty: routine
model: light
diagnostics: bare min init writes a minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"), and mfile reads it without an unknown-field warning, pinned by init_scaffolds_entry_shape
observability: the command's existing tracing span records the verb, shape = "entry", the entry dev, and the outcome
layers:
- client:
- crates/minimal/src/cmd/project.rs: cmd_init and offer_mfile_scaffold always write the entry shape; remove INIT_ENTRY_SHAPE, the entry_shape parameter of run_init_flow, and the interim comments
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal init_scaffolds_entry_shape
produces: none
consumes: none
proof: bare min init writes an entry-shaped minimal.toml (it replaces init_no_flags_writes_legacy_shape, which pinned the legacy shape), the file loads through mfile with no unknown-field warning, and min session start on it gets the [defaults.session] packages.
depends on:
- blocked by #3188

Proof

Bare min init, and the scaffold that min activate offers, now write minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"). The legacy-shape test init_no_flags_writes_legacy_shape is gone. The new test shows that this file loads through mfile with no unknown-field warning, and that a session start on it sends the [defaults.session] packages (base, vim, git) on the create request.

Notes from the agent: cargo-nextest is not installed here, so I ran the same filter with cargo test -p minimal --lib. The new test in tests.rs does not run the whole min init flow. op::InitProject checks out the default packages repo over the network. So the test converts the initializer's scaffold with to_entry_shape, which is the step run_init_flow now always takes. Session start reads packages from File.session. legacy::settle fills that field from [defaults.session], so the blocker (#3188) did not stop this task. The cmd_init tracing event now always records shape = "entry" and entry = "dev".

Tests

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify

min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Finished `dev` profile [unoptimized] target(s) in 1m 19s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Closes #3193

min init and the min activate scaffold now always write minimal.toml
with [defaults.session], [defaults.task] and [boxes.dev]. Remove the
INIT_ENTRY_SHAPE gate, the entry_shape parameter of run_init_flow and
the legacy-shape test. Add a test that the scaffold loads through mfile
with no unknown-field warning and that a session start sends the
[defaults.session] packages (BCLI-017).
@coderabbitai
coderabbitai Bot commented Nov 9, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7269cfe7-1883-48cb-904f-9193fecf3999

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 9, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 1583065fb852.

Nothing to do.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Bare min init and the min activate scaffold now write [defaults.session], [defaults.task] and [boxes.dev] with type = "session". This is the minimal.toml shape in the design (lines 59, 1205 and 1208). The interim from #2962 is removed at its flip condition. Session start now gets the [defaults.session] packages through mfile::legacy::settle, and the new test pins this.

Ruled at 46f930a against gominimal/arch@1f87ce800219 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/tests.rs Resolved
Split the write half of run_init_flow into write_init_plan, which owns
the entry-shape conversion. The tests.rs test now calls it with the
initializer's plan and reads the file it writes, so it fails if the
conversion leaves the flow. Drop the shape asserts that duplicate
init_scaffolds_entry_shape.
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] crates/minimal/src/tests.rs.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The compare splits write_init_plan out of run_init_flow. Every scaffold still goes through to_entry_shape. The test now drives the real write path and reads the file it writes, so the proof is stronger. init_scaffolds_entry_shape still pins the two [defaults.<type>] asserts that the commit drops. BCLI-017 conforms to lines 448 and 1204 to 1208 of the design, as on 46f930ad.

Ruled at 638a767 against gominimal/arch@1f87ce800219 by claude-opus-5-5.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on the runtime's review findings, pushed as 638a76792060.

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
    Checking common v0.0.1 (/workbench/crates/common)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 34s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/tests.rs: Split the write half of run_init_flow into write_init_plan, which owns the to_entry_shape call. The test now drives it with an op::InitPlan and reads the file it writes, so the test fails if the conversion is removed. I removed the duplicate shape asserts. GENERATED stays because generate_mfile is p

Bare min init writes a minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"). The test now drives the write path of the init flow and reads the file from disk. That file loads through mfile with no unknown-field warning, and a session start on it sends the [defaults.session] packages base, vim and git. The legacy-shape test init_no_flags_writes_legacy_shape is gone.

Notes from the agent: Revise round 1. run_init_flow needs a network checkout of the packages repo, so no test can call it directly. I split its write half into write_init_plan, which now does the to_entry_shape conversion, and the test calls that function. The GENERATED copy stays in the test because op::project::init::generate_mfile is private to the op crate, and the op crate is outside this task's layers. That legacy output is pinned in op by generate_mfile_falls_back_to_upstream_with_session. I did not run clippy-strict.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 9, 2026 21:04
@agent-137
agent-137 marked this pull request as ready for review November 9, 2026 21:10
every_create_session_asserts_the_daemon_build failed in CI: the new
entry-shape test builds a CreateSessionRequest it never sends.
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The ruling did not change. The new commit adds the entry-shape test's create request to the inventory test. It uses the same "asserts nothing" comment as the other unit-test requests. The merge of main is clean, and it does not touch the init path. Bare min init writes [defaults.<type>] and [boxes.dev] with type = "session", as architecture.md lines 448, 1205 and 1208 say. No conditions.

Ruled at 1e6a611 against gominimal/arch@9e2ff817adba by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] crates/minimal/src/tests.rs.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a failed check suite, pushed as 1e6a611a93b1.

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

.0.1 (/workbench/crates/mlog)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking ssh-key v0.7.0-rc.11
    Checking signal-hook-mio v0.2.5
    Checking generic-array v1.4.4
    Checking derive_more v2.1.1
    Checking russh-cryptovec v0.62.0
    Checking num-bigint v0.5.1
    Checking pem v4.0.0
    Checking yasna v0.6.0
    Checking russh-util v0.52.0
    C
10000
hecking hex-literal v1.1.0
    Checking hashbrown v0.14.5
    Checking bitflags v1.3.2
    Checking tagptr v0.2.0
    Checking constcat v0.6.1
    Checking managed v0.8.0
    Checking moka v0.12.16
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking smoltcp v0.14.0
    Checking dashmap v6.2.1
    Checking russh v0.65.0
    Checking rcgen v0.14.10
    Checking crossterm v0.29.0
    Checking async-compression v0.4.50
    Checking async-tar v0.6.1
    Checking line-clipping v0.3.8
    Checking object v0.40.0
    Checking serde_bytes v0.11.19
    Checking is_executable v1.0.6
    Checking clap_complete v4.6.11
    Checking russh-sftp v2.4.0
    Checking ratatui-widgets v0.3.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking sysinfo v0.39.6
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-macros v0.7.2
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking ratatui-crossterm v0.1.2
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking fuzzy-matcher v0.3.7
    Checking ratatui v0.30.2
    Checking inquire v0.9.4
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking wait-timeout v0.2.1
    Checking bit-vec v0.10.1
    Checking quick-error v1.2.3
    Checking bit-set v0.11.1
    Checking rusty-fork v0.3.1
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking rand_xorshift v0.5.0
    Checking core_detect v1.0.0
    Checking unarray v0.1.4
    Checking similar v2.7.0
    Checking insta v1.49.0
    Checking proptest v1.12.0
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 51s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Bare min init now writes a minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"). The legacy-shape test init_no_flags_writes_legacy_shape is gone. init_scaffolds_entry_shape_loads_and_starts_with_its_packages shows that the file loads through mfile with no unknown-field warning, and that a session start on it sends the [defaults.session] packages.

Notes from the agent: Revise round 2: the CI tests failure came from tests::every_create_session_asserts_the_daemon_build. That inventory test lists every CreateSessionRequest the crate builds, and the new entry-shape test builds one that it never sends. I added that test to the inventory as 'asserts nothing'. cargo-nextest is not installed here, so I ran each of the 846 minimal lib tests in its own process to imitate nextest. Before the fix, three failed. After the fix, two still fail on this box only, and neither touches the init path: legacy_network_spellings_parse_with_hint fails only without --nocapture (it passes the way nextest runs it), and resolver::tests::the_answerer_facts_ride_beside_a_down_proxy_sibling expects nothing to listen on local port 7656. I did not run the integration test targets under crates/minimal/tests.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 9, 2026 22:15
@agent-137
agent-137 marked this pull request as ready for review November 9, 2026 22:19
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @agent-137 closed the last one. The review of 1e6a611a93b1 withheld this approval on the threads open then. Posted as a comment, as the review itself was; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 9, 2026
…nit-writes-the-entry-shape

# Conflicts:
#	crates/minimal/src/tests.rs
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: one line, CI is red on it. Otherwise this is correct against #3193 / BCLI-017.

Blocking

  • tests fails 1/5492 at crates/minimal/src/tests.rs:416 (every_create_session_asserts_the_daemon_build). The new test builds a CreateSessionRequest::new(...), so the source-scanning inventory (create_site_inventory, tests.rs:599) now finds tests.rs::init_scaffolds_entry_shape_loads_and_starts_with_its_packages = asserts nothing, which isn't in the expected list. Add it after entry_name_registers_and_creates_under_one_cleaned_name with the neighbours' comment ("A unit test's request, never sent: it checks the session spec's packages."). Running the full crate suite, not only the filtered test, would have caught it.

Note

  • The plan's test line init_scaffolds_entry_shape is a substring of both the new test and the existing one in project.rs:1289, so the nextest filter matches two tests. Harmless; flagging for whoever reads the plan.

Checked: both callers (cmd_init, offer_mfile_scaffold) write the entry shape; [defaults.session] packages survive via mfile::legacy::settle; state_key keeps its task-only meaning; the no-unknown-field-warning assertion captures the real tracing::warn! path; init → Scaffold mapping still tested at project.rs:1292.
Not checked: e2e (queued), and runtime selection of [boxes.dev] from the generated file.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This head adds only a merge of main to the head that passed before. The merge does not change the min init write path or its test. Bare min init still writes [defaults.session], [defaults.task] and [boxes.dev], as architecture.md lines 448, 1205 and 1208 require. BCLI-017 conforms.

Ruled at 2f453ef against gominimal/arch@9e2ff817adba by claude-opus-5-5.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

A merge of main before round 3, not counted against the cap (1 of 3), pushed as 2f453ef7559b.

Resolved conflicts in: crates/minimal/src/tests.rs

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

ng compression-codecs v0.4.45
    Checking ring v0.17.14
    Checking ml-kem v0.3.2
    Checking ratatui-core v0.1.2
    Checking heapless v0.9.3
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking ssh-key v0.7.0-rc.11
    Checking signal-hook-mio v0.2.5
    Checking generic-array v1.4.4
    Checking derive_more v2.1.1
    Checking russh-cryptovec v0.62.0
    Checking num-bigint v0.5.1
    Checking pem v4.0.0
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking yasna v0.6.0
    Checking russh-util v0.52.0
    Checking hex-literal v1.1.0
    Checking hashbrown v0.14.5
    Checking bitflags v1.3.2
    Checking tagptr v0.2.0
    Checking constcat v0.6.1
    Checking managed v0.8.0
    Checking moka v0.12.16
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking smoltcp v0.14.0
    Checking dashmap v6.2.1
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking russh v0.65.0
    Checking rcgen v0.14.10
    Checking crossterm v0.29.0
    Checking async-compression v0.4.50
    Checking async-tar v0.6.1
    Checking line-clipping v0.3.8
    Checking object v0.40.0
    Checking serde_bytes v0.11.19
    Checking is_executable v1.0.6
    Checking russh-sftp v2.4.0
    Checking clap_complete v4.6.11
    Checking op v0.0.1 (/workbench/crates/op)
    Checking ratatui-widgets v0.3.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking sysinfo v0.39.6
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-macros v0.7.2
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking ratatui-crossterm v0.1.2
    Checking fuzzy-matcher v0.3.7
    Checking ratatui v0.30.2
    Checking inquire v0.9.4
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking wait-timeout v0.2.1
    Checking bit-vec v0.10.1
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking quick-error v1.2.3
    Checking rusty-fork v0.3.1
    Checking bit-set v0.11.1
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking rand_xorshift v0.5.0
    Checking core_detect v1.0.0
    Checking unarray v0.1.4
    Checking similar v2.7.0
    Checking proptest v1.12.0
    Checking insta v1.49.0
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 08s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Bare min init writes a minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"). The file loads through mfile with no unknown-field warning, and a session start on it sends the [defaults.session] packages. The branch now merges cleanly with main.

Notes from the agent: Revise round 3 was a conflict round only. The conflict in crates/minimal/src/tests.rs was two tests appended at the same place: this branch's init_scaffolds_entry_shape_loads_and_starts_with_its_packages and main's box_store_dir helper and the tests after it. I kept both sides and completed the merge in commit 2f453ef. cargo-nextest is not installed here, so I ran the same filter through cargo test. The merge brought in files from main under .github/ and elsewhere. Those are main's changes, not this task's.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 9, 2026 23:22
@agent-137
Copy link
Copy Markdown
Member

/revise

Head 2f453ef7. One blocking item from @norrietaylor's CHANGES_REQUESTED review. CI's tests lane is red on it.

1. Register the new test in the create-site inventory.
every_create_session_asserts_the_daemon_build (crates/minimal/src/tests.rs:416) fails. The new test init_scaffolds_entry_shape_loads_and_starts_with_its_packages builds a CreateSessionRequest::new(...), so create_site_inventory (tests.rs:599) now finds tests.rs::init_scaffolds_entry_shape_loads_and_starts_with_its_packages = asserts nothing. Add that entry to the expected list, after entry_name_registers_and_creates_under_one_cleaned_name, with the comment its neighbours carry: "A unit test's request, never sent: it checks the session spec's packages." Run the whole minimal crate suite, not only the filtered test.

Reply on Norrie's review with the commit. Change nothing else.

@agent-137
agent-137 marked this pull request as ready for review November 10, 2026 00:45
@agent-137
Copy link
Copy Markdown
Member

Undrafted by the BCLI babysitter. The draft comes only from the runtime's test lines failing with no such command: nextest, and every file is inside layers:. That is the owner's standing rule for BCLI. The /revise above (Norrie's inventory line) was accepted but has not started a round yet.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The ruling is PASS, and it is the same as the PASS on 2f453ef7. The new commit only rewrites one inventory comment in tests.rs. The two merges from main do not change the init path. Bare min init still writes [defaults.session], [defaults.task] and [boxes.dev], as architecture.md lines 448, 1205 and 1208 require.

Ruled at bf18565 against gominimal/arch@9e2ff817adba by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, supply-chain); did not complete: security.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on a /revise note, pushed as bf185659f8a4.

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

ng compression-codecs v0.4.45
    Checking ml-kem v0.3.2
    Checking ring v0.17.14
    Checking ratatui-core v0.1.2
    Checking heapless v0.9.3
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking ssh-key v0.7.0-rc.11
    Checking signal-hook-mio v0.2.5
    Checking generic-array v1.4.4
    Checking derive_more v2.1.1
    Checking russh-cryptovec v0.62.0
    Checking num-bigint v0.5.1
    Checking yasna v0.6.0
    Checking pem v4.0.0
    Checking russh-util v0.52.0
    Checking bitflags v1.3.2
    Checking tagptr v0.2.0
    Checking constcat v0.6.1
    Checking managed v0.8.0
    Checking hex-literal v1.1.0
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking hashbrown v0.14.5
    Checking russh v0.65.0
    Checking smoltcp v0.14.0
    Checking dashmap v6.2.1
    Checking moka v0.12.16
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking rcgen v0.14.10
    Checking crossterm v0.29.0
    Checking async-compression v0.4.50
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking async-tar v0.6.1
    Checking line-clipping v0.3.8
    Checking object v0.40.0
    Checking serde_bytes v0.11.19
    Checking is_executable v1.0.6
    Checking clap_complete v4.6.11
    Checking russh-sftp v2.4.0
    Checking ratatui-widgets v0.3.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking sysinfo v0.39.6
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-macros v0.7.2
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking ratatui-crossterm v0.1.2
    Checking fuzzy-matcher v0.3.7
    Checking ratatui v0.30.2
    Checking inquire v0.9.4
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking bit-vec v0.10.1
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking rusty-fork v0.3.1
    Checking bit-set v0.11.1
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking rand_xorshift v0.5.0
    Checking core_detect v1.0.0
    Checking unarray v0.1.4
    Checking similar v2.7.0
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking proptest v1.12.0
    Checking insta v1.49.0
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 06s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Bare min init writes an entry-shaped minimal.toml with [defaults.session], [defaults.task] and [boxes.dev] (type = "session"). The file loads through mfile with no unknown-field warning, and a session start on it gets the [defaults.session] packages. The create-site inventory test now lists the new init test, so every_create_session_asserts_the_daemon_build passes again.

Notes from the agent: Revise round 3. The inventory entry for init_scaffolds_entry_shape_loads_and_starts_with_its_packages was already on the branch from commit 5d0547e, after entry_name_registers_and_creates_under_one_cleaned_name. This round only replaces its comment with the wording the reviewer asked for (commit 351a9f2). every_create_session_asserts_the_daemon_build passes. Whole-crate run: in parallel, 19 tests failed and the run hung until the timeout killed it. A serial re-run of those names ran 20 tests and 18 passed. Two fail even when run alone: tests::legacy_network_spellings_parse_with_hint (the captured stderr is empty) and resolver::tests::the_answerer_facts_ride_beside_a_down_proxy_sibling (resolver.rs:7689). This branch does not change resolver.rs or the code those tests check, and its diff to tests.rs only adds lines. I did not run them on main to confirm that they also fail there. I did not post a reply on the review because I have no credential for gh.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 10, 2026 00:54
@agent-137
agent-137 marked this pull request as ready for review November 10, 2026 01:17
@agent-137
Copy link
Copy Markdown
Member

Undrafted by the BCLI babysitter after round 3. The draft comes only from the runtime's test lines failing with no such command: nextest, and every file is inside layers:. That is the owner's standing rule for BCLI. @norrietaylor, round 3 adds the create-site inventory line from your review.

…nit-writes-the-entry-shape

# Conflicts:
#	crates/minimal/src/tests.rs
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Bare min init writes the entry shape that lines 448, 1205 and 1208 of architecture.md describe. The PR's own hunks did not change since the PASS on bf185659. The two merges of main and the new design commit do not touch min init or the minimal.toml layout.

Ruled at fd56cda against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

A merge of main before round 4, not counted against the cap (2 of 3), pushed as fd56cda7373a.

Resolved conflicts in: crates/minimal/src/tests.rs

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

4.45
    Checking ml-kem v0.3.2
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking ratatui-core v0.1.2
    Checking heapless v0.9.3
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking ssh-key v0.7.0-rc.11
    Checking signal-hook-mio v0.2.5
    Checking generic-array v1.4.4
    Checking derive_more v2.1.1
    Checking russh-cryptovec v0.62.0
    Checking num-bigint v0.5.1
    Checking yasna v0.6.0
    Checking pem v4.0.0
    Checking russh-util v0.52.0
    Checking bitflags v1.3.2
    Checking tagptr v0.2.0
    Checking constcat v0.6.1
    Checking managed v0.8.0
    Checking hex-literal v1.1.0
    Checking hashbrown v0.14.5
    Checking smoltcp v0.14.0
    Checking russh v0.65.0
    Checking dashmap v6.2.1
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking moka v0.12.16
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcgen v0.14.10
    Checking crossterm v0.29.0
    Checking async-compression v0.4.50
    Checking async-tar v0.6.1
    Checking line-clipping v0.3.8
    Checking object v0.40.0
    Checking serde_bytes v0.11.19
    Checking is_executable v1.0.6
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking russh-sftp v2.4.0
    Checking clap_complete v4.6.11
    Checking ratatui-widgets v0.3.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking sysinfo v0.39.6
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-macros v0.7.2
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking ratatui-crossterm v0.1.2
    Checking fuzzy-matcher v0.3.7
    Checking ratatui v0.30.2
    Checking inquire v0.9.4
    Checking op v0.0.1 (/workbench/crates/op)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking vsock v0.5.4
    Checking vte v0.15.0
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking bit-vec v0.10.1
    Checking bit-set v0.11.1
    Checking rusty-fork v0.3.1
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking rand_xorshift v0.5.0
    Checking core_detect v1.0.0
    Checking unarray v0.1.4
    Checking similar v2.7.0
    Checking insta v1.49.0
    Checking proptest v1.12.0
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 55s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Bare min init writes an entry-shaped minimal.toml with [boxes.dev] of type session. The file loads through mfile with no unknown-field warning, and a session start on it sends the [defaults.session] packages. The branch now merges cleanly with main.

Notes from the agent: Revise round 4 was a conflict with main only. In crates/minimal/src/tests.rs, both sides added tests at the same place. I kept both: this task's init_scaffolds_entry_shape_loads_and_starts_with_its_packages, then main's min box wait tests. The merge commit is e2e3bee. The other files in the merge diff come from main. cargo-nextest is not installed here, so I ran the test line with cargo test and the same filter. That test build compiles the whole tests.rs file, main's new tests included.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 10, 2026 03:49
@agent-137
agent-137 marked this pull request as ready for review November 10, 2026 04:15
@agent-137
Copy link
Copy Markdown
Member

Undrafted by the BCLI babysitter after the runtime's merge of main. The only draft causes are covered by the owner's standing rules: the runtime's nextest-missing test lines, plus, on #3185, out-of-layers files that a round asked for.

…nit-writes-the-entry-shape

# Conflicts:
#	crates/minimal/src/tests.rs
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Bare min init and the min activate scaffold now always write the entry shape: [defaults.session], [defaults.task] and [boxes.dev] with type = "session". That is the minimal.toml layout in architecture.md lines 1204 to 1208. The merge of main does not change the lines of this PR. The PASS on fd56cda7 holds for this head.

Ruled at 1583065 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a conflict with the base branch, pushed as 1583065fb852.

Resolved conflicts in: crates/minimal/src/tests.rs

line exit tail
cargo nextest run -p minimal init_scaffolds_entry_shape 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.

Verify min task run agent-verify exited 100 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

 {
                "parent_span_id": "0ff15f6433005b01",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "74a9aa454c0e542f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "74a9aa454c0e542f",
                "queued_behind": "0",
                "span_id": "0a39084b98d4c7e8",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "0ff15f6433005b01",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "4f40c9b3c1f540f1",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "4f40c9b3c1f540f1",
                "queued_behind": "0",
                "span_id": "96b6d733ccbc4c7b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "4f40c9b3c1f540f1",
                "queued_behind": "0",
                "span_id": "bfecc26a5cbdcc16",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "bfecc26a5cbdcc16",
                "span_id": "6d2ebae079036887",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "bfecc26a5cbdcc16",
                "queued_behind": "0",
                "span_id": "05206b5eca3ed0b3",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  57.253s] 1062 tests run: 1061 passed, 1 failed, 1 skipped
        FAIL [   2.880s] (1062/1062) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Bare min init writes an entry-shaped minimal.toml with [defaults.session], [defaults.task] and [boxes.dev]. The file loads through mfile with no unknown-field warning, and a session start on it gets the [defaults.session] packages. The branch now merges cleanly with main.

Notes from the agent: Conflict round. The one conflict was in the create-site inventory list in crates/minimal/src/tests.rs. This branch added the init_scaffolds_entry_shape_loads_and_starts_with_its_packages entry and main added planned_session_request. I kept both, in sorted order, and completed the merge commit. The inventory test every_create_session_asserts_the_daemon_build passes with both entries. No other change this round.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a failed check suite: the coder changed nothing. Revise round 5: no code change. Every failed check in the directive failed in CI setup, before any build. clippy, native-daemon-e2e and minimald-root-integration exit 100 on apt-get: "Temporary failure resolving 'azure.archive.ubuntu.com'" when the runner fetched protobuf-compiler. The tests job also exits 100, which matches the same apt step. ci-linux-native-success is the lane aggregator and fails because those jobs fail. At the branch head (after the merge of origin/main) the test line passes, and cargo clippy -p minimal --all-targets -- -D warnings is clean. A re-run of the checks is the next step. No INIT_ENTRY_SHAPE or entry_shape parameter remains in crates/minimal/src.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on a failed check suite: the coder changed nothing. Round 6 changed nothing on purpose. The failed checks are CI infrastructure faults, not faults in this change. In artifacts and native-daemon-e2e, apt-get exited with code 100 on 'Temporary failure resolving azure.archive.ubuntu.com' while it installed protobuf-compiler. ci-macos-success is the lane aggregator, and its log shows only exit 1, which a failed dependency job causes. A re-run of the check suite is the next step. The directive listed no review threads.

@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
Copy link
Copy Markdown
Member

@norrietaylor could you re-review this? Your one blocking item from Nov 9 (the every_create_session_asserts_the_daemon_build inventory line in crates/minimal/src/tests.rs) was fixed in a later round, and CI is green on the current head 1583065f. The only changes since are merges of main. Your changes-requested review is the last thing holding the merge.

@agent-137
agent-137 added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 2c25c2a Nov 11, 2026
61 of 77 checks passed
@agent-137
agent-137 deleted the agent/3193-bare-min-init-writes-the-entry-shape branch November 11, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T37 — Bare min init writes the entry shape

3 participants

0