8000 T10 — Start a box from its entry by minimal-foundry[bot] · Pull Request #3185 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T10 — Start a box from its entry - #3185

Merged
agent-137 merged 27 commits into
mainfrom
agent/2898-start-a-box-from-its-entry
Nov 10, 2026
Merged

agent-137 merged 27 commits into
mainfrom
agent/2898-start-a-box-from-its-entry

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 9, 2026 •
Copy link
Copy Markdown
Contributor

T10 — Start a box from its entry

slice: S3
kind: task
covers: BCLI-029, BCLI-071, BCLI-072, BCLI-069
size: L
est: 280 code, 600 tests
executor: agent
difficulty: needs care
model: strongest
diagnostics: off a terminal, min box start of a terminal entry prints " needs a terminal. Run it from a terminal, or pass --detach." on stderr and exits 2 before it creates anything, pinned by start_off_tty_exit2_names_detach
observability: the command's existing tracing span records the verb, the box id it resolved and the outcome
layers:
- client:
- crates/minimal/src/cli.rs: the verb's arguments and help in the one command model
- crates/minimal/src/cmd/mod.rs: dispatches the verb
- crates/minimal/src/cmd/boxes/create.rs: min box start and min session start: entry choice, --name, --new, attach unless --detach
- crates/minimal/src/cmd/session.rs: min session start picks the default, else the sole session entry
- crates/minimal/src/main.rs: failure_exit_code maps this verb's refusals to their exit codes
- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal start_attaches_pty_box_unless_detached
test: cargo nextest run -p minimal start_off_tty_exit2_names_detach
test: cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait
test: cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name
test: cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag
test: cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole
test: cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries
test: cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix
test: cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole
test: cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries
produces: none
consumes: none
proof: min box start and min session start create a box from an entry, attach a terminal box, and refuse a held name with the holder named.
depends on:
- blocked by #2892

Residuals

Each interim fails closed with exit 2, and its doc comment names the issue and the condition for removing it (arch ruling 1093, C1–C3).

Merge order: this PR merges after #3195 (T8), with main merged in, so the hint's min box wait exists.

Proof

A person can now run min box start [] and min session start []. With no entry, box start picks the default entry of any type, else the only entry. Session start picks the default session entry, else the only session entry. Both count the implicit default entry. A session box attaches this terminal unless --detach is given. Off a terminal without --detach, the command prints " needs a terminal. Run it from a terminal, or pass --detach." and exits 2 before it creates a box. A held name exits 2. The message names the holder and its id, and it names --new and --name.

Notes from the agent: Each nextest line ran as cargo test -p minimal --lib , because cargo-nextest is not installed here. I made one run of the whole minimal lib suite. It reached my 25-minute limit and did not finish. The failures it showed passed when rerun at 4 threads, with two exceptions. (1) legacy_network_spellings_parse_with_hint fails only under cargo test output capture. It passes with --nocapture, and it is the same under nextest. (2) resolver::tests::the_answerer_facts_ride_beside_a_down_proxy_sibling fails alone too. It is about port state on this box, and resolver.rs is not part of this change. I updated every_create_session_asserts_the_daemon_build to list the two unsent requests in my name test.

Gaps that need files outside the layers:

  • A task entry starts through the detached run in task.rs (run_entry). That path always asks for a fresh instance and takes no name. So for a task entry, --name is ignored and a held name is never refused. --name on min box run and min task run (BCLI-069) is not done either, because task.rs is not in the layers.
  • Agent, service and project-type entries are refused with exit 2: "Cannot start . Its entry in minimal.toml has the type ..., and min box start starts session and task entries only."
  • A named session entry ([sessions.dev]) gives the box its name and spec entry. The spec body still comes from the legacy …[truncated]

Tests

line exit tail
cargo nextest run -p minimal start_attaches_pty_box_unless_detached 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal start_off_tty_exit2_names_detach 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-2 in box runtime-implement-test-2-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-3 in box runtime-implement-test-3-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-4 in box runtime-implement-test-4-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-5 in box runtime-implement-test-5-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-6 in box runtime-implement-test-6-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-7 in box runtime-implement-test-7-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-8 in box runtime-implement-test-8-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-9 in box runtime-implement-test-9-1... error: no such command: 'nextest' help: a command with a simil

Verify

min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Finished `dev` profile [unoptimized] target(s) in 1m 33s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Closes #2898

Both verbs create a box from an entry of the project. With no entry,
min box start picks the default entry of any type, else the only one,
and min session start picks the default session entry, else the only
one. The implicit default entry counts. A session box attaches this
terminal unless --detach is given. Off a terminal, without --detach,
the start exits 2 before it creates anything. A task entry starts
detached, with its stdin closed, and one hint names min box run,
min box logs and min box wait.

--name sets the box's [box] name, and --new asks for a fresh instance.
A held name exits 2, names the holder and names --new and --name.
@minimal-foundry
minimal-foundry Bot requested a review from a team as a code owner November 9, 2026 17:34
@coderabbitai
coderabbitai Bot commented Nov 9, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 45b8d74a-583b-43e7-b3b4-6dde1d40908b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 9, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: every review thread resolved at 5ab41501f536.

@agent-137 resolved the last thread, which releases the approval this review had withheld.

Nothing to do.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 6 conditions · the full ruling

The new start verbs are in the right layers, and the entry choice and terminal rules conform for session entries. One gap is on a security boundary. A named session entry gets the egress of the default or only session entry, not its own (C1, design line 906). The new pickers drop the refusal for a type the client cannot resolve, so they can start the implicit default beside a session-rooted entry (C2, line 1178). A task entry start drops --name, and an unknown entry exits 2, not 4 (C3, C4). The two gaps in the PR body need filed issues before they can stay open (C5, C6).

Ruled at 01ed3e3 against gominimal/arch@7a86ec7bb3c0 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/session.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/main.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
The run path names a task box itself and takes no name, so the start
dropped --name without a word. It now refuses the flag with exit 2
before it creates anything. --new already holds for a task box: its
generated name is never held.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author
10000

Round 1 of 10 on the runtime's review findings, pushed as de31cf8d2e34.

line exit tail
cargo nextest run -p minimal start_attaches_pty_box_unless_detached 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal start_off_tty_exit2_names_detach 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-2 in box runtime-implement-test-2-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-3 in box runtime-implement-test-3-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-4 in box runtime-implement-test-4-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-5 in box runtime-implement-test-5-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-6 in box runtime-implement-test-6-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-7 in box runtime-implement-test-7-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-8 in box runtime-implement-test-8-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-9 in box runtime-implement-test-9-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Finished `dev` profile [unoptimized] target(s) in 1m 26s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal/src/cmd/boxes/create.rs:673: plan_start now refuses --name for a task entry with exit 2 (StartEntryRefusal::NameUnsupported), pinned in create_verbs_name_flag_overrides_box_name. The run path is in task.rs, outside this task's layers, and takes no name, so the flag cannot pass through yet. --new stays accepted: the run path nam

min box start and min session start create a box from an entry, attach a terminal box, and refuse a held name with the holder named. min box start --name now refuses with exit 2 and does not drop the flag.

Notes from the agent: cargo-nextest is not installed on this box. I ran each test: line with cargo test -p minimal --lib , and all passed. The task run path (crates/minimal/src/task.rs, outside the layers) takes no box name, so a task entry cannot pass --name to it in this task. The start refuses the flag instead, with StartEntryRefusal::NameUnsupported (exit 2). New printed text: "Cannot start with --name. A box from a task entry gets a generated name. Run min box start without --name." A later task can carry --name through RunEntry, as BCLI-069 asks for min box run.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 9, 2026 17:50
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE withheld: 9 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/boxes/create.rs:673, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:763, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:319, minimal-arch[bot] crates/minimal/src/cmd/session.rs:58, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:664, ….

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 1 of 3 personas ran (supply-chain); did not complete: correctness, security.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The new refusal of --name for a task entry fails closed, and that is better than a dropped flag. It is still an interim. Lines 458 and 468 give min box start a --name, and line 389 makes a plain start refuse a held name. A task-entry start does neither, because run_entry always makes a fresh instance. The PR body names this gap and the refused agent and service entries, but links no issue. File and link the two issues (C1, C3), and correct the run-path comment (C2).

Ruled at de31cf8 against gominimal/arch@4fa352b60f7b by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@agent-137
Copy link
Copy Markdown
Member

/revise

Head de31cf8d. Arch ruling 1075 has three conditions. Change no behaviour: these are comments, the PR body, and one comment correction.

C1: the task-entry --name interim links #3196.
Name #3196 in the doc comment of StartEntryRefusal::NameUnsupported (crates/minimal/src/cmd/boxes/create.rs, around lines 396–398), and in the plan_start comment above the Some(boxes::TASK_BOX_TYPE) if start.name.is_some() arm. Give the flip condition there: remove the refusal when RunEntry takes a name. List #3196 under the PR body's gaps.

C2: correct the run-path comment in plan_start (around lines 657–660).
The run path does not name the box task-<entry>-<hex>. run_entry calls request_fresh_instance (crates/minimal/src/task.rs), and the daemon names the box <entry>-<n> (BOX-163). The comment must say that a task-entry start is always a fresh instance, and that a plain start does not refuse a held name until #3196 lands.

C3: the unsupported-type interim links #3197.
Name #3197 in a comment on the box_type => Err(StartEntryRefusal::UnsupportedType arm of plan_start (around line 674), and list it under the PR body's gaps.

Reply on each arch thread with the commit that answers it.

Name the issues that track the task-entry --name refusal and the
unsupported-type refusal, and correct the run-path comment: a
task-entry start is always a fresh instance named <entry>-<n>.
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as c102776596ff.

line exit tail
cargo nextest run -p minimal start_attaches_pty_box_unless_detached 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal start_off_tty_exit2_names_detach 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-2 in box runtime-implement-test-2-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-3 in box runtime-implement-test-3-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-4 in box runtime-implement-test-4-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-5 in box runtime-implement-test-5-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-6 in box runtime-implement-test-6-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-7 in box runtime-implement-test-7-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-8 in box runtime-implement-test-8-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-9 in box runtime-implement-test-9-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

sion-core v0.4.33
    Checking sha3 v0.12.0
    Checking ring v0.17.14
    Checking compression-codecs v0.4.45
    Checking ratatui-core v0.1.2
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking ml-kem v0.3.2
    Checking heapless v0.9.3
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking ssh-key v0.7.0-rc.11
    Checking signal-hook-mio v0.2.5
    Checking generic-array v1.4.4
    Checking derive_more v2.1.1
    Checking russh-cryptovec v0.62.0
    Checking num-bigint v0.5.1
    Checking pem v4.0.0
    Checking op v0.0.1 (/workbench/crates/op)
    Checking yasna v0.6.0
    Checking russh-util v0.52.0
    Checking bitflags v1.3.2
    Checking tagptr v0.2.0
    Checking constcat v0.6.1
    Checking managed v0.8.0
    Checking hex-literal v1.1.0
    Checking hashbrown v0.14.5
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking russh v0.65.0
    Checking dashmap v6.2.1
    Checking smoltcp v0.14.0
    Checking moka v0.12.16
    Checking rcgen v0.14.10
    Checking crossterm v0.29.0
    Checking async-compression v0.4.50
    Checking async-tar v0.6.1
    Checking line-clipping v0.3.8
    Checking object v0.40.0
    Checking serde_bytes v0.11.19
    Checking is_executable v1.0.6
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking russh-sftp v2.4.0
    Checking clap_complete v4.6.11
    Checking check v0.0.1 (/workbench/crates/check)
    Checking ratatui-widgets v0.3.2
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking sysinfo v0.39.6
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking ratatui-macros v0.7.2
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking ratatui-crossterm v0.1.2
    Checking fuzzy-matcher v0.3.7
    Checking inquire v0.9.4
    Checking ratatui v0.30.2
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking vsock v0.5.4
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking vte v0.15.0
    Checking wait-timeout v0.2.1
    Checking quick-error v1.2.3
    Checking bit-vec v0.10.1
    Checking bit-set v0.11.1
    Checking rusty-fork v0.3.1
    Checking vt100 v0.16.2 (https://github.com/gominimal/vt100-rust.git?rev=9b8cce5a6798daf061948259ebcb073bb1ea54a6#9b8cce5a)
    Checking tokio-vsock v0.7.2
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking rand_xorshift v0.5.0
    Checking unarray v0.1.4
    Checking similar v2.7.0
    Checking core_detect v1.0.0
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking proptest v1.12.0
    Checking insta v1.49.0
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 39s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

min box start and min session start create a box from an entry, attach a terminal box, and refuse a held name with the holder named. This round changes only comments: the task-entry --name refusal now links #3196 with its removal condition, the unsupported-type refusal links #3197, and the run-path comment now says that a task-entry start is always a fresh instance named -.

Notes from the agent: Revise round 2, on the /revise note for arch ruling 1075. The note said to change no behaviour, so this round changes comments only (commit c102776). C1: #3196 is in the StartEntryRefusal::NameUnsupported doc comment and in the plan_start comment above the task --name arm, with the flip condition. C2: the run-path comment now names request_fresh_instance and - (BOX-163). C3: #3197 is in a comment on the UnsupportedType arm and in its doc comment. The runner must list #3196 and #3197 under the PR body's gaps. I cannot edit the PR body. cargo-nextest is not installed here, so I ran the ten test names in one cargo test -p minimal run. All ten passed. Its exit code was 101 because rustdoc is missing and the doctest step did not start. The first-round findings that ask for a behaviour change (egress per entry, TypeUnresolved for project types, exit 4 for Unknown and NotSession) and the C6 legacy [session] body are not in this round. The ruling kept only three conditions, and I had no filed issue number to name for C6.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 9, 2026 20:03
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The entry choice, the attach rule, --name on a session and the exit-2 refusals conform. The #3196 and #3197 interims are honest residuals. One gap is open: min session start <entry> does not create the typed entry's box. activate_box reads egress from the default or only session entry through pick_session_entry. So a typed entry can get a wider egress than it declares. The spec body comes from the legacy [session] table. Policy layers line 1284 makes the entry itself an expansion layer, and line 1294 makes the network default-deny. Make the change in C1, and expand or file the spec body in C2.

Ruled at c102776 against gominimal/arch@949521619eea by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@agent-137
agent-137 marked this pull request as ready for review November 9, 2026 20:15
@agent-137 agent-137 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on Karl's behalf, at c10277659. This is a comment, not an approval. Nothing was built for it: every point comes from reading the code, and each finding says how it was checked.

  • Head: c1027765.
  • CI at head: ci-success, ci-linux-native-success, ci-linux-kvm-success and ci-shell-installer-success are all green. e2e was IN_PROGRESS when fetched. arch-review FAILURE (CHANGES_REQUESTED, 2 conditions). minimal-review NEUTRAL.
  • Existing reviews:
    • minimal-arch: three rulings. The one at the head has C1 (egress from the wrong entry) and C2 (the spec body comes from the legacy [session]).
    • minimal-review at the head: 1 MEDIUM finding (the body/egress of the typed entry is ignored).
    • CodeRabbit: skipped as a bot user, so there is no review.
    • agent-137: /revise (round 2, comments only).

Plan task: covers BCLI-029, BCLI-071, BCLI-072 and BCLI-069. The code also implements --new (BCLI-070) for session entries, which the task does not cover. It is in the comments and has no test of its own (run_and_start_new_request_fresh_instance is not in this PR).

Requirement check

Req Implemented Test Notes
BCLI-029: attach a pty box unless --detach, else print the id yes (plan_start, create.rs:631) start_attaches_pty_box_unless_detached (plan level) ok
BCLI-029 sub: off a TTY, exit 2 naming --detach, nothing created yes start_off_tty_exit2_names_detach. It drives the whole command against a TestServer, but only when the test runs off a terminal ok
BCLI-029 sub: unattached start closes stdin, plus one hint yes for task entries unattached_start_closes_stdin_and_hints_run_logs_wait. It tests open_task_box_run/detach_run, not start_entry see should-fix 3
BCLI-069: --name session entries: yes. Task entries: refused with exit 2, as an interim for #3196. min box run/min task run --name: not done create_verbs_name_flag_overrides_box_name partial. The residual is #3196
BCLI-069 sub: held name gives exit 2, names the holder, hint names --new and --name session entries: yes. Task entries never refuse, because the run path always creates a fresh instance create_name_held_exit2_names_holder_hints_name_flag (unit level) partial (#3196)
BCLI-071 and its subs yes (session.rs pick_session_start_entry) the three session_start_without_entry_* tests see nit 2 for project types
BCLI-072 and its sub yes the two box_start_without_entry_* tests ok

Arch #166 vs spec vs PR (start/run flags)

  • Arch L452-L455 and L469 now give start and run these flags: --loadout, --no-loadouts, --no-hooks, --network, --ingress, one flag for each [network] key, and --deny-all-egress. They take no sync flag until arch#163, per the arch#161 owner ruling. The PR's BoxStartArgs/SessionStartArgs take only entry, --name, --new and --detach, and the start path uses ActivateArgs::unflagged(). That is within T10's scope, because BCLI-024 (--network/--ingress) and BCLI-073 (--loadout) belong to other tasks. Spec 28 is out of date:
    • The NEEDS CLARIFICATION at spec L603 still says "the architecture's grammar has no --no-hooks and no --sync" and that arch#161 decides. Arch#161 has ruled: --no-hooks is on every start and run, and there is no sync flag.
    • Spec 28 has no requirement for --no-hooks, --no-loadouts, the per-key network flags or --deny-all-egress on start/run. BCLI-024 names only --network and --ingress. Arch says "spec 28 lists the spellings".
    • Spec 28 needs those requirements before a later task can add the flags.

Should-fix

  1. create.rs:2596 → :1050: a typed min session start <entry> is refused when the file has several session entries and declares any network. activate_box calls project_egress(&utf8_path), and that calls pick_session_entry without the typed entry. Example: a minimal.toml with [sessions.api] (it declares [sessions.api.network]) and [sessions.web], and no default. plan_start picks api correctly. project_egress_from then gets NoDefault, and because declares_network is true it refuses with exit 2: "…None of them is named "default", so the start cannot pick one. Rename the entry to start to "default"…". The user named an entry, and the message tells them to rename it. A project-typed entry anywhere in a file that declares network fails the same way, through TypeUnresolved. This is the refusal side of arch C1. The arch ruling describes only the "wider egress" side. The fix is the same: pass options.entry into project_egress and pick that entry by name. Verified: read activate_box L2596, project_egress_from L1044-1056 and pick_session_entry L117-160. Not built.
  2. create.rs:2596 and :2434: the typed session entry gets another entry's egress and the legacy [session] body. Still open from minimal-arch (C1 and C2 at c102776) and from minimal-review (MEDIUM at create.rs:2440). This is a security boundary: min session start locked can run with [sessions.default]'s wider egress. Verified: the code is unchanged at the head.
  3. create.rs:587: the unattached-start hint names commands that do not exist at this head. It reads "…Run min box logs for its output, and min box wait for its exit code." At c102776, BoxCommand has no Logs and no Wait. AGENTS.md says "An instruction names a command the user can run as written." BCLI-029's sub-bullet requires this hint to name both verbs, so this PR must merge after #3195 (wait) and after whichever task ships min box logs, or the hint lies on main. Verified: listed the BoxCommand variants at refs/review/pr-3185.
  4. create.rs:587/779: the hint uses a <box> placeholder even though the id is known. run_entry → detach_run has just printed the box id on stdout, but the hint says min box logs <box> and min box wait <box>. AGENTS.md says "Fill in the value when the message knows it." Thread the id back from run_entry and print min box logs <id> and min box wait <id>. The test that pins the text is unattached_start_closes_stdin_and_hints_run_logs_wait. Verified: read the code.

Nit

  1. create.rs:442 / main.rs:283: an unknown entry exits 2, but arch says 4. Arch L365 makes 4 "Not found (entry, box, …)". minimal-arch raised this in round 1 (C4) and dropped it from later rulings. It is still unfixed at the head. Spec 28 has no requirement for the unknown-entry exit code, which is a spec gap. Either amend the spec or follow arch. Verified: read the code.
  2. create.rs:311 / session.rs:58: a session-rooted project type does not block the implicit default. builtin_root returns None for a project type, so with [boxes.dev] type = "mydev" (where mydev extends session), a bare min session start starts the implicit default next to the real session entry. minimal-arch raised this in round 1 (C2) and dropped it from later rulings. It is still unfixed at the head. Verified: read start_candidates and implicit_default_entry (mfile/src/entry.rs:112).
  3. create.rs:529: StartNeedsTerminal prints the entry raw. Every other start refusal passes the entry through printable(). Verified: read the code.
  4. Machine mode: StartEntryRefusal, StartNeedsTerminal and StartNameHeld have no arm in machine_mode_answer, so -o json reports code = "unspecified" for these usage refusals. Verified: read main.rs machine_mode_answer.

Verdict: needs changes. The open items are the security boundary (should-fix 1–2, arch C1/C2) and the hint's text. Merging is also blocked on the order: #3195 and the task that ships min box logs must land first.

@agent-137
Copy link
Copy Markdown
Member

/revise

Head c1027765. Arch ruling 1078 has two conditions. minimal-review and a reviewer pass found three more items.

1. C1: a typed session entry starts with its own egress.
In crates/minimal/src/cmd/boxes/create.rs, project_egress and project_egress_from take the start's entry as entry: Option<&str>:

  • When it is Some, project_egress_from uses the entry of that name from read_entries, and does not call pick_session_entry.
  • When it is None, today's pick stays.
  • activate_box passes options.entry.as_deref() at its project_egress(&utf8_path) call, and cmd_activate passes None. Fix the same miss at the other project_egress call (around create.rs:2596).

Add a test in crates/minimal/src/tests.rs:

  • [sessions.default] with [network.egress] allow_dns_hosts = ["example.com"], and [sessions.ci] with no network keys. Assert that the create request of min session start ci carries no example.com.
  • [sessions.a] and [sessions.b], each with a network key and with no default. Assert that min session start a goes through and is not refused with SessionEntryUndecided::NoDefault (exit 2).

2. C2: the typed entry's body is a residual, #3204.
Name #3204 in the doc comment of stamp_session_spec_as, with its flip condition: expand the typed entry's body into the spec through BOX-064's layers when box creation reads entries (#2418). List #3204 under the PR body's gaps. This answers thread PRRT_kwDOPdfcxM61a-0A too: reply there with #3204.

3. Thread PRRT_kwDOPdfcxM61Xj2k: --name and --new on a task entry.
That is the #3196 residual. Make sure plan_start refuses --name for a task entry (NameUnsupported, already linked to #3196), and does not drop it silently. Reply on the thread with the commit, or with the existing refusal and #3196.

4. The hint names the box by its id.
Where the hint after a detached or task start prints a <box> placeholder, print the box id that the create returned.

5. Merge order.
The hint names min box logs and min box wait. Those arrive in #3184 (T36) and #3195 (T8), so this PR merges after them. Add one line saying so in the PR body. Do not change the hint for it.

A typed dev is now refused until #3204, so the off-terminal test
reaches the terminal refusal through a bare start of the sole entry.
StartNameHeld printed the entry, the held name and the holder's name
raw. A name with control characters can no longer move the cursor.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 10 of 10 on a review requesting changes, pushed as 22b3ffa7b833.

line exit tail
cargo nextest run -p minimal start_attaches_pty_box_unless_detached 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal start_off_tty_exit2_names_detach 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-2 in box runtime-implement-test-2-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-3 in box runtime-implement-test-3-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-4 in box runtime-implement-test-4-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-5 in box runtime-implement-test-5-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-6 in box runtime-implement-test-6-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-7 in box runtime-implement-test-7-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-8 in box runtime-implement-test-8-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-9 in box runtime-implement-test-9-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 28s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Outside the task's layers::

  • crates/minimal/src/task.rs
  • docs/reference/cli-min.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

1 thread was already answered in earlier rounds, with nothing new on it since.

min box start and min session start create a box from an entry and attach a terminal box. They refuse a held name and name the holder, and that refusal now escapes every name it prints. Until #3204 lands, a typed session entry other than default is refused with exit 2 before anything is created. A typed default and a bare start of the only session entry still start.

Notes from the agent: Finding 2: plan_start now refuses a typed session entry not named default for both verbs. The new StartEntryRefusal::NamedSessionUnsupported exits 2, and its doc comment links #3204 with the flip condition. It prints: "Cannot start . cannot start a session entry by name yet, except the entry named "default". Rename to "default" in minimal.toml, then run ." A bare start that picks the only session entry (for example a sole [sessions.dev]) is not refused, because BCLI-071 requires that pick. That box has the same #3204 gap: its spec names the entry, but its body comes from [session]. The reviewer asked only for the typed case, so the asymmetry is deliberate. If the bare pick must be refused too, BCLI-071's 'else the sole' half fails until #3204. session_start_typed_entry_reads_its_own_egress now checks the egress of a named entry through project_egress directly, plus a bare start of a sole entry. start_off_tty_exit2_names_detach now starts the sole dev entry bare, not typed. Finding 4: session_start_without_entry_blocked_default_exit2_names_fix now runs plan_start, not only the pickers, for [sessions.default] beside [boxes.dev] type = "mydev" (both verbs) and for min box start build on [tasks.build]. Finding 3 / merge order: #3195 is still open, so this PR must stay unmerged until min box wait exists. Outside the layers: docs/reference/cli-min.md gains one refusal row, in the section an earlier round added (347720b). Environment: cargo-nextest, just, python3 and rustdoc are not installed on this box. I ran each test l…[truncated]

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 10, 2026 00:43
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 3 conditions · the full ruling

The start conforms to the design with four filed interims open. This head adds one more: a typed session entry other than default is refused with exit 2 until #3204 (C1). Line 453 of architecture.md gives min session start [<entry>] any session entry. The refusal fails closed and names its issue, so it can merge as an interim. --name on the run verbs stays with #3196 (C2). The agent, service, user-defined and [boxes] task starts stay with #3197 and #3213 (C3).

Ruled at 22b3ffa against gominimal/arch@9e2ff817adba by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cli.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@agent-137 agent-137 removed the needs-human An agent handed off; a human must act, then clear this label. Set by defer and handoffs. label Nov 10, 2026
@agent-137
Copy link
Copy Markdown
Member

/review

@agent-137
agent-137 marked this pull request as ready for review November 10, 2026 01:17
@agent-137
Copy link
Copy Markdown
Member

Undrafted by the BCLI babysitter after round 10, under the owner's standing rules: the only draft causes are the requested out-of-layers files and the runtime's nextest-missing test lines. @bryan-minimal, rounds 9 and 10 refuse a typed session entry other than default until #3204, as your finding 2 asked. This PR merges after #3195.

@bryan-minimal bryan-minimal left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read at 22b3ffa. Both points from my last pass are answered:

  • Finding 2: d1224b9 refuses a typed session entry other than default with NamedSessionUnsupported, exit 2, named as the #3204 interim in the code and in cli-min.md, and start_typed_session_entry_other_than_default_exit2_until_its_body_applies pins it. That is the refusal-with-a-filed-issue I asked for.
  • Finding 4 stays answered by 9a0fd24 (the refusal lives in the pickers, not ahead of every start).
  • min box wait: #3195 is approved; this PR's hint names it, so #3195 merges first and this one follows.

Approving, on that merge order.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 39 unresolved threads — minimal-foundry[bot] crates/minimal/src/cmd/boxes/create.rs:822, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:914, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs, minimal-arch[bot] crates/minimal/src/cmd/session.rs:111, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:813, …. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

…x-from-its-entry

# Conflicts:
#	crates/minimal/src/main.rs
#	crates/minimal/src/task.rs
min box wait is on main now, so the comment's claim that this branch
lacks it is false.
…x-from-its-entry

# Conflicts:
#	crates/minimal/src/cli.rs
#	crates/minimal/src/cmd/boxes/create.rs
#	crates/minimal/src/main.rs
#	crates/minimal/src/task.rs
The merge of main added network and egress to RunEntry. The task start
of min box start takes no network flags, so it passes none.
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs, minimal-arch[bot] crates/minimal/src/cmd/boxes/create.rs:705. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 4 conditions · the full ruling

The compare is two merges of main and two small commits, and it conforms. A task start through min box start now passes no network override, so the entry's own [network] applies. Section Policy layers line 1286 asks for that. The four start interims do not change. C1–C4 stay open as filed residuals #3196, #3197, #3204 and #3213, with #3212 for --name on the run verbs.

Ruled at 5ab4150 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
Comment thread crates/minimal/src/cmd/boxes/create.rs Resolved
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

A merge of main before round 1, not counted against the cap (1 of 3), pushed as 5ab41501f536.

Resolved conflicts in: crates/minimal/src/cli.rs, crates/minimal/src/cmd/boxes/create.rs, crates/minimal/src/main.rs, crates/minimal/src/task.rs

line exit tail
cargo nextest run -p minimal start_attaches_pty_box_unless_detached 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-0 in box runtime-implement-test-0-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal start_off_tty_exit2_names_detach 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-1 in box runtime-implement-test-1-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal unattached_start_closes_stdin_and_hints_run_logs_wait 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-2 in box runtime-implement-test-2-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_verbs_name_flag_overrides_box_name 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-3 in box runtime-implement-test-3-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal create_name_held_exit2_names_holder_hints_name_flag 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-4 in box runtime-implement-test-4-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-5 in box runtime-implement-test-5-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-6 in box runtime-implement-test-6-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal session_start_without_entry_blocked_default_exit2_names_fix 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-7 in box runtime-implement-test-7-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_picks_default_else_sole 101 warning: unknown fields in [defaults] section of minimal.toml: task,session help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-8 in box runtime-implement-test-8-1... error: no such command: 'nextest' help: a command with a simil
cargo nextest run -p minimal box_start_without_entry_ambiguous_exit2_lists_entries 101 warning: unknown fields in [defaults] section of minimal.toml: session,task help: do you need to update to a newer version of minimal? Applying loadouts: default Running task runtime-implement-test-9 in box runtime-implement-test-9-1... error: no such command: 'nextest' help: a command with a simil

Verify min task run agent-verify exited 101 under rustc 1.99.0, which the repository does not pin (1.99.1 in rust-toolchain.toml); the PR is not a draft on that alone — CI, which honours the pin, is the gate.

the sandbox ran rustc (1.99.0), the repository pins 1.99.1 in rust-toolchain.toml; a failure here may be the newer toolchain's, not this change's
warning: unknown fields in [defaults] section of minimal.toml: session,task
help: do you need to update to a newer version of minimal?
Applying loadouts: default
Running task runtime-implement-verify in box runtime-implement-verify-1...
    Checking paths v0.0.1 (/workbench/crates/paths)
    Checking args v0.0.1 (/workbench/crates/args)
    Checking ot v0.0.1 (/workbench/crates/ot)
    Checking client-config v0.0.1 (/workbench/crates/client-config)
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
    Checking bep v0.0.1 (/workbench/crates/bep)
    Checking common v0.0.1 (/workbench/crates/common)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking switch v0.0.1 (/workbench/crates/switch)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Finished `dev` profile [unoptimized] target(s) in 1m 24s
error: no such command: `nextest`

help: a command with a similar name exists: `test`

help: view all installed commands with `cargo --list`
help: find a package to install `nextest` with `cargo search cargo-nextest`

Outside the task's layers::

  • crates/minimal/src/task.rs
  • docs/reference/cli-min.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

A person can run min box start or min session start. A terminal entry attaches unless --detach is given. Off a terminal, the start refuses with exit 2 and names --detach. An entry with no terminal returns with a hint that names min box run, min box logs and min box wait , and all three commands exist on this branch now.

Notes from the agent: Merge round: main.rs conflicted only in the failure_exit_code doc comment. The resolution keeps both the start refusals and the BoxTimedOut line from main. task.rs conflicted on the box run return: the resolution uses main's run_outcome (timeout aware) and keeps this branch's .map(|()| id). After the merge, I removed the four-line comment above unattached_start_hint in create.rs, because min box wait (#3195) is on main now. cargo-nextest is not installed on this box (cargo reports 'no such command: nextest'). So each test line ran as cargo test -p minimal , and all passed. cargo clippy -p minimal --all-targets is clean.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 10, 2026 03:57
@agent-137
agent-137 marked this pull request as ready for review November 10, 2026 04:15
@agent-137
Copy link
Copy Markdown
Member

Undrafted by the BCLI babysitter after the runtime's merge of main. The only draft causes are covered by the owner's standing rules: the runtime's nextest-missing test lines, plus, on #3185, out-of-layers files that a round asked for.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @agent-137 closed the last one. The review of 5ab41501f536 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 10, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 29c349f Nov 10, 2026
38 checks passed
@agent-137
agent-137 deleted the agent/2898-start-a-box-from-its-entry branch November 10, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T10 — Start a box from its entry

3 participants

0