8000 T100 — Stage bep beside minvmd in the macOS release and install it by minimal-foundry[bot] · Pull Request #2810 · gominimal/minimal · GitHub
[go: up one dir, main page]
Skip to content

T100 — Stage bep beside minvmd in the macOS release and install it - #2810

Merged
norrietaylor merged 1 commit into
mainfrom
agent/2771-stage-bep-beside-minvmd-in-the-macos-release-and
Nov 1, 2026
Merged

T100 — Stage bep beside minvmd in the macOS release and install it#2810
norrietaylor merged 1 commit into
mainfrom
agent/2771-stage-bep-beside-minvmd-in-the-macos-release-and

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Oct 31, 2026
Copy link
Copy Markdown
Contributor

T100 — Stage bep beside minvmd in the macOS release and install it

slice: S14
kind: enablement
covers: none
size: S
est: 30 code, 160 tests
executor: agent
difficulty: routine
model: standard
diagnostics: the installer prints bep in its component list beside minvmd on a macOS install
observability: none: the stager and the installer are shell scripts that write no log
layers:
- stage:
- scripts/stage-release.sh: a darwin row "bep|darwin|arm64|file|bin/bep|bep-macos-arm64" beside the minvmd row, so the installer puts bep where minvmd resolves it (#2498)
- scripts/stage-release_test.sh: the darwin manifest carries the bep row
- scripts/install_test.sh: a mock bep-macos-arm64 in the darwin release, and a case that finds bin/bep beside bin/minvmd after install and gone after uninstall
test: just test-installer bep_installs_beside_minvmd
produces: none
consumes: none
proof: A macOS install from a release puts bep beside minvmd, and an uninstall removes it.
depends on:
- blocked by #2770

Proof

A macOS install from a release manifest puts bin/bep beside bin/minvmd, and min's --uninstall removes both. The installer case and the stager test now both check this.

Notes from the agent: The darwin bep row in scripts/stage-release.sh and most of case_bep_installs_beside_minvmd were already on the branch from #2792 (e0fb640), so stage-release.sh needed no change. This task added the missing pieces: the uninstall half of the installer case, and a stage-release_test.sh check that the darwin manifest carries the bep row at bin/bep beside bin/minvmd and that Linux has none. bash scripts/stage-release_test.sh: 71 passed. Full SH=sh scripts/install_test.sh: 932 passed. dash is not installed here, so the recipe skipped the dash run.

Tests

line exit tail
just test-installer bep_installs_beside_minvmd 0 == shellcheck --shell=sh == == running install_test.sh under sh == # install.sh tests (SH=sh) ok - the release stages bep for darwin/arm64 at bin/bep ok - the release stages minvmd for darwin/arm64 at bin/minvmd ok - the release stages no bep for Linux ok - darwin install with the bep row ex

Verify

min task run agent-verify passed ([tasks.verify]).

Closes #2771

@minimal-foundry
test(release): pin the darwin bep row and its uninstall
a1c9055 
The stager test checks the darwin manifest installs bep-macos-arm64 at
bin/bep beside bin/minvmd. The installer case now uninstalls and checks
that bep is gone.

Refs #2498
@minimal-foundry
minimal-foundry Bot requested a review from a team as a code owner October 31, 2026 18:31
@minimal-foundry minimal-foundry Bot mentioned this pull request Oct 31, 2026
Closed
@coderabbitai
coderabbitai Bot commented Oct 31, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f040259-0713-4657-bf3b-27219e174985

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry minimal-foundry Bot mentioned this pull request Oct 31, 2026
Open
@minimal-foundry
minimal-foundry Bot commented Oct 31, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

Approved: no findings at a1c905566686.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none.

minimal-arch[bot]
minimal-arch Bot approved these changes Oct 31, 2026
View reviewed changes
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This change adds test cases only. The installer test now proves that a macOS uninstall removes bin/bep and bin/minvmd. The stager test proves that the darwin manifest has bep at bin/bep and that Linux has no bep row. The design of record does not state an installer layout or uninstall behaviour, so this is a PASS by absence. No condition applies.

Ruled at a1c9055 against gominimal/arch@8640f85e193d by claude-opus-5-5.

minimal-foundry[bot]
minimal-foundry Bot commented Oct 31, 2026
View reviewed changes
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Oct 31, 2026
norrietaylor
norrietaylor approved these changes Oct 31, 2026
View reviewed changes
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at a1c9055. Tests only:

  • stage-release_test.sh pins the darwin manifest row from #2792. It installs bep-macos-arm64 at bin/bep beside bin/minvmd, with no linux row.
  • case_bep_installs_beside_minvmd now also checks that --uninstall removes bin/bep and bin/minvmd.

@norrietaylor
norrietaylor added this pull request to the merge queue Oct 31, 2026
@norrietaylor norrietaylor mentioned this pull request Nov 1, 2026
Merged
Merged via the queue into main with commit 75582af Nov 1, 2026
38 checks passed
@norrietaylor
norrietaylor deleted the agent/2771-stage-bep-be 8C18 side-minvmd-in-the-macos-release-and branch November 1, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes
+1 more reviewer
@minimal-arch minimal-arch[bot] minimal-arch[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review:approved minimal-review approved the current head

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

T100 — Stage bep beside minvmd in the macOS release and install it

1 participant

@norrietaylor
0