Repository navigation
fix(minimal): flush the macOS system resolver cache in the finalize-install scripts - #2306
Conversation
min finalize-install writes /etc/resolver/min.internal but its install and undo scripts never ask configd or mDNSResponder to re-read the resolver configuration or drop the cached answers, so pickup depends on the system noticing the file on its own schedule and a negative answer cached before the file existed survives until reboot. Both scripts now end with dscacheutil -flushcache and a HUP of mDNSResponder, each tolerant of the tool being absent so the undo script still succeeds on a host without them. The undo script flushes after the resolver file is gone so its cached answers do not outlive it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[inbox-patch:clobber] This PR would revert recently merged workSimulating this merge shows it undoing commits that landed on the base branch within the last 3 day(s):
Before merging, restore the reverted region to its state on the base branch. The rest of this PR is unaffected. If a listed commit is one this PR intends to supersede, say so and merge — this check reports, it does not block. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title uses the required Conventional Commit format and clearly describes the macOS resolver-cache change. |
| Description check | |
The description explains the change, motivation, testing performed, known pre-existing failure, and E2E status. It omits the template's Checklist section and uses What and Verification instead of Summ… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
The description explains the change, motivation, testing performed, known pre-existing failure, and E2E status. It omits the template's Checklist section and uses What and Verification instead of Summary and Testing, but the required information is substantially present.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the resolver’s trail
Cache commands hop in after setup
Then HUP taps softly at the door
Undo clears the path once more
Tests watch each step in place
The rabbit bounds away with grace
Comment @coderabbitai help to get the list of available commands.
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
There was a problem hiding this comment.
Approved on ARCH PASS at 528f161.
…olver-flush-6c42c90469a5af5f
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABX3vSQg
What
min finalize-installwrites/etc/resolver/min.internalon macOS, but the install and undo scripts it emits never ask configd or mDNSResponder to re-read the resolver configuration or drop cached answers: pickup depends on the system noticing the file on its own schedule, and a negative answer cached before the file existed survives until reboot.Both scripts now end with
dscacheutil -flushcacheand a HUP ofmDNSResponder, each line tolerant of the tool being absent so the undo script still succeeds on a host without them (set -euand all). The undo script flushes after the resolver file is gone, so its cached answers do not outlive it.Verification
cargo fmt --all --check— cleancargo clippy --workspace --all-targets --locked -- -D warnings— cleancargo test --locked -p minimal— 524 passed, 1 pre-existing failure (legacy_network_spellings_parse_with_hint, a CLI network-flag hint test unrelated to resolver code; it fails identically on unmodifiedmain, confirmed by stashing this change and re-running it)cargo test --locked -p minimal --lib resolver— 83 passed, including the newmacos_scripts_flush_the_system_resolver_cachetestlive-session: macos e2e (.github/workflows/ci-macos.yml) — runs on this PR; not runnable in the fixer sandbox.
Summary by CodeRabbit