Repository navigation
fix(scripts): drop the nfpm pin that the 0.7.0 merge-back removed - #2243
Merged
Merged
Conversation
#2214 deleted vendor/nfpm when the release dropped distro packages, and the merge-back brought that into main. #1875 then merged a pin table that still listed vendor/nfpm/nfpm.lock, so the real-tree check in the deps-freshness harness fails with "pin unreadable" and reds ci-linux-native on main. Drop the nfpm row and its fixture lines.
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 34 minutes for your next included review. View limit details
Comment |
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
nfpmrow from the pin table inscripts/deps-freshness.sh, and the matching fixturelines in
scripts/deps-freshness_test.sh.Why
Main is red.
all_script_test_harnesses_passfails inci-linux-nativewith:#2214 deleted
vendor/nfpm/when the 0.7.0release dropped distro packages, and #2239
merged that into main. #1875 merged after it
with a pin table that still lists
vendor/nfpm/nfpm.lock, so the harness's real-tree checkcannot read the pin. No other file on main refers to nfpm.
Verification
just test-shell: every harness passes;deps-freshness_test.shreports22 passed, 0 failed,including "the real tree's duplicated pins agree, its pins resolve, its locks are listed".
just lint-shell: 46 scripts pass shellcheck.