Repository navigation
fix(sessions): reword the credentialed-upstream policy row and ingress errors - #2180
Merged
norrietaylor merged 2 commits intoOct 12, 2026
Merged
Conversation
…rors
The credentialed-upstream lane row described itself as
"box egress proxy listener", which names the mechanism rather
than what the lane grants. Ingress validation errors printed
the protocol with Rust debug formatting ("Tcp") and referred
to "gvproxy's static forwarder", which a user cannot act on.
Reword the row to "allowed to reach the Box Egress Proxy" and
the errors to plain statements of what is wrong and what is
supported ("only tcp and udp are supported"). Update the
pinned expectations in sessions, minimal, and minimal-tui
(including the regenerated TUI snapshot) and the two cli-min
reference examples that quote the row.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 5de03f4)
Pin the two ingress port-mapping error sentences, so the lowercase protocol name stays the one a user types in --ingress. Name the proxy in the cli-min prose the way the policy row above it does. (cherry picked from commit 93baffe)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
norrietaylor
added a commit
that referenced
this pull request
Oct 15, 2026
…s errors (#2180) * fix(sessions): reword credentialed-upstream policy row and ingress errors The credentialed-upstream lane row described itself as "box egress proxy listener", which names the mechanism rather than what the lane grants. Ingress validation errors printed the protocol with Rust debug formatting ("Tcp") and referred to "gvproxy's static forwarder", which a user cannot act on. Reword the row to "allowed to reach the Box Egress Proxy" and the errors to plain statements of what is wrong and what is supported ("only tcp and udp are supported"). Update the pinned expectations in sessions, minimal, and minimal-tui (including the regenerated TUI snapshot) and the two cli-min reference examples that quote the row. (cherry picked from commit 5de03f4) * test(sessions): pin the reworded ingress mapping errors Pin the two ingress port-mapping error sentences, so the lowercase protocol name stays the one a user types in --ingress. Name the proxy in the cli-min prose the way the policy row above it does. (cherry picked from commit 93baffe) --------- (cherry picked from commit c888a3e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two commits of #2177, rebuilt on top of
release/0.7.0.#2177 was opened against main and is based on main's tip, so retargeting it would carry main-only commits into the release branch. This PR carries only its two commits, cherry-picked from 5de03f4 and 93baffe with their original author.
What changes
credentialed upstreamrow ofmin session policyand themin dashdetail pane now readsallowed to reach the Box Egress Proxy.No behaviour, flag, JSON field or exit code changes.
Test plan