Repository navigation
fix(minimal): say DNS, min.internal and box IPs plainly in finalize-install --show - #2166
Conversation
…nstall --show Reword the names item of 'min finalize-install --show' into the vocabulary a reader already has. The item now says DNS, names <box>.min.internal as the box DNS namespace, names 127.0.64.0/24 as the loopback IPs boxes use (macOS only), splits its missing pieces into short list lines, and drops the internal terms (unit labels, zone, answerer, stub resolver, hook, service manager) from the reader-facing text; 'the command below' becomes 'this step'. Those internal terms remain in '--show --script' and the diagnostic surfaces, which name real files and units. The missing facts become a Vec of short lines; the '; '-joined prose note stays on the cfg(test) advisory path that renders it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change revises DNS setup wording and presentation. The reported legacy test failure is said to occur on clean main, and no PR-specific user impact is established. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 90.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 4 files. (1 skipped: 1 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly describes the main change: plain DNS, min.internal, and box IP wording in finalize-install --show. |
| Description check | |
The description provides a detailed summary, explains the motivation, lists verification commands and results, and documents known test coverage limits. It does not use the template's exact Summary, T… |
✨ Finishing Touches
-
-
-
-
-
-
-
📝 Generate docstrings
-
-
-
-
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
-
-
-
🧪 Generate unit tests (beta)
-
-
-
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
-
-
-
-
-
-
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the DNS trail,
Then hops where box names gently sail.
Loopback IPs line up in rows,
A counted list explains what’s close.
The burrow hums; the names resolve.
Comment @coderabbitai help to get the list of available commands.
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none: |
…ll --show --json The names item's today field is one line of facts again; the count heading, bullets and indentation are the summary's alone. The heading reads "N things to fix", the Linux step joins the service clause with "and", the range facts drop "one per box", and the refused-source fact no longer names the advisory. Tests pin both platform arms of the step text, the two-fact list and the JSON.
|
/review |
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABWekcxQ
What was wrong. The names item of
min finalize-install --showread in the project's internal vocabulary: "box names for every host program", "box-zone answerer", "reserved local range", "the command below" — terms a reader meeting the install for the first time has no referent for.What changed. The item now says DNS: the label is "DNS names for boxes ((box).min.internal) in every program on this machine"; the missing pieces are short list lines in the summary ("N things to fix:" with one
-fact each;--show --jsonkeepstodayas one line of facts, with no layout in it); the range is "the loopback IPs boxes use (127.0.64.0/24)"; and the step text names what it does plainly. Internal terms (unit labels, zone, answerer, stub resolver, hook, service manager) stay in--show --scriptand the diagnostic surfaces, which name real files and units. The label is one constant shared by both platforms, hence "this machine" rather than the issue's proposed "on this Mac"; the Linux step names systemd-resolved.NamesVerdict::Missing.factsis now aVec<String>of short lines; the"; "-joined prose note stays on the cfg(test) advisory path that renders it.ANSWERER_UNIT_LABEL, orphaned by the rewording, is removed. No docs quote the changed wording (docs/reference/cli-min.md and spec 18 checked), so no doc changes were needed.Verification
cargo fmt --all --manifest-path target/Cargo.tomlthencargo fmt --all --check— cleancargo clippy --workspace --all-targets --locked --manifest-path target/Cargo.toml -- -D warnings— cleanjust test-one "" -p minimalon Linux — 532 passed, 0 failed. The macOS arm of the step text is asserted by tests that only the CI lanes compile.Informed by #546 and #487 (prior naming-rewording precedents).
Not covered
cfg!(target_os), and its macOS arm executes on no lane: the macOS lane tests onlyminvmdandsessions, and the cross build compiles this crate's tests for Linux. The macOS string was checked by hand againstRESERVED_LOCAL_RANGE.Summary by CodeRabbit