Repository navigation
fix(op): fall back to the remote cache for patched-build dependencies - #2054
Merged
norrietaylor merged 5 commits intoOct 7, 2026
Merged
norrietaylor merged 5 commits into
norrietaylor merged 5 commits into
Conversation
patched-build resolved every dependency only from the local cache and reported a missing dependency with no remote-cache fallback. Give PatchedBuild an optional remote cache: keep local by-name/spec-hash resolution first, then materialize a miss from the remote cache before reporting it missing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25. Or wait 13 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The EnvChannel patched-pkg path still handed PatchedBuild no remote cache, so it kept the local-only behaviour this PR removes for mip and minimald. Honour use_remote_cache() there too.
Member
|
/review |
Contributor
|
Approved: no findings at Nothing to do. Clobber: none: |
…ence A dependency absent from the remote cache is an expected miss already named in the final error, so only warn on real fetch failures. Assert that a remote-resolved dependency lands in the local cache as fetched, and test that local builds win over remote-cache entries.
Member
|
/review |
A dependency the remote index lists but that cannot be fetched or verified is not absent, so name it under its own 'could not fetch' clause with the error instead of folding it into 'could not find'.
Member
|
/review |
norrietaylor
approved these changes
Oct 7, 2026
norrietaylor
deleted the
inbox-patch/fix/patched-build-remote-cache-77515450608e5276
branch
October 7, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABVcZQJQ
patched-build resolved every dependency only from the local cache and reported a missing dependency with no remote-cache fallback. This gives
op::PatchedBuildan optional remote cache: local resolution (by name, then by spec hash) still wins, and only a miss in both local caches falls through toRemoteCache::materializebefore the dependency is reported missing.Callers (
mip,minimald) pass their context's remote cache whenuse_remote_cache()is enabled, honoring the opt-out. The error text now says where to look.Verification
cargo fmt --all --check— passedcargo clippy --workspace --all-targets --locked -- -D warnings— passedcargo test --locked -p op— 35 passedcargo test --locked -p mip— 12 passedcargo test --locked -p minimald— 857 passed; 11 pre-existing failures in privileged network-namespace tests (net::switch, rpc name-surface binding), unrelated to this changeSummary by CodeRabbit