Repository navigation
chore: install agent contract and chore workflows - #185
Closed
norrietaylor wants to merge 1 commit into
Closed
norrietaylor wants to merge 1 commit into
norrietaylor wants to merge 1 commit into
Conversation
Installed by scripts/quick-setup.sh from gominimal/min-aw@v0.2.1.
Contributor
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughIntroduces GitHub repository governance infrastructure including issue templates for bugs, features, chores, and feedback; a labels configuration file; agent contract documentation; copilot instructions; and GitHub Actions workflows for workflow synchronization and worker-fix operations. ChangesRepository Governance and Automation Infrastructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
Author
|
@CodeRabbit review |
Contributor
✅ Actions performedReview triggered.
|
5 tasks
This was referenced Sep 23, 2026
bryan-minimal
added a commit
that referenced
this pull request
Oct 19, 2026
…edentials by reference Five review findings on the SBOM spec. Context says how a component is decided referenced until build-servers#185 pins the document digest: by the closure entry alone (an artifact digest references the document named from the Build Spec Hash; `built-locally` and `non-redistributable` are the gap), with no cache probe, so SBOM-001 holds and a missing document for a cached artifact is SBOM-012's failure. SBOM-013 fixes the order of checks (bundle, subject, then the rest), requires every serializer to emit the `unverified` mark so a reader never takes unbundled data for verified, and adds `--require-bundles` to fail on an absent bundle; whether that becomes the default after #185 is an open question. SBOM-008 covers every credential-bearing posture field by reference, not only variable values. The two security invariants are reworded to match.
bryan-minimal
added a commit
that referenced
this pull request
Oct 19, 2026
Arch review conditions on SBOM-013. C1: the interim is no longer a default that waits on a flag. When the pin records a bundle for a per-package document (its state in the sealed map), the bundle is verified before any read and a failed or missing bundle is SBOM-012's failure; while the pin records no bundle (build-servers#185 has not published one), the document is read, the component is marked `unverified`, and one stderr diagnostic per emission names each such component and #185. The pin decides, so SBOM-001 holds and the interim ends by itself at the first pin that records bundles; the open question on a default flip is gone. `--require-bundles` stays as the strict side. C2: a subject-digest mismatch, a failed bundle check and SBOM-012's failure all exit with code 6, as the exit-code table says.
bryan-minimal
added a commit
that referenced
this pull request
Oct 19, 2026
…edentials by reference Five review findings on the SBOM spec. Context says how a component is decided referenced until build-servers#185 pins the document digest: by the closure entry alone (an artifact digest references the document named from the Build Spec Hash; `built-locally` and `non-redistributable` are the gap), with no cache probe, so SBOM-001 holds and a missing document for a cached artifact is SBOM-012's failure. SBOM-013 fixes the order of checks (bundle, subject, then the rest), requires every serializer to emit the `unverified` mark so a reader never takes unbundled data for verified, and adds `--require-bundles` to fail on an absent bundle; whether that becomes the default after #185 is an open question. SBOM-008 covers every credential-bearing posture field by reference, not only variable values. The two security invariants are reworded to match.
bryan-minimal
added a commit
that referenced
this pull request
Oct 19, 2026
Arch review conditions on SBOM-013. C1: the interim is no longer a default that waits on a flag. When the pin records a bundle for a per-package document (its state in the sealed map), the bundle is verified before any read and a failed or missing bundle is SBOM-012's failure; while the pin records no bundle (build-servers#185 has not published one), the document is read, the component is marked `unverified`, and one stderr diagnostic per emission names each such component and #185. The pin decides, so SBOM-001 holds and the interim ends by itself at the first pin that records bundles; the open question on a default flip is gone. `--require-bundles` stays as the strict side. C2: a subject-digest mismatch, a failed bundle check and SBOM-012's failure all exit with code 6, as the exit-code table says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed by scripts/quick-setup.sh from gominimal/min-aw@v0.2.1.
Summary by CodeRabbit
Documentation
Chores