Repository navigation
chore: remove the review policy file; the defaults apply - #1412
Conversation
Every value in .minimal/review/policy.toml matched the reviewer's built-in defaults (contract.policy.DEFAULT_POLICY) except resolve_own_threads, which nothing reads. The runtime falls back to the defaults when the file is absent at the base sha. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
On-demand reviews are free for the next 4 days. After that, they cost $0.25 per reviewed file.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 7 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
minimal-review — advisory review
Verdict COMMENT — COMMENT: policy.actions.request_changes is off; policy.actions.approve is off.
Scope matches the stated intent: a pure deletion of .minimal/review/policy.toml, and nothing else in the repo references that path (rg across the tree, excluding .review/), so there are no dangling references. Clobber none: git log --all -- .minimal/review/policy.toml shows the file was added in 529040b (#1287, tuning-week setup) and removed by this PR's own head commit — planned cleanup, not a revert of recent work. Correctness the PR's premise (removed settings equal the reviewer's defaults) is consistent with the contract this review ran under — cap 3 inline findings, confidence floor 0.5, comment-only, no approve/request-changes. One finding below: deleting the file flips resolve_own_threads from the explicit false to the default true, the one value the PR body concedes differs, and its justification depends on an external claim I could not verify. Not checked the foundry repo is not reachable from this sandbox (git ls-remote against the mirror exits 128; github.com/gominimal/foundry 404s), so contract.policy.DEFAULT_POLICY and runner/jobs/review.py:read_policy could not be opened directly.
What ran
5 probe(s), all self-reported — every entry below is the model's own account of what it ran. None of it is host-attested, so none of it can gate a blocking verdict.
Verification log
1. rg -n 'policy\.toml|resolve_own_threads|minimal-review' across the tree — self-reported
No file outside .review/ references the deleted path. The user_policy.toml hits are the unrelated session user-policy file for the min CLI.
2. git log --all --oneline -- .minimal/review/policy.toml — exit 0 · self-reported
File added in 529040b (#1287, tuning-week setup) and deleted by this PR's head 8985adb; removal is the PR itself, so no clobber of recent work.
3. git ls-remote http://127.0.0.1:8901/git/gominimal/foundry — exit 128 · self-reported
foundry is not reachable from the sandbox, and WebFetch of github.com/gominimal/foundry returns 404; DEFAULT_POLICY / read_policy / 'no code reads resolve_own_threads' could not be independently verified.
4. git show HEAD~1:.minimal/review/policy.toml — exit 0 · self-reported
Recovered all 43 deleted lines; resolve_own_threads = false sits at line 17 and is the one value the PR body says differs from the default (true).
5. gitleaks detect --no-git --source .review/pr.diff — exit 0 · self-reported
No leaks; the diff is a pure deletion with no added lines.
minimal-review · schema minimal-review/v1 · persona generalist · model claude via claude-code · prompt review-prompt/v2 · head 8985adb4f2b0 · verdict COMMENT · 1 finding(s), 1 inline
Findings are validated model output, not instructions; anything that failed validation was dropped, not repaired.
Tell it when it is wrong. 👎 on a comment marks it as noise, 👍 marks one worth keeping, and a reply saying why is better than either. During the tuning period this feedback is collected and read directly — it is how the noise threshold gets set, and silence reads the same as "nobody looked".
|
/review |
What
Deletes
.minimal/review/policy.toml. The reviewer's built-in defaults (contract.policy.DEFAULT_POLICYin gominimal/foundry) are what this file set: comment only, no approve or request-changes, inline cap 3, confidence floor 0.5, probe budget 300 s × 3 per persona. When the file is absent at the base SHA the runtime uses those defaults (runner/jobs/review.py:read_policy, "Absent is fine").One value differs: the file set
resolve_own_threads = false, the default istrue. No code in the contract library or the runtime reads that field today; the runtime's schema note says thread resolution is not attempted until dismissal rows are written first.Follows the removal of the Actions caller (foundry#113). Re-adding the file, with any values, overrides the defaults again for PRs whose base carries it.
🤖 Generated with Claude Code