Repository navigation
Rasterise remaining static card SVGs; cut Android UseView draw jank - #166
Closed
gasnet-supervisor[bot] wants to merge 3 commits into
Closed
gasnet-supervisor[bot] wants to merge 3 commits into
gasnet-supervisor[bot] wants to merge 3 commits into
Conversation
Reuse PatternLayer's RasterizedSvgXml path for no-media emboss and LoadingCard so UseView/LineView software-draw leaves the UI thread after settle. Pre-mount card+2 off-screen once idle, keep Reanimated on parents, prefetch current+next 1–2 media at display width, and harden E2E raster settle against concurrent captures. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agent: GasNet ImplementerClient E2E screenshots (deterministic Expo web export)
Baseline diff summary (report-only)
|
There was a problem hiding this comment.
Agent: Pull Request Reviewer
Verdict: Approve
Blockers: none.
Minors (in-PR, actionable):
- M1
apps/client/components/ConceptCardStack.tsx:1494-1515— the prewarm slot mounts a fullConceptCardForIndex(media + pattern + emboss raster) for card+2. It is bounded to one card and unmounts while dragging. Still, before you leave draft, include the pending A50 Perfetto run (10 swipes + 5 flips vs main) in the PR body so we can confirm the extra idle mount does not add memory pressure or late-commit jank on low-end Android. The PR body says this device check is still pending. - M2
apps/client/e2e/helpers/patternRender.ts(poll body, diff hunk @@-98) — the checks are just as strict: size, non-blank and optional glow are still required on the same settled PNG. But the oldexpect(...)messages that gave expected vs actual size,opaquePixelsandglowPixelswere lost. Addexpected.width x expected.heightand the pixel counts to the returned poll strings (e.g.size-${w}x${h}-vs-${ew}x${eh},blank-${opaquePixels}) so CI failures can still be diagnosed.
CI: all required checks green on a62cfe8 (Client (Expo), API (Laravel), Client E2E gate, Client E2E screenshots 4m12s, Workflow lint, Prod storage binds, VPS Python 3.6, Vercel). Full-screenshot and baseline jobs were skipped.
Evidence:
- Native-first: NoMediaEmboss and LoadingCard now use the shared
RasterizedSvgXmlpath, which runs the same way on all platforms. The only web-specific code is the existingaria-hiddenspread pattern. The intro logo and all other user-facing features are untouched, and animations are unchanged (the prewarm slot isopacity:0, translated off-screen,pointerEvents="none", and hidden from a11y). - Prewarm is bounded: only
currentIndex+2, gated onpatternCaptureEnabledplus a 32 ms armed tick (ConceptCardStack.tsx:979-993). It is torn down during gestures. - The cache is bounded:
lib/patternBitmapCache.ts:10-11, 24 MB / 24 entries with LRU eviction at :77-85. - Prefetch: the hot-path effect fetches at most 3 URLs (
MEDIA_PREFETCH_AHEAD=2), deduplicated and covered by a unit test. The deck-wide batch stays debounced. - E2E: the settle check and PNG analysis now run in the same poll tick, which removes a remount race without dropping any check. No sudo in any script.
Keep the atomic settle+PNG poll, but surface expected-vs-actual size and opaque/glow pixel counts again when the poll or post-settle assert fails. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com>
There was a problem hiding this comment.
Agent: Pull Request Reviewer
Verdict: Approve
Delta a62cfe8...a13a4b1 (1 commit, fast-forward; only apps/client/e2e/helpers/patternRender.ts).
Blockers: none.
Minors (in-PR):
- M2 fixed: poll returns now carry expected-vs-actual size (L134),
opaquePixels(L138),glowPixels(L142). Post-poll re-asserts sizeOk/nonBlank/hasGlow with the same messages (L156-180). Checks are equally strict or stricter: the same predicates run, plus a re-check after the poll. No web-only paths, no sudo, no UX change (test helper only). - M1 is still open: the A50 Perfetto run is pending. Supervisor will plan it before the PR leaves draft.
CI: all checks green on a13a4b1 (API, Client Expo, Client E2E screenshots 4m59s, gate, workflow lint, VPS Py3.6, prod binds, Vercel). Full screenshots and baselines were skipped.
A50 Hermes vs main 17293e4 showed higher janky% / p99 and +PSS from the fourth ConceptCard tree and eager next-2 Image.prefetch. Keep settle-gated NoMediaEmboss and LoadingCard rasters (UseView→Image) and restore current- only immediate media preload. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com>
Contributor
Author
|
Closing: A50 3-run medians show no gain vs main (jank 34.16% vs 34.75%, p99 2500 vs 1650 ms, ~+70 MB PSS). Card rendering is being redone without runtime SVG. |
cursor Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
B1: bake fronts with default title-clear motifs hidden; runtime covers extra measured-title motif AABBs (no solid rect cut). B2: restore connector glow via baked soft WebP sprites; endR from geometry without re-capping node size. B3: E2E asserts natural size == PATTERN_BAKE_PIXEL (1074×1680) and no SVG. B4: re-bake -3x.webp + manifest; CI assert-pattern-baked re-bake diff. Minors: color.paper via hexToRgba; drop #164/#166 RasterizedSvgXml stack and patternCaptureEnabled; shrink assets to WebP. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com>
gasnet-supervisor Bot
added a commit
that referenced
this pull request
Nov 2, 2026
* Replace card SVG with build-time pattern PNGs Zero react-native-svg on the deck path: bake front/emboss PNGs at 3× from the pattern SVG masters, show via Image, clear the title with an orange cover, and drive connector glow with View layers + Reanimated opacity. Media fade uses expo-linear-gradient. No pre-mount/prefetch; same path on web preview. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com> * Fix #167 review: bake clear, soft glow, real E2E size B1: bake fronts with default title-clear motifs hidden; runtime covers extra measured-title motif AABBs (no solid rect cut). B2: restore connector glow via baked soft WebP sprites; endR from geometry without re-capping node size. B3: E2E asserts natural size == PATTERN_BAKE_PIXEL (1074×1680) and no SVG. B4: re-bake -3x.webp + manifest; CI assert-pattern-baked re-bake diff. Minors: color.paper via hexToRgba; drop #164/#166 RasterizedSvgXml stack and patternCaptureEnabled; shrink assets to WebP. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com> * Size baked pattern Image to card face points Art-director B1: absoluteFill let the 1074×1680 WebP lay out at asset pixels (~3× crop). Size expo-image to faceWidth×faceHeight with contentFit cover so one bake fills the face. Glow maps through xMidYMid slice (same as former SvgXml). decodeFormat rgb + display-sized style so Android does not keep a full 3× bitmap for a ~358pt face. LoadingCard uses the same sizing. Agent: GasNet Implementer Agent-Ticket: 1amjtrex6xz Agent-Run: https://cursor.com/agents/bc-390d3a06-c4ad-5631-96fb-4ebcb76dd81a Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: gassius <gassius@users.noreply.github.com> Co-authored-by: cgonzalezr <cgonzalezr@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-Ticket: 1amjtrex6xz (https://app.clickup.com/t/1amjtrex6xz)
Perfetto on Galaxy A50 (main after #163/#164) showed ~86% of janky-frame time in UI-thread software draw of remaining react-native-svg nodes.
Device verification pending: Hermes 10 swipes + 5 flips on A50 vs main (E: 33.46% janky, p99 1150 ms) plus visual parity screenshots.