8000 build(deps): move to lucide-react 1.x by adeelahmad · Pull Request #369 · adeelahmad/lense · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions nextjs-frontend/__tests__/externalSignIn.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ describe("signing in with an outside account", () => {
expect(screen.getByRole("button", { name: "Continue with Google" })).toBeEnabled();
});

it("marks GitHub with its own logo and other providers with a sign-in icon", () => {
render(<ExternalSignIn providers={[GOOGLE, GITHUB]} />);
const icon = (name: string) => screen.getByRole("button", { name }).querySelector("svg");
expect(icon("Continue with GitHub")).toHaveAttribute("fill", "currentColor");
expect(icon("Continue with Google")).toHaveClass("lucide-log-in");
});

it("shows nothing without providers", () => {
const { container } = render(<ExternalSignIn providers={[]} />);
expect(container).toBeEmptyDOMElement();
Expand Down
13 changes: 11 additions & 2 deletions nextjs-frontend/components/auth/external-sign-in.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { Github, LogIn } from "lucide-react";
import { LogIn } from "lucide-react";
import { useState } from "react";

import { Auth, type ExternalProvider } from "@/app/openapi-client";
Expand All @@ -17,8 +17,17 @@ export async function externalSignInUrl(key: string, next: string): Promise<stri
return data.url;
}

/** GitHub's mark (Simple Icons, CC0); lucide-react 1.x ships no brand icons. */
function GithubMark() {
return (
<svg viewBox="0 0 24 24" width="24" height="24" fill="currentColor" aria-hidden>
<path d="M12 .297c-6.63 0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577 0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633 17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236 1.07 1.835 2.809 1.305 3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93 0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3 1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23 3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805 5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0 .315.21.69.825.57C20.565 22.092 24 17.592 24 12.297c0-6.627-5.373-12-12-12" />
</svg>
);
}

export function ProviderIcon({ kind }: { kind: ExternalProvider["kind"] }) {
return kind === "github" ? <Github /> : <LogIn />;
return kind === "github" ? <GithubMark /> : <LogIn />;
}

/** "Continue with Google", GitHub, Microsoft or an OpenID Connect provider an admin set up (Settings › Sign-in). */
Expand Down
2 changes: 1 addition & 1 deletion nextjs-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"dotenv": "^18.0.6",
"lucide-react": "^0.452.0",
"lucide-react": "^1.57.0",
"next": "16.4.0",
"next-auth": "5.0.0-beta.32",
"react": "19.3.0",
Expand Down
18 changes: 12 additions & 6 deletions nextjs-frontend/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0