8000 build(deps): move to lucide-react 1.x by adeelahmad · Pull Request #369 · adeelahmad/lense · GitHub
[go: up one dir, main page]
Skip to content

build(deps): move to lucide-react 1.x - #369

Merged
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-yqyu9p
Oct 15, 2026
Merged

build(deps): move to lucide-react 1.x#369
adeelahmad merged 1 commit into
mainfrom
claude/project-thread-yqyu9p

Conversation

@adeelahmad
@adeelahmad adeelahmad commented Oct 14, 2026
Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Description

Before: Dependabot's lucide-react 0.452 → 1.55 bump (#365) failed typecheck, the build and every check that builds the web app, because lucide-react 1.0 removed its brand icons and the GitHub sign-in button imported Github.

After: the web app is on lucide-react 1.x. The "Continue with GitHub" button, connected accounts and Settings › Sign-in draw GitHub's mark inline (the Simple Icons path, CC0); every other icon is unchanged.

How: bump lucide-react with pnpm, replace the one removed export with a small inline SVG in ProviderIcon, and add a test that GitHub gets its mark and other providers the sign-in icon. Replaces #365.

Motivation and Context

Answering "all tests green?": main is green, and this clears one of the red Dependabot PRs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; ! in the title)

Checklist:

  • The title is a Conventional Commit.
  • My code follows the code style of this project (make hooks checks it on commit).
  • I added or updated tests.
  • My change requires documentation updates: n/a, no behaviour or configuration change.
  • CHANGELOG: n/a, the title is enough.

Done questions (AGENTS.md)

  • Goal: merges on green CI (locally: tsc, eslint, 787 jest tests and pnpm build pass).
  • Agents: n/a, an icon.
  • Zero setup: no new prerequisite.
  • Fewest clicks: n/a, unchanged.
  • Configurable: n/a, no settings.
  • Light: no new dependency; the mark is inline.
  • Private and secure: n/a, no new surface.
  • Cost: n/a, no model calls.
  • User decides: defaults unchanged.
  • Upgrades: n/a, no stored data.
  • Honest: n/a.
  • Tests added; no docs or generated files affected.
  • Open: lucide-react is ISC, the GitHub path is CC0.
  • Reported in the project thread.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GoeF3WmfShLFtu15B1sQZz

Generated by Claude Code

@claude
build(deps): move to lucide-react 1.x
d0d8469 
lucide-react 1.0 dropped its brand icons, so the GitHub sign-in button
draws GitHub's mark (Simple Icons, CC0) inline. Replaces #365, which
failed typecheck on the missing Github export.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GoeF3WmfShLFtu15B1sQZz
@adeelahmad adeelahmad self-assigned this Oct 14, 2026
@adeelahmad
adeelahmad merged commit 0a78be5 into main Oct 15, 2026
17 checks passed
@adeelahmad
adeelahmad deleted the claude/project-thread-yqyu9p branch October 15, 2026 00:22
@adeelahmad adeelahmad mentioned this pull request Oct 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adeelahmad adeelahmad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adeelahmad @claude
0