Repository navigation
ci(threat-model): check the threat model's prose, YAML and JSON agree - #207
Merged
Merged
Conversation
The threat-model plugin's validate_model.py lives outside the repo, so cloud sessions and CI couldn't run it. ci/validate_threat_model.py checks the prose hash, the property ids across all three files and the open-question numbers, and a workflow runs it on GitHub-hosted runners when those files change. It flagged P-CONVERT-TIMEOUT: Q20's ruling claims it, but no table defined it. Add it to §1.11, the YAML and the JSON, and turn the x-process-control row from unresolved to claimed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmVP1oJMKTCBvDP6eJVnrX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: checking the threat model meant running the threat-model plugin's
validate_model.pyby hand. That script ships with the plugin, not the repo, so cloud sessions and CI couldn't run it.After:
ci/validate_threat_model.pyruns in a newthreat modelworkflow on GitHub-hosted runners wheneverthreat-model.md,.yamlor.jsonchange. It checks:prose_versionis the sha256 of the proseRun against main (with #205), it flagged one problem. Q20's ruling claims P-CONVERT-TIMEOUT, but no table defined it. This PR adds it to §1.11, the YAML and the JSON as correctness-only, citing the timeouts from #202. The x-process-control matrix row changes from unresolved to claimed, and N-DECODERS and N-BOMBS now point to the new property. The prose hash is refreshed.
Motivation and Context
The threat model check now runs in CI, so it no longer needs a local run.
Types of changes
Checklist:
make hookschecks it on commit).docs/accordingly. (DEVLOG points at the new script.)🤖 Generated with Claude Code
https://claude.ai/code/session_01AmVP1oJMKTCBvDP6eJVnrX
Generated by Claude Code