Repository navigation
fix(ingest): stop ffmpeg, antiword and pdftotext runs that never finish - #202
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
…-qt650x-converter-timeouts
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: decoding a recording with ffmpeg, encoding audio for a speech service, and reading
.docfiles (antiword, catdoc) or PDFs without pypdf (pdftotext) ran with no time limit. A file that made one of them hang held its worker forever.After: each has a limit (6 hours for decoding a recording, 10 minutes for encoding a piece of speech, 5 minutes for reading a document). Past it the tool is stopped and the import fails with "took longer than ... s", like the converters that already had limits. Normal files finish far inside these limits.
Motivation and Context
This answers threat-model question Q20: every external tool Lens runs on uploaded files has a time limit.
Steps to reproduce (if appropriate):
test_stuck_converters_are_stoppedintests/domain/test_speech.pyputs tools that never finish onPATHand checks each one is given up on.Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01W42z4FbekWr33b6791svQQ
Generated by Claude Code