Repository navigation
targets check: a create whose file already defines its planned symbol is realized, not a defect (live run 19) - #30
Merged
Conversation
… is realized, not a defect
Live e2e run 18 (12/12, $0.99, 15m47s): the mid-sprint re-plan of T2 ran
the planner's stop gate over the whole plan, and `targets check` blocked
its stop 9 times on T1's merged `create tests/parse.rs` ("already
exists") while the brief said not to touch T1. Now a create whose path
exists AND defines its planned_symbol passes (the change shipped) and
`target` resolves it to file:line; a file without the symbol is still a
plan defect. Test-first in scripts/test/semantic-targets.test.py,
reproduced on run 18's own plan. ROADMAP §0 records run 18 and the two
gaps it found (planner stop verdicts unlogged; RED tests satisfiable by
the prior task's placeholder).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014j4wLin3oJTtnvjE9Lq2VV
…n 19 (the other thread's run 18 landed first)
adeelahmad
pushed a commit
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before:
targets checkrejected everycreatewhose path exists. Live e2e run 19 (semver intent, after the never-commit-on-main gate; the other thread's run 18 landed in #29 first) re-planned T2 mid-sprint, which re-ran the planner's stop gate over the whole plan; T1'screate tests/parse.rshad merged, so the planner was blocked 9 times with "already exists (use modify/extend)" for a change its brief said not to touch, and only stopped after rewriting C1/C2 tomodifyon a second dispatch.After: a
createwhose file exists and defines its planned symbol passes as realized, andtargetresolves it tofile:line. A file that exists without the symbol is still a plan defect.How: one branch in
problems()and one inresolve()inplugin/bin/targets, using the existinglocate(). Master (#29) is merged in; the ROADMAP conflict kept both runs.Evidence:
semantic-targets.test.py6/6 (new case written first, red before the change); reproduced on run 19's own plan with C1/C2 restored tocreate: blocked before,6 change targets validafter, with ctx-symbols as backend;targets-scope4/4,plan-render5/5,lsp-adapter4/4,make conformance58/58,make test-hosts pycheck shellcheckOK.Run 19: 12/12, 15m47s, $0.99, 39 supervisor turns, 2 plugin-source reads, 2 logged blocks. ROADMAP §0 records it and the two gaps it found: the planner's stop-gate verdicts are not in
gates.jsonl(the blocks metric under-counts and the stuck release does not cover a looping planner), and RED tests that the prior task's placeholder already satisfies cost a re-plan. Both are fixed in the stacked PR that follows.🤖 Generated with Claude Code
https://claude.ai/code/session_014j4wLin3oJTtnvjE9Lq2VV