8000 targets: a modify/extend of a missing file says a new file is a create by adeelahmad · Pull Request #102 · adeelahmad/aloop · GitHub
[go: up one dir, main page]
Skip to content

targets: a modify/extend of a missing file says a new file is a create #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeelahmad merged 2 commits into from
Oct 20, 2026
Merged

targets: a modify/extend of a missing file says a new file is a create #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8bcbc0
targets: a modify/extend of a missing file says a new file is a create
claude Oct 20, 2026
5260fc4
Run 49 (cli on #95 and #102): 13/13, $0.87, 3 blocks
claude Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/evidence/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ the cost cell reads — and the intent cell names the host. What each run found
| run 46 | cli (Rust binary), on both #76 fixes | v0.12.0 + #76 (286bf45) | 13/13 | 15m19s | $0.99 | 2 | 2 | 6 | `make e2e-live YES=1 INTENT=cli` |
| run 47 | cli (Rust binary), on #81 | v0.12.0 + #81 (a653fd4) | 13/13 | 15m19s | $1.04 | 2 | 1 | 2 | `make e2e-live YES=1 INTENT=cli` |
| run 48 | cli (Rust binary), on the task-merge rule | v0.12.0 + #90 (a60cd04) | 13/13 | 14m13s | $0.76 | 2 | 0 | 5 | `make e2e-live YES=1 INTENT=cli` |
| run 49 | cli (Rust binary), on #95 and #102 | v0.12.0 + #102 (f8bcbc0) | 13/13 | 13m50s | $0.87 | 1 | 0 | 3 | `make e2e-live YES=1 INTENT=cli` |

Columns: *checks* are the e2e script's own assertions (12 for `semver`, 13 for `wordfreq` since
the commit-trace check); *wakes* are supervisor turns that ended and resumed (each re-reads
Expand Down Expand Up @@ -97,3 +98,6 @@ stories and 5 tasks this time, so cost stayed at $1.04: task count still varies
Run 48 (on #90: `targets check` refuses two small adjacent tasks on the same files) planned 2
tasks, one per story, with no merge refusal: the rule's persona line was enough. It is the cheapest
`cli` run yet ($0.76, 25 supervisor turns, from $1.04 and 41), and all 5 blocks were self-checks.
Run 49 (on #95, which stops the Rust suppression grep matching an iterator's `.skip(1)`, and #102)
had 3 gate blocks, from 5, with no suppression or `targets` "neither in the tree nor planned"
refusal. It planned 2 tasks again, for $0.87 in 13m50s.
5 changes: 4 additions & 1 deletion plugin/bin/targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,10 @@ def problems(sdir, targets, root, doc=None):
if exists and (not psym or locate(root, path, psym)[0] is None):
p.append("%s: create targets %s, which already exists (use modify/extend)" % (where, path))
elif not exists and path not in planned:
p.append("%s: %s targets %s, which is neither in the tree nor planned" % (where, op, path))
# live runs 47-48: `extend tests/common/mod.rs` for a helper module no target created
p.append("%s: %s targets %s, which is neither in the tree nor planned: a new file is a create "
"(\"operation\": \"create\" with its first planned_symbol), and a later target may "
"extend it" % (where, op, path))
elif exists and t.get("symbol"):
line, _ = locate(root, path, t["symbol"])
if line is None and not any(pp == path and ps == t["symbol"] and pr != ref
Expand Down
2 changes: 1 addition & 1 deletion scripts/test/semantic-targets.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def targets(*ts):
(dict(C2, symbol="nope"), "not defined"),
(dict(C2, task="T9"), "not a ## heading"),
5A34 (dict(C1, path="src/report.py"), "already exists"),
(dict(C2, path="src/ghost.py"), "neither in the tree nor planned"),
(dict(C2, path="src/ghost.py"), "neither in the tree nor planned: a new file is a create"),
(dict(C2, operation="rewrite"), "operation must be"),
(dict(C1, path="../etc/x.py"), "repo-relative"),
]
Expand Down
Loading
0