Repository navigation
Gates: an iterator's .skip(n) in Rust is not a test suppression - #95
Merged
Merged
Conversation
Live runs 46-48: every GREEN self-check was refused once because the Rust suppression grep matched args().skip(1), a JS pattern. Rust now checks its own attributes only: #[ignore] (also #[ignore = "reason"], previously missed) and #[cfg(not(test))]. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
adeelahmad
marked this pull request as ready for review
October 20, 2026 09:02
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RxETAY6S1gcmdctBK8a8Z
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0197nSutKR1QAAqgJhFZ8fPj
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012rsDo9GYzNx8tXucywZHnA
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: the Rust suppression grep in
assert_no_suppressionalso matched.skip(andxit(, which are JS patterns. A Rust CLI'sstd::env::args().skip(1)was therefore refused as a "test-suppression pattern". This happened to one GREEN worker in each of live runs 46, 47 and 48, and each one cost a retry. Meanwhile#[ignore = "slow"], a real Rust suppression, was not caught because the grep looked only for the exact#[ignore].After: Rust files are checked only for Rust's own attributes:
#[ignore](with or without a reason) and#[cfg(not(test))]. Python, Go and JS keep their patterns, including.skip(andxit(. Real suppressions are caught more strictly than before, and the iterator call no longer blocks.How:
plugin/bin/_gatelib.sh.suppression-contract.test.pynow runsassert_no_suppressionon fixtures. It checks that.skip(1)passes, and that#[ignore],#[ignore = ".."],cfg(not(test))and JSit.skip(are all refused. It was RED before the fix.make ciis green locally (78/78).Generated by Claude Code