Repository navigation
Brand: adopt the Aladdin design system (README, site, banners, social preview) - #94
Open
adeelahmad wants to merge 2 commits into
Open
adeelahmad wants to merge 2 commits into
adeelahmad wants to merge 2 commits into
Conversation
… preview) The owner's Aladdin design system replaces the earlier gold "a-loop" kit: - docs/brand/design-system/ vendors its tokens, guideline cards and the two social cards; gen_brand.py reads the colour tokens from it. - Wordmark option D (DM Sans 800 over the blue-red-green-gold loop bar), its on-blue variant, the four-dot signature, an "A over the loop bar" icon with a whole-pixel 16 px cut, light and on-blue README banners, favicons, app icons. - social-preview.png is the owner's card rendered at 2x, with the RED agent named red-worker, a measured-cost box from the evidence ledger, the mission layer in the feature list and a footer that no longer breaks words. - og-card.png is a new large-type card that reads in a phone feed. - README: no emoji (the design system's glyphs instead), blue release badge, design-system footer. Site: design-system palette (terminal palette in dark mode), the wordmark in the header, the lamp drawn flat without a gradient. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019o44PEkQ4qiLGMEes1QTKx
…width, pinned symbol fonts From an adversarial review of the rebrand: - README: the last emoji (an hourglass on "next") becomes →. readme.test.py now fails on any Emoji_Presentation code point, so the rule holds. - Social preview: white numbers no longer sit on core red, green or gold (3.92, 3.06, 1.93:1): the red and green discs take the dark variants (5.80, 5.10) and the gold disc takes ink (8.32). check_palette checks these pairs. - Site: the light card panel is white, the design system's plain card, so the gold-dark SCAFFOLD title is 4.65:1 instead of 4.41:1. - Wordmark: the loop bar now includes the trailing letter-spacing, as the CSS it mirrors does (0.03 em narrower). - render.mjs: file URLs come from pathToFileURL / Path.as_uri, and the render fails if any text falls back to a system font. Arrows, ● ◆ ✓ and ≠ ≤ come from pinned Noto faces, so the PNGs are byte-identical on rerun. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019o44PEkQ4qiLGMEes1QTKx
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: the brand in #88 was a home-made gold-on-dark kit (an "a" whose bowl is a loop, Space Grotesk, a dark social card), with emoji all through the README. Adeel's own Aladdin design system, GitHub social preview and GitHub kit existed but were never used.
After: the repo uses Adeel's design system.
How
Design system.
docs/brand/design-system/vendors its tokens, guideline cards and README, plus the two social cards as HTML (social-preview.html,og-card.html). The React components and UI kit stay in the design system. The brand-illustration card and the genie infographic are left out, because the design system asks for an original lamp motif with no borrowed visual language.Generator.
gen_brand.pyreads the colour tokens fromdesign-system/tokens/colors.cssand writes:wordmark.svgandwordmark-on-blue.svg;signature.svg(the four dots);icon.svgwith a whole-pixel 16 px cut (icon-16.svg=favicon.svg);render.mjs(Playwright) renders the two HTML cards from cached fonts. Arrows, ● ◆ ✓ and ≠ ≤ come from pinned Noto faces. The render fails if any text falls back to a system font, so the PNGs come out byte-identical on rerun. The oldmark-*andlockup-*SVGs are removed.Social preview changes. Adeel's card changes in five places:
red-worker, not "tester".docs/evidence/README.md($0.56–$0.91, 6m45s–14m13s).README. Emoji are replaced by the design system's glyphs: ✓ shipped, ● in progress, → next, ◆ for the door decision.
readme.test.pynow fails on any emoji. The release badge is blue, and the footer names the design system.Site.
Calls I made.
Evidence
readmepasses 7 checks, including the new no-emoji check. It failed first on the hourglass left on line 193.site(5) andevidence(4) pass.rename-compat,layout,skill-layoutandaladdin-clipass.make test-hostspasses.check_palette()passes. It now covers the disc pairs and groups every pair by use. Blue on white is 4.51:1, and every*-darktext variant on white is at least 4.65:1. Two design-system tint pairs are kept exact and documented: green-dark on its tint (4.49:1) and gold-dark on its tint (4.34:1).social-preview.pngis 399 KB at 2560×1280, under GitHub's 1 MB limit.Needs the owner: upload
docs/brand/social-preview.pngunder Settings → General → Social preview. GitHub has no API for this.🤖 Generated with Claude Code
https://claude.ai/code/session_019o44PEkQ4qiLGMEes1QTKx