Repository navigation
Mission loop takes its ethics facts from the ethics verdict (M9.23) - #85
Merged
Merged
Conversation
tick asks ethics.verdict for the mission and each goal (none, pending, hard, broken) instead of reading ethics events itself, so a goal derived again with a hard-lined goal's words is hard at once and a review edited after it was recorded blocks for the human. A committed hard review still fails closed. The test helper records reviews through mission ethics. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Aw6CiQcdpzdzZZXKf8WbUM
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0197nSutKR1QAAqgJhFZ8fPj
adeelahmad
pushed a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before:
mission tickread the ethics events itself, with its own copy of the rules. It missed two cases the gate (mission ethics) catches:ETHICS_REVIEWinstead of being hard.After: tick asks
ethics.verdict(cwd, kind, id)for the mission and each goal, so the loop and the gate follow one rule.How.
ethics_ofinplugin/mission/tick.py):none→ETHICS_REVIEW.pending→ASK_CONSENT, namingaloop mission ethics consent --subject … --by --reason.hard→BLOCKEDfor the mission. For a goal, it is re-derived (counted toward 3 failed goals), orBLOCKEDwhile its sprint runs.brokenorunresolved→BLOCKEDfor the human, with the gate's problem.ok→ go on.aloop mission ethics new / record / consent. The hand-written events are gone.plugin/mission/README.mdand the tick docstring.Evidence.
mission-tick.test.py: 28 checks.DERIVE_GOAL, notETHICS_REVIEW) fails on the previoustick.py, and now passes.BLOCKED) also fail on the previoustick.py, and now pass.mission-*.test.pypasses on this branch after Mission goals and the Aladdin handoff (M9.11) #79 (goals), as domake pycheckandcheck-tracking.Generated by Claude Code