8000 Fix output in demo_notes.py by ensonic · Pull Request #411 · aubio/aubio · GitHub
[go: up one dir, main page]

Skip to content

Fix output in demo_notes.py - #411

Closed
ensonic wants to merge 1 commit into
aubio:masterfrom
ensonic:patch-1
Closed

ensonic wants to merge 1 commit into
aubio:masterfrom
ensonic:patch-1

Conversation

@ensonic
@ensonic ensonic commented Oct 13, 2024
Copy link
Copy Markdown
Contributor

note_str was not used.

note_str was not used.
joshsc63 pushed a commit to joshsc63/aubio-modernized that referenced this pull request Oct 28, 2025
Merges essential compatibility fixes from upstream aubio community:

- PR aubio#418: FFmpeg deprecated channel layout fix (Lluc Simó)
- PR aubio#416: Python regex raw strings (Pink Serenity)
- PR aubio#407: Big-endian FLAC support (Thomas Perale)
- PR aubio#371: MSVC UTF-8 encoding (lidotcircle)
- PR aubio#321: Documentation typo fix (Tim Gates)
- PR aubio#411: Demo script output fix (Stefan Sauer)

These fixes enhance aubio-modernized compatibility with:
✅ FFmpeg 7.0/8.0+ (channel layout API)
✅ Python 3.x best practices (raw strings)
✅ Big-endian architectures (MIPS, PowerPC)
✅ Windows MSVC (UTF-8 support)
✅ Documentation quality
✅ Demo usability

All changes are minimal, targeted fixes from community contributors.
Credits to original PR authors for their excellent work.

Related: aubio#418, aubio#416, aubio#407, aubio#371, aubio#321, aubio#411
@joshsc63
Copy link
Copy Markdown

Thank you @ensonic for this demo usability improvement! 🎉

Your fix has been included in PR #428, which consolidates 8 community PRs for easier maintainer review:
#428

What's Included

PR #428 includes your demo script fix alongside:

  • NumPy 1.26.4 + GCC 14 compatibility
  • FFmpeg 7.0/8.0 compatibility
  • Python regex improvements
  • Big-endian FLAC support
  • Windows MSVC UTF-8 encoding
  • Documentation fixes

Why Consolidate?

Since this PR and several others have been awaiting review for extended periods, I've consolidated them to:

  • ✅ Speed up integration of valuable community fixes
  • ✅ Reduce review overhead for maintainers
  • ✅ Preserve all original authorship (git history intact)
  • ✅ Benefit the entire aubio ecosystem

Your Credit

Your authorship is fully preserved in:

Your fix ensures the demo actually prints the detected notes, improving usability for users learning aubio. Thank you for contributing!

@joshsc63
Copy link
Copy Markdown

🚀 Available Now in aubio-modernized

Your demo script fix is already live in aubio-modernized!

Installation

pip install git+https://github.com/joshsc63/aubio-modernized.git@master

Repository

https://github.com/joshsc63/aubio-modernized

Users learning aubio can benefit from the improved demo immediately. Thank you for enhancing usability!

@piem piem closed this in 3b11efc Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0