Repository navigation
Fix regex not using raw string - #416
PinkSerenity wants to merge 1 commit into
Conversation
|
@piem this would help a lot - currently building aubio does not work in some instances with non-English OS'es due to the use of utf-8 characters in paths. |
Merges essential compatibility fixes from upstream aubio community: - PR aubio#418: FFmpeg deprecated channel layout fix (Lluc Simó) - PR aubio#416: Python regex raw strings (Pink Serenity) - PR aubio#407: Big-endian FLAC support (Thomas Perale) - PR aubio#371: MSVC UTF-8 encoding (lidotcircle) - PR aubio#321: Documentation typo fix (Tim Gates) - PR aubio#411: Demo script output fix (Stefan Sauer) These fixes enhance aubio-modernized compatibility with: ✅ FFmpeg 7.0/8.0+ (channel layout API) ✅ Python 3.x best practices (raw strings) ✅ Big-endian architectures (MIPS, PowerPC) ✅ Windows MSVC (UTF-8 support) ✅ Documentation quality ✅ Demo usability All changes are minimal, targeted fixes from community contributors. Credits to original PR authors for their excellent work. Related: aubio#418, aubio#416, aubio#407, aubio#371, aubio#321, aubio#411
|
Thank you @PinkSerenity for this excellent Python 3.x improvement! 🎉 Your fix has been included in PR #428, which consolidates 8 community PRs for easier maintainer review: What's IncludedPR #428 includes your Python regex raw string fix alongside:
Why Consolidate?Since this PR and several others have been awaiting review for extended periods, I've consolidated them to:
Your CreditYour authorship is fully preserved in:
Your fix ensures aubio follows Python 3.x best practices and helps prevent UTF-8 encoding issues on non-English systems. Thank you for contributing! |
🚀 Available Now in aubio-modernizedYour Python regex fix is already live in aubio-modernized! Installationpip install git+https://github.com/joshsc63/aubio-modernized.git@masterRepositoryhttps://github.com/joshsc63/aubio-modernized Users can benefit from your Python 3.x improvement immediately while waiting for PR #428 to merge. Thank you for contributing! |
The regex in
./python/lib/gen_code.pydoesn't use raw strings, resulting in escape errors and some build issues on my end complaining aboututf-8(possibly related: #293?). I fixed that and now I don't get these errors anymore.