8000 Preserve initial packet order on sending by kenhkan · Pull Request #73 · noflo/noflo · GitHub
[go: up one dir, main page]

Skip to content

Preserve initial packet order on sending - #73

Merged
bergie merged 2 commits into
noflo:masterfrom
kenhkan:preserve_order_of_initial_packets
May 2, 2013
Merged

bergie merged 2 commits into
noflo:masterfrom
kenhkan:preserve_order_of_initial_packets

Conversation

@kenhkan
@kenhkan kenhkan commented May 1, 2013
Copy link
Copy Markdown
Contributor

Current implementation sends out whatever is ready first, messing up the order specified by the programmer. This also removes legacy code for handling downstream components not being ready.

Checking for downstream readiness was initially a problem as described in #40. That was due to initial packets being sent before the network is ready. It's partially solved in #69 when initial packets are only sent upon the respective network has been loaded. This PR solves the other half which is initial packets being sent in the order of the programmer's specification so by the time the network is run, everything should be ready anyway.

kenhkan added 2 commits May 1, 2013 00:40
Current implementation sends out whatever is ready first, messing up the specified order by the programmer.
Checking for downstream readiness was initially a problem as described in noflo#40. That was due to initial packets being sent before the network is ready. It's partially solved in noflo#69 when initial packets are only sent upon the respective network has been loaded. This PR solves the other half which is initial packets being sent in order of the programmer's specification so by the time the network is run, everything should be ready anyway.
@bergie
bergie commented May 2, 2013
Copy link
Copy Markdown
Member

In general, this looks good. However, I'd rather see the logic in Network itself, not in NoFlo.createNetwork. However, I'm ready to merge this as-is, too.

bergie added a commit that referenced this pull request May 2, 2013
@bergie
bergie merged commit a016d4b into noflo:master May 2, 2013
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0