Repository navigation
Preserve initial packet order on sending - #73
Merged
Merged
Conversation
Current implementation sends out whatever is ready first, messing up the specified order by the programmer.
Checking for downstream readiness was initially a problem as described in noflo#40. That was due to initial packets being sent before the network is ready. It's partially solved in noflo#69 when initial packets are only sent upon the respective network has been loaded. This PR solves the other half which is initial packets being sent in order of the programmer's specification so by the time the network is run, everything should be ready anyway.
Member
|
In general, this looks good. However, I'd rather see the logic in Network itself, not in NoFlo.createNetwork. However, I'm ready to merge this as-is, too. |
bergie
added a commit
that referenced
this pull request
May 2, 2013
Preserve initial packet order on sending
AsherBond
pushed a commit
to AsherBond/noflo
that referenced
this pull request
Oct 12, 2026
Update noflo-core to version 0.3.0 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation sends out whatever is ready first, messing up the order specified by the programmer. This also removes legacy code for handling downstream components not being ready.
Checking for downstream readiness was initially a problem as described in #40. That was due to initial packets being sent before the network is ready. It's partially solved in #69 when initial packets are only sent upon the respective network has been loaded. This PR solves the other half which is initial packets being sent in the order of the programmer's specification so by the time the network is run, everything should be ready anyway.