Repository navigation
Defer entire initial connection rather than just the disconnect - #69
Merged
bergie merged 1 commit into
noflo:masterfrom <
8000
div class="d-flex flex-items-center overflow-hidden gap-1">kenhkan:send_initials_on_next_tick
Merged
Conversation
…menting data packets and disconnect signal within the same connection
bergie
added a commit
that referenced
this pull request
Apr 26, 2013
Defer entire initial connection rather than just the disconnect
kenhkan
added a commit
to kenhkan/noflo
that referenced
this pull request
May 1, 2013
Checking for downstream readiness was initially a problem as described in noflo#40. That was due to initial packets being sent before the network is ready. It's partially solved in noflo#69 when initial packets are only sent upon the respective network has been loaded. This PR solves the other half which is initial packets being sent in order of the programmer's specification so by the time the network is run, everything should be ready anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire connection should be deferred until next tick to avoid segmenting data packets and disconnect signal within the same connection.