8000 Group scraped text by element ID. by rybesh · Pull Request #15 · noflo/noflo · GitHub
[go: up one dir, main page]

Skip to content

Group scraped text by element ID. - #15

Merged
bergie merged 1 commit into
noflo:masterfrom
rybesh:scrapehtml
Apr 3, 2012
Merged

bergie merged 1 commit into
noflo:masterfrom
rybesh:scrapehtml

Conversation

@rybesh
@rybesh rybesh commented Mar 30, 2012
Copy link
Copy Markdown
Contributor

No description provided.

bergie added a commit that referenced this pull request Apr 3, 2012
Group scraped text by element ID.
@bergie
bergie merged commit 80ad2b2 into noflo:master Apr 3, 2012
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
Allows people to pick their defaults without having to edit the code.
Step one for issue noflo#15.
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
This allows to run noflo-nodejs with the debug logging enabled.
Fixes noflo#15
bergie added a commit that referenced this pull request Oct 17, 2026
…rd, and the polish

- The caseSensitive: false normalization covers IIP targets: a
  mixed-case IIP target against a lowercase-declared 1.x component was
  the silent-resolution-then-loud-failure shape the flag exists to
  prevent. Spec: the legacy IIP runs end to end, the normalized target
  pinned via graph.iips()
- The export-name collision throws during normalization: two exports
  differing only by case become one under the 1.x semantics, and
  silently dropping one would change the application's boundary.
  Spec: the collision error pinned
- The dead node.ports normalization loop removed (legacy normalization
  strips node ports; the import reads only id/component/metadata)
- The naming spec's describe renamed (it now asserts valid mixed-case
  names); the Ports.js error message names dots and slashes like the
  regex; BasePort.getId renders the port name as authored (uppercasing
  made case-differing ports ambiguous in error messages)
- Export accessors corrected in the spec: GraphModel exposes exports()
  with direction, not inports()/outports()
bergie added a commit that referenced this pull request Oct 17, 2026
…oercion, graph-level specs

- The caseSensitive: false fold builds a fresh document: the caller's
  object is never rewritten (normalizeLegacyFbpJson returns the input
  object itself for modern documents, so the previous in-place
  normalization rewrote the caller's JSON)
- normalizeLegacyFbpJson carries top-level inits/case through on modern
  documents — the fields were previously dropped when processes existed,
  silently vanishing their IIPs; the import's IIP loop keeps the case
  fallback
- The normalization does not coerce: a non-string port value fails with
  a descriptive error exactly as the strict path would, instead of
  String() hiding the type error
- The export-name case collision throws (two exports differing only by
  case would collapse to one under the 1.x semantics)
- Graph-level specs pin the semantics where the code lives: the fold
  across edges/IIPs/exports, the no-mutation guarantee, the top-level
  inits/case carry-through, the collision error, the strictness, and
  both preservation modes
bergie added a commit that referenced this pull request Oct 17, 2026
Port names are case-significant (work document #15)
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 19, 2026
The 1.x lowercase-only port-name constraint is retired and author
casing is preserved end to end — DSL, FBP JSON, network ports. `out`
and `OUT` are distinct ports.

- Ports.add accepts mixed-case names (the 1.x regex required
  lowercase); the error message drops the lowercase claim. Special
  characters remain rejected.
- FBP JSON import honors the document's caseSensitive flag: false (the
  1.x interchange default, where the reference parser lowercased port
  names) normalizes port names to lowercase at import, so mixed-case
  references against lowercase-declared 1.x components resolve; true or
  absent preserves casing as authored, and a case-mismatched reference
  fails loudly at network build instead of silently resolving. Node ids
  are preserved as authored (graphs are self-consistent regardless of
  node-name case).
- Spec: spec/CaseSensitivity.js pins preserved casing, the distinctness
  of case-differing ports, end-to-end wiring and firing, the loud
  case-mismatch failure, and both legacy-import modes. The 1.x-era
  uppercase-throw expectations flip to acceptance.
- The migration guide: the naming-policy entry with the legacy note.

The parser half (the @noflo/fbp caseSensitive default) landed with the
noflo#14 work; this completes the policy across the stack.
bergie added a commit that referenced this pull request Oct 19, 2026
…d-error detail

Review findings on #1103 (work document #48 update #15), three nits
resolving together:

The component forwarded only inport stranded reports to its own
stranded surface; outport-side reports (unattached sends, dropped
errors) reached the component surface only through direct dispatches
on nodeInstance — which is wired only inside a Network. A standalone
component's unattached outport fired the port-level event and nothing
on the surface its consumers actually subscribe to. The outport
forwarding listener now matches the inport path, and the direct
node-level dispatches are gone — the component surface is the single
path, so no double-dispatch in networks either.

The dropped-error detail carried the raw Error object; the network's
emit path spreads the detail into the event payload where every other
stranded entry is counts and strings. The error is serialized at the
source (error: String(e)), so the payload survives the spread and the
tracefile unchanged.

The unattached-send port-level payload now carries the port name
itself, so the report is self-describing before any forwarding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0