Repository navigation
Make Replace component group-aware. - #14
Merged
Merged
Conversation
bergie
added a commit
that referenced
this pull request
Mar 30, 2012
Make Replace component group-aware.
AsherBond
pushed a commit
to AsherBond/noflo
that referenced
this pull request
Oct 12, 2026
AsherBond
pushed a commit
to AsherBond/noflo
that referenced
this pull request
Oct 19, 2026
The 1.x lowercase-only port-name constraint is retired and author casing is preserved end to end — DSL, FBP JSON, network ports. `out` and `OUT` are distinct ports. - Ports.add accepts mixed-case names (the 1.x regex required lowercase); the error message drops the lowercase claim. Special characters remain rejected. - FBP JSON import honors the document's caseSensitive flag: false (the 1.x interchange default, where the reference parser lowercased port names) normalizes port names to lowercase at import, so mixed-case references against lowercase-declared 1.x components resolve; true or absent preserves casing as authored, and a case-mismatched reference fails loudly at network build instead of silently resolving. Node ids are preserved as authored (graphs are self-consistent regardless of node-name case). - Spec: spec/CaseSensitivity.js pins preserved casing, the distinctness of case-differing ports, end-to-end wiring and firing, the loud case-mismatch failure, and both legacy-import modes. The 1.x-era uppercase-throw expectations flip to acceptance. - The migration guide: the naming-policy entry with the legacy note. The parser half (the @noflo/fbp caseSensitive default) landed with the noflo#14 work; this completes the policy across the stack.
bergie
added a commit
that referenced
this pull request
Oct 19, 2026
…ession pin (work document #48) Distills the noflo-jekyll document leg (work document #35 updates #14-#22) to its engine shape and runs it through the actual wrapAssembly machinery: a gate-model render component — standing bracket-framed config on a scoped:false control port read non-consumingly, per-message scoped data on two ports gated on both — wrapped as an assembly adapter (Fork, field extractors, CollectFields), driven with bracket-framed scoped message envelopes whose arrival order races the config and stagger with async jitter inside open activations, then driven to EOT with the closedown cascade asserted. The negative result this suite pins: on the current engine (post-#1094 control gates, #1092 drain-based closing, #1099 drain pump), roughly 1300 randomized runs across staggered, burst, bounded-edge, multi- registration-config, and deep-overlap variants delivered every message and closed down — the intermittent drop class the testbed documented did not reproduce. Three randomized variants run in CI; the full matrix rides the WD48_* env knobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, add a test for the Replace component.