8000 devShells.full: fix it by using `inputsFrom` instead of `imports` by jfly · Pull Request #877 · nix-community/nix-init · GitHub
[go: up one dir, main page]

Skip to content

devShells.full: fix it by using inputsFrom instead of imports - #877

Merged
figsoda merged 1 commit into
nix-community:mainfrom
jfly:fix-full-devShell
Sep 14, 2026
Merged

figsoda merged 1 commit into
nix-community:mainfrom
jfly:fix-full-devShell

Conversation

@jfly
@jfly jfly commented Sep 13, 2026 •
Copy link
Copy Markdown
Contributor

This devShells.full was added
recently
, and it
just didn't work. Now it does!

@jfly
jfly commented Sep 13, 2026
Copy link
Copy Markdown
Contributor Author

This caused me to lose a few hours when trying to contribute to this project. The broken devshell caused #876, and some confusion about the missing data/* symlinks that are supposed to be created by the dev shell's shellHook.

@jfly
jfly force-pushed the fix-full-devShell branch from 1258ea0 to 631e2c3 Compare September 14, 2026 04:45
This `devShells.full` was [added
recently](nix-community#852), and it
just didn't work. Now it does!
@jfly
jfly force-pushed the fix-full-devShell branch from 631e2c3 to b925dbf Compare September 14, 2026 04:46
@jfly jfly changed the title devShells.full: fix it devShells.full: fix it by using inputsFrom instead of imports Sep 14, 2026
@figsoda figsoda left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! sorry about that

@figsoda
figsoda merged commit 7884840 into nix-community:main Sep 14, 2026
3 checks passed
@jfly
jfly deleted the fix-full-devShell branch October 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0