Repository navigation
feat(flake): add a new devshell that includes full dev tools - #852
Conversation
4617e67 to
12499f3
Compare
e52aec6 to
164e503
Compare
There was a problem hiding this comment.
i dont really want this in the default shell, can you put this in a separate shell called something like full
Then I will make direnv refer full then. Because preferably I want to see friction reduced for people who are trying to contribute to this project and my own friction when contributing. |
|
that's fine with me, i dont use the envrc, i think it would be a better idea to gitignore it but honestly im ok with either options here |
164e503 to
6d46165
Compare
6d46165 to
54eeee2
Compare
There was a problem hiding this comment.
i will move it into default in a follow up
| ''; | ||
| }; | ||
| full = pkgs.mkShell { | ||
| imports = [ config.devShells.default ]; |
There was a problem hiding this comment.
@eveeifyeve, what does this imports = ...; do? AFAICT, it's totally useless: #877
There was a problem hiding this comment.
I thought mkshell supports this?
There was a problem hiding this comment.
Looks like it can be fixed by a simple case of inputsFrom
There was a problem hiding this comment.
I've read the code and the docs, I see nothing about this. I also tried it, and it doesn't do anything. Am I missing something?
There was a problem hiding this comment.
Actually it is my mistake, huh. I think I meant inputsFrom and probably got confused. Sounds like my shells are broken in prod as well. 😆 Nope, I guess I got I confused this time, I blame flake-parts for that. 😆
There was a problem hiding this comment.
I don't think inputsFrom would work here either. Maybe we'd get the packages, but there's also a shell hook we need.
There was a problem hiding this comment.
I don't think
inputsFromwould work here either. Maybe we'd get the packages, but there's also a shell hook we need.
This `devShells.full` was [added recently](nix-community#852), and it just didn't work. Now it does!
There is annoyance that I commonly run into when developing nix-init and maybe pottentially others, no rust tooling in the devshell AUGH. This pr changes that FINALLY! by adding the fenix latest toolchain to devshell.
/CC @figsoda for review.