8000 Antalya 26.8: Fix stale assertion in test_create_table_engine_backend_mismatch_rejected(Glue) by subkanthi · Pull Request #2869 · Altinity/ClickHouse · GitHub
[go: up one dir, main page]

Skip to content

Antalya 26.8: Fix stale assertion in test_create_table_engine_backend_mismatch_rejected(Glue) - #2869

Open
subkanthi wants to merge 1 commit into
antalya-26.8from
fix-glue-engine-mismatch-assertion
Open

subkanthi wants to merge 1 commit into
antalya-26.8from
fix-glue-engine-mismatch-assertion

Conversation

@subkanthi
@subkanthi subkanthi commented Nov 13, 2026 •
Copy link
Copy Markdown
Collaborator

Fix assertion error in tests/integration/test_database_glue/test.py

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix assertion error in tests/integration/test_database_glue/test.py

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@github-actions
Copy link
Copy Markdown

Workflow [PR], commit [76d8708]

@svb-alt svb-alt added antalya antalya-26.8 Session label (releasy session config) labels Nov 16, 2026
@subkanthi
subkanthi marked this pull request as ready for review November 16, 2026 02:03
@subkanthi subkanthi changed the title Fix stale assertion in test_create_table_engine_backend_mismatch_reje… Antalya 26.8: Fix stale assertion in test_create_table_engine_backend_mismatch_rejected Nov 16, 2026
@subkanthi subkanthi changed the title Antalya 26.8: Fix stale assertion in test_create_table_engine_backend_mismatch_rejected Antalya 26.8: Fix stale assertion in test_create_table_engine_backend_mismatch_rejected(Glue) Nov 16, 2026
@zvonand
zvonand commented Nov 16, 2026
Copy link
Copy Markdown
Member

@blau-ai

@blau-ai
blau-ai commented Nov 16, 2026
Copy link
Copy Markdown
Collaborator

CI triage for 76d8708

Verdict: 1 failing check (Swarms regression). This PR did not cause it: the same failure shows up on other antalya-26.8 PRs. No fix is needed in this PR.

Check Status Caused by this PR?
RegressionTestsRelease / Swarms / swarms (+ Regression release swarms status) ❌ 4 scenarios failed No, the same failures are on other antalya-26.8 PRs
Everything else that ran (5 builds, Integration tests amd_asan_ubsan db disk old analyzer 1/8, Stress amd_debug/amd_asan_ubsan, …) ✅ n/a

Swarms regression (job, report)

✘ [ Fail ] '/swarms/feature/cluster discovery/check cluster discovery with wrong cluster name'
✘ [ Fail ] '/swarms/feature/node failure/check restart swarm node'
✘ [ Fail ] '/swarms/feature/node failure/cpu overload'
✘ [ Fail ] '/swarms/feature/node failure/cpu overload all swarm nodes'
    AssertionError

Why this is not from this PR:

Next step: none for this PR. The Swarms failures (cluster discovery with a wrong cluster name, swarm node restart, cpu overload) are a problem on antalya-26.8 itself or in the regression suite, and should be tracked separately from this PR.

The edited test itself

The changed test ran in Integration tests (amd_asan_ubsan, db disk, old analyzer, 1/8) and passed:

[gw2] [ 35%] PASSED test_database_glue/test.py::test_create_table_engine_backend_mismatch_rejected

So the new assertion (Table setting \disk` differs from its value in this DataLakeCatalog … would be lost`) matches what the server on this branch returns.

Note: most other jobs show SKIPPED. That's because of this PR's CI/CD options (e.g. Aarch64 excluded) and test-only job selection, not because they failed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-26.8 Session label (releasy session config)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0