Repository navigation
Conversation
Backport ClickHouse#126267 onto `antalya-26.8`. Co-authored-by: Cursor <cursoragent@cursor.com>
CI triage for
|
| Check | Verdict |
|---|---|
Integration (amd_asan_ubsan, db disk, old analyzer, 1/8): test_database_glue::test_create_table_engine_backend_mismatch_rejected |
Already failing on base (stale assertion); fix is in #2869 |
Integration (… 7/8): 2× test_backward_compatibility/test_custom_s3_disk_remote_url_allow_hosts |
Already failing on base / infra |
| Stateless (amd_asan_ubsan, cas s3 storage, parallel, 1/2 and 2/2) | Job timeout, not a test failure; same on other PRs |
| Regression release swarms | Already failing on base |
| DCO | Commit has no Signed-off-by line |
1. test_database_glue/test.py::test_create_table_engine_backend_mismatch_rejected
E AssertionError: Received exception from server (version 26.8.34):
E Code: 36. DB::Exception: ... Table setting `disk` differs from its value in this DataLakeCatalog. ...
5. src/Databases/DataLake/DatabaseDataLake.cpp:1213:23: DB::DatabaseDataLake::validateCreateTableEngine
The server rejects the query with the error it is supposed to raise; the test's assertion just doesn't match it any more. This PR doesn't touch DatabaseDataLake.cpp. The same test fails on #2846 and #2831. Next step: nothing to do here. Open PR #2869 fixes the assertion.
2. test_backward_compatibility/test_custom_s3_disk_remote_url_allow_hosts.py (both tests)
File: test_backward_compatibility/test_custom_s3_disk_remote_url_allow_hosts.py:51 - in started_cluster
E Exception: Timed out while waiting for instance `node' with ip address 172.16.4.6 to start.
The cluster fixture fails before any test code runs. This is a backward-compatibility test with an old server, and the failure is in startup, not in Iceberg code. Both tests fail the same way on #2846. Next step: nothing PR-specific.
3. Stateless tests (amd_asan_ubsan, cas s3 storage, parallel, 1/2 and 2/2): ERROR
WARNING: Timeout exceeded [12600] for [4621]
WARNING: Job timed out: [Stateless tests (amd_asan_ubsan, cas s3 storage, parallel, 2/2)], timeout [12600], exit code [-15]
- No test failed. Both shards were still running tests steadily (all
[ OK ]) when the 3.5 h job limit killed them, at about 3000/6892 and 4453/6935 tests. - The PR's new tests ran and passed every time they ran:
05407_iceberg_metadata_s3_requests,05408_…,05409_…(×2),05441_…(×2). - The same two shards also hit
ERRORat about 12 650 s on Antalya 26.8 Backport of #131154 - Reject out-of-rangeDecimalscale when reading aField#2846. On CAS improvements for antalya-26.8 #2831, the tsan and msan variants of this job hit the same limit too.
This is a job budget problem with this configuration (ASan plus the CAS S3 disk is slow). It doesn't come from this PR. Next step: nothing PR-specific. A CI-side fix would be more shards or a higher timeout for this job.
4. Regression release swarms
The failing scenarios are the same as on #2846:
✘ [ Fail ] '/swarms/feature/cluster discovery/check cluster discovery with wrong cluster name'
✘ [ Fail ] '/swarms/feature/node failure/cpu overload'
✘ [ Fail ] '/swarms/feature/node failure/cpu overload all swarm nodes'
Example error: Code: 279 ... Cannot connect to any replica for query execution. (ALL_CONNECTION_TRIES_FAILED). These cover cluster discovery and node overload, which this PR doesn't touch. Next step: none.
5. DCO
The only commit (02113e654c, author Konstantin Vedernikov) has no Signed-off-by: line. Other backports (#2846, #2845) fail DCO for the same reason.
Next step (optional): to turn DCO green, amend the commit with git commit --amend -s and push it. That needs a force-push, which I'm not allowed to do. The other option is to have a maintainer override DCO in the GitHub UI.
Bottom line: none of the failures need a code change in this PR. The new Iceberg tests pass in CI.
Builds and tests on the arm, tsan and msan variants were skipped by this PR's CI options, so this PR has no signal from them.
Backport of ClickHouse#126267 by @scanhex12.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use less s3 requests to get metadata file (ClickHouse#126267 by @scanhex12)
Documentation entry for user-facing changes
Reduce the number of S3 requests when reading Iceberg tables by reusing metadata lookups and caching parsed
metadata.jsonfiles: one GET and one LIST instead of three GETs and two LISTs.CI/CD Options
Exclude tests:
Regression jobs to run: