8000 Deployed Resource Cleanup by mbrat2005 · Pull Request #114 · Azure/alz-monitor · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Deployed Resource Cleanup - #114

Closed
Matthew Bratschun (mbrat2005) wants to merge 34 commits into
Azure:mainfrom
mbrat2005:deployed-resource-cleanup
Closed

Matthew Bratschun (mbrat2005) wants to merge 34 commits into
Azure:mainfrom
mbrat2005:deployed-resource-cleanup

Conversation

@mbrat2005
@mbrat2005 Matthew Bratschun (mbrat2005) commented Mar 29, 2023 •
Copy link
Copy Markdown
Collaborator

Adds the following tag/metadata/description to resources deployed by ALZ-Monitor to ensure they can effectively be cleaned up.

- Metric and Query Rule Alerts:
	○ Tag: _deployed_by_alz_monitor: true
- Policy definitions:
	○ Metadata: source: 'https://github.com/Azure/ALZ-Monitor/'
- Policy set defintions: 
	○ Metadata: "source": "https://github.com/Azure/ALZ-Monitor/"
- Policy assignments:
	○ Metadata: _deployed_by_alz_monitor: true
    - Policy assignment role assignments: 
            ○  Description contains '_deployed_by_alz_monitor'

Adds the script src\scripts\Start-ALZMonitorCleanup.ps1 to execute the cleanup. The script uses Resource Graph to gather resources across all accessible Management Groups for removal. Includes -WhatIf and -ReportOnly functionality for dry runs and evaluation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be tested Paul Grimley (@paulgrimley) to create user story and link

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work Matthew Bratschun (@mbrat2005) :-) just a few comments. Paul Grimley (@paulgrimley) for awareness.

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments more :-)

  1. Could you please update the version on all the policy/initiative definitions? Since we are using semantic versioning it should typically be change 1.0.0 to 1.0.1.
  2. Could you update the deploymentguide on how to use the script?

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Matthew Bratschun (@mbrat2005), pending successful testing by maheshbenke and Sacha Narinx (@Springstone) we'll approve and merge

@mbrat2005
Copy link
Copy Markdown
Collaborator Author

Jan Faurskov (@jfaurskov) My fork of the repo seems to have become disassociated with the main project--perhaps because I added Mahesh and Sacha with access? I think I need to close this PR and open a new one from a new fork. I did make some changes following feedback...

@paulgrimley
Copy link
Copy Markdown
Contributor

Matthew Bratschun (@mbrat2005) as we've just gone public with the repo one of the side effects is it breaks your fork so you will need to re fork i'm afraid

@mbrat2005
Copy link
Copy Markdown
Collaborator Author

Created a new PR from a new fork (required after alz-monitor went public). See: #139

@mbrat2005
Copy link
Copy Markdown
Collaborator Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0