Repository navigation
Deployed Resource Cleanup - #114
Matthew Bratschun (mbrat2005) wants to merge 34 commits into
Conversation
There was a problem hiding this comment.
To be tested Paul Grimley (@paulgrimley) to create user story and link
There was a problem hiding this comment.
great work Matthew Bratschun (@mbrat2005) :-) just a few comments. Paul Grimley (@paulgrimley) for awareness.
There was a problem hiding this comment.
A couple comments more :-)
- Could you please update the version on all the policy/initiative definitions? Since we are using semantic versioning it should typically be change 1.0.0 to 1.0.1.
- Could you update the deploymentguide on how to use the script?
There was a problem hiding this comment.
Great work Matthew Bratschun (@mbrat2005), pending successful testing by maheshbenke and Sacha Narinx (@Springstone) we'll approve and merge
|
Jan Faurskov (@jfaurskov) My fork of the repo seems to have become disassociated with the main project--perhaps because I added Mahesh and Sacha with access? I think I need to close this PR and open a new one from a new fork. I did make some changes following feedback... |
|
Matthew Bratschun (@mbrat2005) as we've just gone public with the repo one of the side effects is it breaks your fork so you will need to re fork i'm afraid |
|
Created a new PR from a new fork (required after alz-monitor went public). See: #139 |
|
Thanks Paul, I recreated the PR from a new fork and closed the old one.
…________________________________
From: Paul Grimley ***@***.***>
Sent: Thursday, April 27, 2023 14:44
To: Azure/alz-monitor ***@***.***>
Cc: Matthew Bratschun ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/alz-monitor] Deployed Resource Cleanup (PR #114)
@mbrat2005<https://github.com/mbrat2005> as we've just gone public with the repo one of the side effects is it breaks your fork so you will need to re fork i'm afraid
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGBW6WDWLYD7IH342TGX663XDLLBBANCNFSM6AAAAAAWMBPPHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Adds the following tag/metadata/description to resources deployed by ALZ-Monitor to ensure they can effectively be cleaned up.
Adds the script src\scripts\Start-ALZMonitorCleanup.ps1 to execute the cleanup. The script uses Resource Graph to gather resources across all accessible Management Groups for removal. Includes -WhatIf and -ReportOnly functionality for dry runs and evaluation.