8000 Created parameter File and updated the Deployment and Customization Documentation by arjenhuitema · Pull Request #124 · Azure/alz-monitor · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Created parameter File and updated the Deployment and Customization Documentation - #124

Merged
Jan Faurskov (jfaurskov) merged 22 commits into
Azure:mainfrom
arjenhuitema:main
Apr 20, 2023
Merged

Jan Faurskov (jfaurskov) merged 22 commits into
Azure:mainfrom
arjenhuitema:main

Conversation

@arjenhuitema
@arjenhuitema Arjen Huitema (arjenhuitema) commented Apr 13, 2023 •
Copy link
Copy Markdown
Collaborator

Changes include:

  • standard parameter file
  • 4 complete parameter files, one for each initiative.
  • updated deployment guides
  • updated the assign_initiatives_.biceps to include the parameters. Passing a general parameter object parPolicyAssignmentParameters, and 4 specific objects parPolicyAssignmentParametersConnectivity/Identity/Management/LZ, and parPolicAssignmentParametersAlertProcessing
  • Added parameters to ActivityLog policies: parResourceGroupLocation
  • Added parameters to AlertProcessing: ALZMonitorActionGroupEmail
  • Changed parameter in AlertProcessing from alertResourceGroupName and alertResourceGroupTags to ALZMonitorResourceGroupName and ALZMonitorResourceGroupTags. This is aligned with naming in the Initiatives. Like this we only need to add one parameter entry in the Parameter files.
  • Updated the initiatives with the parameter: ALZMonitorResourceGroupLocation

@arjenhuitema Arjen Huitema (arjenhuitema) changed the title Created parameter File and updated the Deployment and Costimization Documentation Created parameter File and updated the Deployment and Customization Documentation Apr 13, 2023
Comment thread docs/wiki/DeploymentGuide.md Resolved
Comment thread docs/wiki/DeploymentGuide.md Resolved
@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Arjen Huitema (@arjenhuitema), just a few comments :-)

Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a couple of open questions before approving

Comment thread docs/wiki/DeploymentGuide.md Resolved
@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions more

@jfaurskov Jan Faurskov (jfaurskov) left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov
Jan Faurskov (jfaurskov) merged commit aa437bc into Azure:main Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0