Repository navigation
feat(health): reserve the KVP report key before provisioning - #364
Draft
Peyton Robertson (peytonr18) wants to merge 2 commits into
Draft
Peyton Robertson (peytonr18) wants to merge 2 commits into
Peyton Robertson (peytonr18) wants to merge 2 commits into
Conversation
Write an in_progress report before provisioning to clear previous failure context and reserve the key for the final update. This avoids new-key limit failures caused by later diagnostic growth.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 97.73% 97.91% +0.17%
==========================================
Files 29 29
Lines 10176 10475 +299
==========================================
+ Hits 9946 10257 +311
+ Misses 230 218 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final health reporting can be rejected at the KVP store's 1,024-key limit when
PROVISIONING_REPORTdoes not already exist. This PR reserves that key before provisioning, allowing the final success/failure report to update it even if diagnostics add more keys later.The initial value is a typed
in_progressreport with a fresh timestamp and no previous failure context. The new state is supported in report encoding, parsing, and parsed CLI output. Only actual provisioning attempts write it; cleanup and already-provisioned paths remain unchanged.Relies on PR #363 to be merged in first, as these changes depend on the initial health wiring.
Testing done