Repository navigation
feat(design-system): add button CTA variant to Alert - #8203
Merged
Merged
Conversation
Adds cta="button" for the Dharma "Status=Neutral, Size=Wide, Title=Yes, CTA=Button" alert: panel surface, default border, 6px radius, a primary Button in AlertActions, and a filled Zap icon in icon-link. Other icons stay outline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Preview Deploys
|
gabrielle-svg
temporarily deployed
to
development
November 5, 2026 22:23 — with 
GitHub Actions
Inactive
gabrielle-svg
temporarily deployed
to
development
November 5, 2026 22:23 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Allow cta="button" only on neutral wide alerts, where it has a look. Fill icons marked data-filled instead of keying off Lucide's lucide-zap class, and drop the no-op `link` value.
macko911
approved these changes
Nov 6, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds the Alert variant Status=Neutral, Size=Wide, Title=Yes, CTA=Button from the design system (Figma): a neutral banner on a panel surface with a primary button instead of a text link.
Changes
cta="button"prop. Without it, existing alerts render exactly as before.cta="button"withvariant="neutral"and the Wide size, the one combination the design defines.surface-panelbackground, aborder-defaultborder androunded-ds-mdradius. Layout reuses the Wide size.data-filledis drawn filled inicon-link. Other icons keep the usual outline style.<Button size="md">inAlertActions.Testing
Storybook:
Design System/Components/Alert→ Button CTA. Check it in light and dark: panel background, border, 6px radius, 32px button, and a filled Zap icon.