Repository navigation
Conversation
Contributor
Preview Deploys
|
Contributor
There was a problem hiding this comment.
1 issue found across 30 files
Confidence score: 4/5
- The new catalog events in
packages/types/lib/analytics/catalogue.tsuseproviderfor an integration identity, splitting the same fact across two PostHog property names. Rename it tointegrationin both the event schemas and emitters.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/types/lib/analytics/catalogue.ts">
<violation number="1" location="packages/types/lib/analytics/catalogue.ts:351">
P2: These new catalog events use `provider` for an integration identity, creating a second PostHog taxonomy name for the same fact. Rename this property to `integration` in both new event schemas and emitters so catalog analytics remain queryable with the existing integration dimensions.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| 8000 | surface: 'web', | |
| insight: 'Which APIs people open from the catalog, and whether Instant setup or already configured APIs draw more interest', | ||
| fires: 'When someone clicks an API card in the catalog', | ||
| properties: z.object({ provider: z.string(), is_instant_setup: z.boolean(), is_configured: z.boolean() }) |
Contributor
There was a problem hiding this comment.
P2: These new catalog events use provider for an integration identity, creating a second PostHog taxonomy name for the same fact. Rename this property to integration in both new event schemas and emitters so catalog analytics remain queryable with the existing integration dimensions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/types/lib/analytics/catalogue.ts, line 351:
<comment>These new catalog events use `provider` for an integration identity, creating a second PostHog taxonomy name for the same fact. Rename this property to `integration` in both new event schemas and emitters so catalog analytics remain queryable with the existing integration dimensions.</comment>
<file context>
@@ -336,9 +336,25 @@ export const analyticsEventCatalogue = defineCatalogue({
+ surface: 'web',
+ insight: 'Which APIs people open from the catalog, and whether Instant setup or already configured APIs draw more interest',
+ fires: 'When someone clicks an API card in the catalog',
+ properties: z.object({ provider: z.string(), is_instant_setup: z.boolean(), is_configured: z.boolean() })
+ },
+ 'integrations:setup_button_click': {
</file context>
Contributor
Author
There was a problem hiding this comment.
integration unfortunately doesn't describe this well. An integration is a configuration, a provider is it's listing in the catalog. I considered adding a new category of events eg. catalog:card_click, but wasn't fully convinced.
@macko911 would love your opinion.
kaposke
force-pushed
the
gui/NAN-8078/feat-catalog
branch
from
November 6, 2026 13:30
49c77ce to
4844269
Compare
kaposke
force-pushed
the
gui/NAN-8078/feat-catalog
branch
from
November 6, 2026 15:38
4844269 to
ce0e5d0
Compare
kaposke
force-pushed
the
gui/NAN-8078/feat-catalog
branch
from
November 6, 2026 16:43
ce0e5d0 to
5646409
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes NAN-8078. 4/4.
New Catalog page, replacing the "Create integration" provider list. Design: Figma and the designer handoff.
Grid (
/:env/catalog)/to focus), "Popular first" / "A–Z" sort, and an "Instant setup only" switch. All filters are in the URL.xl/3xl/4xlbreakpoints, 48 cards then "Show more".Detail (
/:env/catalog/:provider)Rules (
catalog.utils.ts, unit te 8000 sted)popularcategory, which is never shown as a category.Also
integrations/createlink now points to the catalog, that route redirects, andCreateList.tsxis deleted.Alert'scta="button"variant from feat(design-system): add button CTA variant to Alert #8203.Alertalso getsicon="success"for the configured callout's green check. Thetailwind-mergeconfig now knows one-side token borders (border-l-ds-2…), whichcnused to drop.integrations:catalog_link_clickandintegrations:setup_button_click.integrations:filter_updategainscategory,instant_setupandsortfilter values and an optionalpage.SlidingPanelLayout, now shared with the Functions tab.Known gaps
Testing:
/dev/catalog. Toggle the filters, reload, search, open Show more. Open a managed OAuth provider (Airtable), an API key or two-step one (3CX), one you've configured, and a function with nested fields.🤖 Generated with Claude Code