8000 docs: add CLAUDE.md, branch + PR workflow from here on by simon-inkie · Pull Request #1 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

docs: add CLAUDE.md, branch + PR workflow from here on - #1

Merged
simon-inkie merged 2 commits into
mainfrom
docs/branch-pr-workflow
Aug 17, 2026
Merged

simon-inkie merged 2 commits into
mainfrom
docs/branch-pr-workflow

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Establishes the branch + PR workflow going forward, per Simon's instruction now that the repo is live. No direct pushes to main after this.

Simon added 2 commits August 17, 2026 17:35
Direct pushes to main stop now that the repo is live. Every change,
human or agent, goes through a branch and a pull request.
Wrote the internal product's old name in the very commit adding the
branch/PR policy. Matched README's established phrasing instead.
@simon-inkie
simon-inkie merged commit c95abce into main Aug 17, 2026
1 of 4 checks passed
simon-inkie added a commit that referenced this pull request Aug 18, 2026
check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so
test (22.x) and test (24.x) both fail 4 cases on every run, including
pushes to main.

gitleaks-action reads the PR's commit list via the GitHub API. The
default GITHUB_TOKEN for a pull_request-triggered run on a private
repo doesn't carry pull-requests:read unless a job grants it, so the
guards job 403s on every PR (confirmed identical on #1 before this
branch existed).

Neither is caused by any code in this repo; both are CI config gaps.

Co-authored-by: Simon <simon@inkie.ink>
simon-inkie added a commit that referenced this pull request Aug 18, 2026
…ope (#5)

* fix(leak-gate): exempt maintainer's mail-domain address in message scope

GitHub's squash-merge writes a Co-authored-by trailer carrying the
maintainer's address onto the merge commit (seen on #1's merge,
c95abce). That address already sits in the author/committer header of
every commit here by the same deliberate, standing decision that
exempts his first name in message scope (principal-first-name, above):
denying in a trailer what the header of the same commit states
outright is theatre.

Stays fully enforced over file content, where no such decision covers
an address pasted into a doc or fixture.

* fix(leak-gate): narrow the email exemption to the exact trailer shape

Review feedback (independent model-diverse pass, 2026-08-17): the
previous fix set messageExempt: true on company-email-address wholesale,
which suppressed the rule for every address on the domain in every
message shape, not just the one pre-approved instance (the maintainer's
GitHub-generated Co-authored-by trailer). That's a materially broader
PII hole than the principal-first-name precedent it was modelled on,
since a domain-wide rule covers more than one person's identity.

Adds messageExemptPattern: a narrower, anchored allow-pattern checked
only when the rule's own pattern already matched. Only the maintainer's
exact, known Co-authored-by trailer shape is skipped; any other address
on the domain, or this same address in a different message shape, still
fires. Verified with a probe commit carrying a different employee's
address in the same trailer position, which still trips the rule.

* test(leak-gate): pin the message-scope exemption's narrow-by-construction shape

Review feedback: --self-test exercised content, filename and binary-sniff
scanning, but never scanMessages or the exemption semantics, so the new
messageExemptPattern boundary could regress while self-test stayed green.

Pulls the per-line matching logic out of scanMessages into scanMessageLine
so it's directly testable without a real commit, then pins three cases
built from fragments (never the literal string, per this file's own
convention): the approved trailer shape is skipped, the same address
outside that shape still fires, and a different address in the same
trailer shape still fires.

---------

Co-authored-by: Simon <simon@inkie.ink>
@simon-inkie
simon-inkie deleted the docs/branch-pr-workflow branch August 18, 2026 15:27
simon-inkie added a commit that referenced this pull request Aug 18, 2026
* docs: add CLAUDE.md, branch + PR workflow from here on

Direct pushes to main stop now that the repo is live. Every change,
human or agent, goes through a branch and a pull request.

* fix(docs): CLAUDE.md named the internal platform, leak-gate caught it

Wrote the internal product's old name in the very commit adding the
branch/PR policy. Matched README's established phrasing instead.

---------

Co-authored-by: Simon <simon@inkie.ink>
simon-inkie added a commit that referenced this pull request Aug 18, 2026
check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so
test (22.x) and test (24.x) both fail 4 cases on every run, including
pushes to main.

gitleaks-action reads the PR's commit list via the GitHub API. The
default GITHUB_TOKEN for a pull_request-triggered run on a private
repo doesn't carry pull-requests:read unless a job grants it, so the
guards job 403s on every PR (confirmed identical on #1 before this
branch existed).

Neither is caused by any code in this repo; both are CI config gaps.

Co-authored-by: Simon <simon@inkie.ink>
simon-inkie added a commit that referenced this pull request Aug 18, 2026
…ope (#5)

* fix(leak-gate): exempt maintainer's mail-domain address in message scope

GitHub's squash-merge writes a Co-authored-by trailer carrying the
maintainer's address onto the merge commit (seen on #1's merge,
e6e400d). That address already sits in the author/committer header of
every commit here by the same deliberate, standing decision that
exempts his first name in message scope (principal-first-name, above):
denying in a trailer what the header of the same commit states
outright is theatre.

Stays fully enforced over file content, where no such decision covers
an address pasted into a doc or fixture.

* fix(leak-gate): narrow the email exemption to the exact trailer shape

Review feedback (independent model-diverse pass, 2026-08-17): the
previous fix set messageExempt: true on company-email-address wholesale,
which suppressed the rule for every address on the domain in every
message shape, not just the one pre-approved instance (the maintainer's
GitHub-generated Co-authored-by trailer). That's a materially broader
PII hole than the principal-first-name precedent it was modelled on,
since a domain-wide rule covers more than one person's identity.

Adds messageExemptPattern: a narrower, anchored allow-pattern checked
only when the rule's own pattern already matched. Only the maintainer's
exact, known Co-authored-by trailer shape is skipped; any other address
on the domain, or this same address in a different message shape, still
fires. Verified with a probe commit carrying a different employee's
address in the same trailer position, which still trips the rule.

* test(leak-gate): pin the message-scope exemption's narrow-by-construction shape

Review feedback: --self-test exercised content, filename and binary-sniff
scanning, but never scanMessages or the exemption semantics, so the new
messageExemptPattern boundary could regress while self-test stayed green.

Pulls the per-line matching logic out of scanMessages into scanMessageLine
so it's directly testable without a real commit, then pins three cases
built from fragments (never the literal string, per this file's own
convention): the approved trailer shape is skipped, the same address
outside that shape still fires, and a different address in the same
trailer shape still fires.

---------

Co-authored-by: Simon <simon@inkie.ink>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0