Repository navigation
ci: install ripgrep, grant guards job pull-requests:read - #4
Merged
Merged
Conversation
check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so test (22.x) and test (24.x) both fail 4 cases on every run, including pushes to main. gitleaks-action reads the PR's commit list via the GitHub API. The default GITHUB_TOKEN for a pull_request-triggered run on a private repo doesn't carry pull-requests:read unless a job grants it, so the guards job 403s on every PR (confirmed identical on #1 before this branch existed). Neither is caused by any code in this repo; both are CI config gaps.
simon-inkie
commented
Aug 17, 2026
Owner
Author
There was a problem hiding this comment.
Independent review outcome: clean. ripgrep is installed in the job that requires it, and the guards job adds only the read permissions needed for checkout and gitleaks pull-request metadata. No write permission or secret-bearing execution path is introduced. I would approve this change, but GitHub prevents the currently authenticated PR-author account from self-approving.
simon-inkie
added a commit
that referenced
this pull request
Aug 18, 2026
check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so test (22.x) and test (24.x) both fail 4 cases on every run, including pushes to main. gitleaks-action reads the PR's commit list via the GitHub API. The default GITHUB_TOKEN for a pull_request-triggered run on a private repo doesn't carry pull-requests:read unless a job grants it, so the guards job 403s on every PR (confirmed identical on #1 before this branch existed). Neither is caused by any code in this repo; both are CI config gaps. Co-authored-by: Simon <simon@inkie.ink>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dashes.test.tscases onubuntu-latest(fails identically onmainpushes).guardsjob explicitpull-requests: readsogitleaks-actioncan list the PR's commits instead of 403ing (confirmed identical on docs: add CLAUDE.md, branch + PR workflow from here on #1 before this branch existed).Neither issue is caused by any code in this repo, both are CI workflow config gaps found while investigating a report of failures.
Test plan
testmatrix legs,guards)