8000 ci: install ripgrep, grant guards job pull-requests:read by simon-inkie · Pull Request #4 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

ci: install ripgrep, grant guards job pull-requests:read - #4

Merged
simon-inkie merged 1 commit into
mainfrom
ci/ripgrep-and-gitleaks-permissions
Aug 18, 2026
Merged

simon-inkie merged 1 commit into
mainfrom
ci/ripgrep-and-gitleaks-permissions

Conversation

@simon-inkie
Copy link
Copy Markdown
Owner

Summary

  • Adds a ripgrep install step before the unit tests, fixing 4 failing dashes.test.ts cases on ubuntu-latest (fails identically on main pushes).
  • Grants the guards job explicit pull-requests: read so gitleaks-action can list the PR's commits instead of 403ing (confirmed identical on docs: add CLAUDE.md, branch + PR workflow from here on #1 before this branch existed).

Neither issue is caused by any code in this repo, both are CI workflow config gaps found while investigating a report of failures.

Test plan

  • CI green on this PR (both test matrix legs, guards)

check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so
test (22.x) and test (24.x) both fail 4 cases on every run, including
pushes to main.

gitleaks-action reads the PR's commit list via the GitHub API. The
default GITHUB_TOKEN for a pull_request-triggered run on a private
repo doesn't carry pull-requests:read unless a job grants it, so the
guards job 403s on every PR (confirmed identical on #1 before this
branch existed).

Neither is caused by any code in this repo; both are CI config gaps.
@simon-inkie simon-inkie left a comment
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review outcome: clean. ripgrep is installed in the job that requires it, and the guards job adds only the read permissions needed for checkout and gitleaks pull-request metadata. No write permission or secret-bearing execution path is introduced. I would approve this change, but GitHub prevents the currently authenticated PR-author account from self-approving.

@simon-inkie
simon-inkie merged commit 6f2d629 into main Aug 18, 2026
4 checks passed
@simon-inkie
simon-inkie deleted the ci/ripgrep-and-gitleaks-permissions branch August 18, 2026 15:27
simon-inkie added a commit that referenced this pull request Aug 18, 2026
check-dashes tests shell out to rg; ubuntu-latest doesn't carry it, so
test (22.x) and test (24.x) both fail 4 cases on every run, including
pushes to main.

gitleaks-action reads the PR's commit list via the GitHub API. The
default GITHUB_TOKEN for a pull_request-triggered run on a private
repo doesn't carry pull-requests:read unless a job grants it, so the
guards job 403s on every PR (confirmed identical on #1 before this
branch existed).

Neither is caused by any code in this repo; both are CI config gaps.

Co-authored-by: Simon <simon@inkie.ink>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0