Repository navigation
<
8000
meta name="react-app-name" content="pull-requests"/>
fix(cbio): read private-bench evidence on the Linux runner (#153) - #183
Closed
shroominic wants to merge 1 commit into
Closed
shroominic wants to merge 1 commit into
shroominic wants to merge 1 commit into
Conversation
The private-bench analyzer refused every artifact on a non-Darwin host with `unsupported_platform`, because the descriptor-bound read only had audited `struct stat` offsets for Darwin. CI runs on ubuntu-latest, so three private-bench tests failed there while passing on the same tip on macOS. Audit the Linux x86_64 glibc layout (mode_t at byte 24, uid_t at byte 28) alongside the existing Darwin64 layout and gate on `_hasAuditedDescriptorLayout()`. ABIs without audited offsets still fail closed with `unsupported_platform`. The ownership, mode, file-type, symlink and size invariants are unchanged, and no assertion is relaxed.
This was referenced Sep 18, 2026
Owner
Author
|
Carried by the GS1 consolidation in PR #209 (branch feature/cbio-gs1, head 3eca4f4). This PR is contained in the consolidated line; the merge that carries it is c85f827. Closing as subsumed by the consolidation - not as won't fix. The per-defect evidence stays in this thread, and the carrying commit above is where the change now lives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153.
Root cause: the private-bench analyzer's descriptor-bound read is Darwin-only.
_readDescriptorBoundreturnedunsupported_platformwheneverPlatform.isMacOSwas false, so on the Linux CI runner every artifact wasrejected before parsing. Exit 66 was that closed failure reason, not a crash
and not a flaky assertion.
Reproduced on the runner itself (same tip
4702025, draft evidence branchrepro/153-private-bench-linux, PR #178):https://github.com/shroominic/OpenGlucose/actions/runs/35308759680
Fix: audit the Linux x86_64 glibc
struct statlayout (mode_t at byte 24,uid_t at byte 28) next to the existing Darwin64 layout, and gate the read on
_hasAuditedDescriptorLayout()instead ofPlatform.isMacOS. Ownership,regular-file, exact-0600 and size invariants are unchanged. An ABI with no
audited offsets still fails closed with
unsupported_platform.No assertion is loosened. The local macOS run stays green (33/33). The Linux
path is verified by this PR's own
Unit Testsjob on ubuntu-latest x86_64.Scope notes:
feature/libre-protocol-capture(feat(sensor): Libre 2 protocol capture and multi-sensor base #119 / feat(sensor): add CBio/SIBIONICS GS1 evidence lane #120 /feat(sensor): add fail-closed live CBio/SIBIONICS GS1 driver #127) for Release OpenGlucose 0.3.0 (sensor lane: Libre 2 capture, GS1 evidence, live GS1 driver) #128, and the Prepare OpenGlucose 0.4.0: GS1 and Anytime 5P integration #139 / chore(release): append the app-live and scan-close lanes to the 0.4.0 aggregate #163 aggregates, because nothing merges to
mainin this program.macOS PreviewandIntegration Testson this PR carry pre-existing redgates owned elsewhere (Lane formatting drift: three unformatted files across #142 and #144 #159 / chore(cbio): format the lane integration harness #152 formatting drift, fix(workspace): make test-integration separates the host and device test roots #140 runner defect).
This PR owns the unit gate on the Linux runner.