Repository navigation
8000
chore(cbio): format the lane integration harness - #152
Closed
shroominic wants to merge 1 commit into
Closed
shroominic wants to merge 1 commit into
shroominic wants to merge 1 commit into
Conversation
`make format-check` fails on this lane in the Quality job: the new `openhealth/integration_test/cbio_glucose_query_test.dart` was committed unformatted, so the CI gate exits 2 before lint runs. This is the formatter's own output, nothing else: `dart format` reports one changed file and `make format-check` then exits 0 across every project.
This was referenced Sep 18, 2026
Owner
Author
|
Carried by the GS1 consolidation in PR #209 (branch feature/cbio-gs1, head 3eca4f4). This PR is contained in the consolidated line; the merge that carries it is c85f827. Closing as subsumed by the consolidation - not as won't fix. The per-defect evidence stays in this thread, and the carrying commit above is where the change now lives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151.
Gate
Qualityis red onfeature/cbio-gs1-glucose-live(#136) atmake format-check, which also meanslintnever runs in that job:Change
openhealth/integration_test/cbio_glucose_query_test.dartnow carries the formatter's own output.One file, whitespace only, no behavior or test-content change.
Verification
dart format --output=none --set-exit-if-changed openhealth/integration_test/cbio_glucose_query_test.dart(before)Changed ...dart format openhealth/integration_test/cbio_glucose_query_test.dartmake format-checkon this branchFormatted 107 files (0 changed)for the applintand the test suites are unaffected by a whitespace-only change; they are still red on thislane for the separate reasons tracked in #153 and the runner issue #140.