8000 fix(ios): restore archived export share sheet by shroominic · Pull Request #80 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]
Skip to content

fix(ios): restore archived export share sheet #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroominic merged 2 commits into from
Aug 31, 2026
Merged

fix(ios): restore archived export share sheet #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae6dca
fix(ios): restore archived export share sheet
shroominic Aug 30, 2026
a786b9a
fix(ios): accept scoped export cache files
shroominic Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ expectations are defined in [docs/compatibility.md](docs/compatibility.md).

## [Unreleased]

### Fixed

- Archived sensor exports now open a native iOS share sheet reliably on
iOS 26. The iPhone path no longer uses popover presentation configuration;
iPad keeps its required anchored popover behavior.

## [0.1.4] - 2026-08-22

### Added
Expand Down
6 changes: 5 additions & 1 deletion docs/privacy/data-handling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ Stable session IDs, storage keys, serials, device IDs, display names, model,
firmware, and driver IDs are omitted. The filename is neutral. Native exports
use one scoped temporary directory, delete their source file after the share
sheet completes, and remove stale OpenGlucose/share-plugin cache copies at the
next launch. Startup also removes the exact legacy
next launch. The app-owned iOS activity-sheet bridge accepts only readable
regular files in immediate `openglucose-export-*` children of the app cache;
resolved paths cannot escape that scope. It configures popover presentation
only on iPad; iPhone uses the standard activity-sheet presentation. Startup
also removes the exact legacy
`openhealth_<sensor-id>_<timestamp>.csv` regular-file shape that older builds
wrote into the platform cache; near-matches, other extensions, directories,
and unrelated cache entries are left untouched. Cleanup is best effort because
Expand Down
4 changes: 4 additions & 0 deletions openhealth/ios/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
AEF02CD831388240EB791BCE /* SwiftUI.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E9A3F3866D70875832C57844 /* SwiftUI.framework */; };
C22A0F3121F3DC145DF706B6 /* GlucoseLiveActivityAttributes.swift in Sources */ = {isa = PBXBuildFile; fileRef = D855B9851A289C72801204A3 /* GlucoseLiveActivityAttributes.swift */; };
E14A0002F2D54BCB87610002 /* PrivacyStorageChannel.swift in Sources */ = {isa = PBXBuildFile; fileRef = E14A0001F2D54BCB87610001 /* PrivacyStorageChannel.swift */; };
E15A0002F2D54BCB87610002 /* ExportShareChannel.swift in Sources */ = {isa = PBXBuildFile; fileRef = E15A0001F2D54BCB87610001 /* ExportShareChannel.swift */; };
E13A0002F2D54BCB87610002 /* NativeRestrictedStateStore.swift in Sources */ = {isa = PBXBuildFile; fileRef = E13A0001F2D54BCB87610001 /* NativeRestrictedStateStore.swift */; };
/* End PBXBuildFile section */

Expand Down Expand Up @@ -109,6 +110,7 @@
D9CD6248FCC2BF8D99C90C3D /* Pods-Runner.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.debug.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"; sourceTree = "<group>"; };
E9A3F3866D70875832C57844 /* SwiftUI.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = SwiftUI.framework; path = Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk/System/Library/Frameworks/SwiftUI.framework; sourceTree = DEVELOPER_DIR; };
E14A0001F2D54BCB87610001 /* PrivacyStorageChannel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PrivacyStorageChannel.swift; sourceTree = "<group>"; };
E15A0001F2D54BCB87610001 /* ExportShareChannel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ExportShareChannel.swift; sourceTree = "<group>"; };
E13A0001F2D54BCB87610001 /* NativeRestrictedStateStore.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NativeRestrictedStateStore.swift; sourceTree = "<group>"; };
E13A0003F2D54BCB87610003 /* LiveActivity.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; name = LiveActivity.xcconfig; path = Flutter/LiveActivity.xcconfig; sourceTree = "<group>"; };
F1661D12E3A5B0B8F7EADF7F /* ActivityKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ActivityKit.framework; path = Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk/System/Library/Frameworks/ActivityKit.framework; sourceTree = DEVELOPER_DIR; };
Expand Down Expand Up @@ -243,6 +245,7 @@
1498D2321E8E86230040F4C2 /* GeneratedPluginRegistrant.h */,
1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */,
74858FAE1ED2DC5600515810 /* AppDelegate.swift */,
E15A0001F2D54BCB87610001 /* ExportShareChannel.swift */,
E14A0001F2D54BCB87610001 /* PrivacyStorageChannel.swift */,
7884E8672EC3CC0400C636F2 /* SceneDelegate.swift */,
16C4FAEE38C24B8B8A121001 /* AidexBackgroundMonitor.swift */,
Expand Down Expand Up @@ -505,6 +508,7 @@
buildActionMask = 2147483647;
files = (
74858FAF1ED2DC5600515810 /* AppDelegate.swift in Sources */,
E15A0002F2D54BCB87610002 /* ExportShareChannel.swift in Sources */,
E14A0002F2D54BCB87610002 /* PrivacyStorageChannel.swift in Sources */,
1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */,
7884E8682EC3CC0700C636F2 /* SceneDelegate.swift in Sources */,
Expand Down
2 changes: 2 additions & 0 deletions openhealth/ios/Runner/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import UIKit

@main
@objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate {
private var exportShareChannel: ExportShareChannel?
private var privacyStorageChannel: PrivacyStorageChannel?

override func application(
Expand Down Expand Up @@ -36,6 +37,7 @@ import UIKit
GlucoseLiveActivityController.shared.configure(
with: messenger
)
exportShareChannel = ExportShareChannel(messenger: messenger)
privacyStorageChannel = PrivacyStorageChannel(messenger: messenger)
}
}
Loading
0